Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Revisions: Issue #44995 All Revisions ] Back to Issue ]
Summary 0044995: Review doPrint promise to find non-returned return points
Revision 2020-09-16 10:35 by caristu
Description As a fix of issue 0044909, we found that not returning the function after executing the resolve() callback could lead to unexpected behavior. It would be convenient to review other flows of the "PrintReceipt.prototype.doPrint" function to find out if there are other missing points to return the execution.

We have identified at least one place where "return resolve();" should be done instead of just "resolve();": https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js#L212 [^]

Revision 2020-09-16 10:31 by caristu
Description As a fix of issue 0044909, we found that not returning the function after executing the resolve() callback could lead to unexpected behavior. It would be convenient to check other flows of this function to find out if there are other missing points to return the execution.


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker