0041422: API Change: Old Costing Cleanup - Openbravo Issue Tracking System

Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Revisions: Issue #41422		[ All Revisions ] [ Back to Issue ]
Summary	0041422: API Change: Old Costing Cleanup

Revision	2019-09-24 10:38 by AtulOpenbravo
Description	Following are the candidates that could be removed as they belong to old costing feature -Sales Invoice Dimensional Report Legacy -Generate Average Costs -Valued Stock Report Legacy -Create Production Costs -Pareto Product Report Legacy -Costing Migration Process -Costing Status -M_UPDATE_PARETO_PRODUCT_LEGACY *Remove related DB functions, Menu's, Model Object and their Mapping, unused html files, xml files, xsql, java classes & methods, ad_elements, text interfaces, messages etc. Missing class -org.openbravo.costing.CostingMigrationProcess -org.openbravo.costing.CostingStatus -org.openbravo.erpCommon.ad_reports.ReportInvoiceCustomerDimensionalAnalysesJR_legacy -org.openbravo.erpCommon.ad_reports.ReportParetoProductLegacy -org.openbravo.erpCommon.ad_reports.ReportValuationStock_legacy Missing methods -org.openbravo.erpCommon.reference.ActionButtonData.process1000500001(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process182(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process800085(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process800151(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.model.materialmgmt.cost.Costing.getGoodsShipmentLine() -org.openbravo.model.materialmgmt.cost.Costing.getProductionLine() -org.openbravo.model.materialmgmt.cost.Costing.setGoodsShipmentLine(org.openbravo.model.materialmgmt.transaction.ShipmentInOutLine) -org.openbravo.model.materialmgmt.cost.Costing.setProductionLine(org.openbravo.model.materialmgmt.transaction.ProductionLine) -org.openbravo.model.common.plm.Product.getCostType() -org.openbravo.model.common.plm.Product.getStandardCost() -org.openbravo.model.common.plm.Product.setCostType(java.lang.String) -org.openbravo.model.common.plm.Product.setStandardCost(java.math.BigDecimal) Missing Fields -org.openbravo.model.common.plm.Product.PROPERTY_COSTTYPE -org.openbravo.model.common.plm.Product.PROPERTY_STANDARDCOST -org.openbravo.model.materialmgmt.cost.Costing.PROPERTY_GOODSSHIPMENTLINE -org.openbravo.model.materialmgmt.cost.Costing.PROPERTY_PRODUCTIONLINE **Below references in external modules found A. CostingStatus allMods-SUP/org.openbravo.warehouse.reportvaluedstockenhanced, ReportValuedStockEnhanced.java class line no 34 allMods-NI/br.com.disoft.brazil.ce.core, InvoiceCustomerDimensionalAnalysesJR.java class line no 299 Need to remove if loop which has CostingStatus.IsMigrated == false check, it wont be never executed. It is safe to remove. B. Product : CostType (setCostType() method) i. allMods-SUP/org.openbravo.module.idljava SampleProductsProcess.java class, line no204. ii. allMods-SUP/org.openbravo.service.integration.sap.ecc.mappings, ProductOBObjectInitializer.java class, line no 29 iii. allMods-NI/com.tds.openbravo.magento, ProductSynchronization.java class, line no 19 Only set method is use and get method is not, hence safe to remove. iv. allMods-NI/fr.phidias.openbravo.retail: m_product.costtype is used in view PHPOS_PRODUCT_V, PHPOS_PRODUCTPRICE_V v. allMods-NI/org.wirabumi.gen.oez: m_product.costtype is used in function OEZ_IMPORTPRODUCTCOST as below: --get costtype select costtype into v_costtype from m_product where m_product_id=cur_productcost.m_product_id; if v_costtype is null then v_costtype='AV'; --default costtype is Average update m_product set costtype='AV' where m_product_id=cur_productcost.m_product_id; --updating costtype end if; C. Product: CostStd (setStandardCost() method) i. allMods-SUP/org.openbravo.module.idljava, SampleProductsProcess.java class, line no 224 ii. allMods-NI/com.tds.openbravo.magento, ProductSynchronization.java class, line no 69 & 71 Only set method is use and get method is not, hence safe to remove. iii. allMods-NI/fr.phidias.openbravo.retail: m_product.coststd is used in view PHPOS_PRODUCT_V, PHPOS_PRODUCTPRICE_V D. DB Function: M_GENERATE_AVERAGE_COSTS i. allMods-NI/com.sidesoft.localization.ecuador.withholdings, SSWH_GENERATE_STATUS, line no 122 ii. allMods-NI/com.sidesoft.localization.ecuador.withholdings, SSWH_GENERATE_CHECK, line no 161 The above two functions uses M_GENERATE_AVERAGE_COSTS but the piece of code is commented. Hence removal is safe. - Sample data changes related to removed column's, process access can be managed in Core, Retail Sample Data & AWP Sample Data modules, hence removing of the above deletion candidate has low risk.

Revision	2019-07-22 22:31 by AtulOpenbravo
Description	In a migrated instance or new instance when running below reports and process a warning is shown that "You can't use this report because your instance is migrated to new cost engine" so the below candidates are not used any more. -Create Production Costs -Generate Average Costs -Valued Stock Report Legacy -Sales Invoice Dimensional Report Legacy -Pareto Product Report Legacy -M_UPDATE_PARETO_PRODUCT_LEGACY Along with above candidates, their related DB functions, AD_MENU, AD_PROCESS, AD_MODEL_OBJECT, AD_MODEL_OBJECT_MAPPING, AD_PROCESS_PARA, AD_TEXTINTERFACES, AD_TREENODE, AD_MESSAGE, html, xml, java class, xsql file, unused java methods references could be removed safely. Removal of process access in sample data is manageable. Hence the risk of the API Change is very low.

Revision	2019-07-22 22:29 by AtulOpenbravo
Description	In a migrated instance or new instance when running below reports and process a warning is shown that "You can't use this report because your instance is migrated to new cost engine" so the below candidates are not used any more. -Create Production Costs -Generate Average Costs -Valued Stock Report Legacy -Sales Invoice Dimensional Report Legacy -Pareto Product Report Legacy -M_UPDATE_PARETO_PRODUCT_LEGACY Along with above candidates, their related DB functions, AD_MENU, AD_PROCESS, AD_MODEL_OBJECT, AD_MODEL_OBJECT_MAPPING, AD_PROCESS_PARA, AD_TEXTINTERFACES, AD_TREENODE html, xml, java class, xsql file, unused java methods references could be removed safely. Removal of process access in sample data is manageable. Hence the risk of the API Change is very low.

Revision	2019-07-22 20:46 by AtulOpenbravo
Description	In a migrated instance or new instance when running below reports and process a warning is shown that "instance has been migrated" so the below candidates are not used any more. -Create Production Costs -Generate Average Costs -Valued Stock Report Legacy -Sales Invoice Dimensional Report Legacy -Pareto Product Report Legacy -M_UPDATE_PARETO_PRODUCT_LEGACY Along with above candidates, their related DB functions, AD_MENU, AD_PROCESS, AD_MODEL_OBJECT, AD_MODEL_OBJECT_MAPPING, AD_PROCESS_PARA, AD_TEXTINTERFACES, AD_TREENODE html, xml, java class, xsql file, unused java methods references could be removed safely. Removal of process access in sample data is manageable. Hence the risk of the API Change is very low.