0041334: API Change:Delete obsolete db functions that have been deprecated

Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Revisions: Issue #41334		[ All Revisions ] [ Back to Issue ]
Summary	0041334: API Change:Delete obsolete db functions that have been deprecated

Revision	2019-07-23 19:17 by AtulOpenbravo
Description	Following deprecated db functions could be safely removed with minor refactor at the places where they are used. m_get_offer_price m_get_offer_std_price m_get_offers_price ** For removing this candidate below refactor could be safely implemented. - C_CREATE_PINVOICE_FROM_OUTS (used v_priceActual directly as it was returned by db functions) - C_GENERATEPOFROMPROJECT, C_GENERATESOFROMPROJECT, C_GENERATESOFROMPROJECTORDER, C_GENERATESOFROMPROJECTPHASE, C_PROJECT_GENERATE, MRP_PURCHASEORDER, M_COPY_PRODUCT_TEMPLATE, (used v_PriceStd directly returned as it was returned by db functions.) - M_EXPLODEBOMNOTSTOCK (used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_unit_price, v_price_actual and M_BOM_PriceList(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_price_list) - M_INOUT_CREATEINVOICE (used v_PriceActual for v_PriceActual, v_LineNetAmt as v_PriceActual is directly returned by the db function) - M_INVEXPLODEBOMNOTSTOCK (Used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID)) - M_REQUISITION_CREATEPO (used COALESCE(Cur_Lines.PRICEACTUAL, pp.PRICESTD)) - UpdatePricesAndAmounts.java (used M_BOM_PriceStd(:productID, plv.id)) - M_BOM_PRICESTD(CL.M_PRODUCT_ID, M_GET_PRICELIST_VERSION(?, TO_DATE(?))) - ExpenseSOrder_data.xsql (Uses directly priceactual in insertCOrderline method) - RequisitionToOrder_data.xsql (Uses directly priceactual in insertCOrderline method) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersPriceCurrency method) m_get_offers_std_price: To remove this candidate below refactor could be safely implemented - CopyFromInvoiceData.getOffersStdPrice (uses only two parameters: priceStd & invoiceid) - CopyFromOrderData.getOffersStdPrice (uses only two parameters: priceStd & orderid) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersStdPriceCurrency method)

Revision	2019-07-10 20:01 by AtulOpenbravo
Description	Following deprecated db functions could be safely removed with minor refactor at the places where they are used. m_get_offer_price m_get_offer_std_price m_get_offers_price ** For removing this candidate below refactor could be safely implemented. - C_CREATE_PINVOICE_FROM_OUTS (used v_priceActual directly as it was returned by db functions) - C_GENERATEPOFROMPROJECT, C_GENERATESOFROMPROJECT, C_GENERATESOFROMPROJECTORDER, C_GENERATESOFROMPROJECTPHASE, C_PROJECT_GENERATE, MRP_PURCHASEORDER, M_COPY_PRODUCT_TEMPLATE, (used v_PriceStd directly returned as it was returned by db functions.) - M_EXPLODEBOMNOTSTOCK (used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_unit_price, v_price_actual and M_BOM_PriceList(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_price_list) - M_INOUT_CREATEINVOICE (used v_PriceActual for v_PriceActual, v_LineNetAmt as v_PriceActual is directly returned by the db function) - M_INVEXPLODEBOMNOTSTOCK (Used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID)) - M_REQUISITION_CREATEPO (used COALESCE(Cur_Lines.PRICEACTUAL, pp.PRICESTD)) - UpdatePricesAndAmounts.java (used M_BOM_PriceStd(:productID, plv.id)) - M_BOM_PRICESTD(CL.M_PRODUCT_ID, M_GET_PRICELIST_VERSION(?, TO_DATE(?))) - ExpenseSOrder_data.xsql (Uses directly priceactual in insertCOrderline method) - RequisitionToOrder_data.xsql (Uses directly priceactual in insertCOrderline method) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersPriceCurrency method) m_get_offers_std_price: To remove this candidate below refactor could be safely implemented - CopyFromInvoiceData.getOffersStdPrice (uses only two parameters: priceStd & invoiceid) - CopyFromOrderData.getOffersStdPrice (uses only two parameters: priceStd & orderid) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersStdPriceCurrency method) m_warehouse_default_rule m_warehouse_default_rule_param M_WAREHOUSE_DEFAULT_RULE_PARAM & M_WAREHOUSE_DEFAULT_RULE references removed from standard and sample referenceData.

Revision	2019-07-10 19:56 by AtulOpenbravo
Description	Following deprecated db functions could be safely removed with minor refactor at the places where they are used. m_get_offer_price m_get_offer_std_price m_get_offers_price ** For removing this candidate below refactor could be safely implemented. - C_CREATE_PINVOICE_FROM_OUTS (used v_priceActual directly as it was returned by db functions) - C_GENERATEPOFROMPROJECT, C_GENERATESOFROMPROJECT, C_GENERATESOFROMPROJECTORDER, C_GENERATESOFROMPROJECTPHASE, C_PROJECT_GENERATE, MRP_PURCHASEORDER, M_COPY_PRODUCT_TEMPLATE, (used v_PriceStd directly as it was returned by db functions.) - M_EXPLODEBOMNOTSTOCK (used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_unit_price, v_price_actual and M_BOM_PriceList(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_price_list) - M_INOUT_CREATEINVOICE (used v_PriceActual for v_PriceActual, v_LineNetAmt as v_PriceActual is directly by the db function) - M_INVEXPLODEBOMNOTSTOCK (Used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID)) - M_REQUISITION_CREATEPO (used COALESCE(Cur_Lines.PRICEACTUAL, pp.PRICESTD)) - UpdatePricesAndAmounts.java (used M_BOM_PriceStd(:productID, plv.id)) - M_BOM_PRICESTD(CL.M_PRODUCT_ID, M_GET_PRICELIST_VERSION(?, TO_DATE(?))) - ExpenseSOrder_data.xsql (Uses directly priceactual) - RequisitionToOrder_data.xsql (Uses directly priceactual) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersPriceCurrency method) m_get_offers_std_price: To remove this candidate below refactor could be safely implemented - CopyFromInvoiceData.getOffersStdPrice (uses only two parameters: priceStd & invoiceid) - CopyFromOrderData.getOffersStdPrice (uses only two parameters: priceStd & orderid) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersStdPriceCurrency method) m_warehouse_default_rule m_warehouse_default_rule_param M_WAREHOUSE_DEFAULT_RULE_PARAM & M_WAREHOUSE_DEFAULT_RULE references removed from standard and sample referenceData.

Revision	2019-07-10 19:55 by AtulOpenbravo
Description	Following deprecated db functions could be safely removed with minor refactor at the places where they are used. m_get_offer_price m_get_offer_std_price m_get_offers_price ** For removing this candidate below refactor could be safely implemented. - C_CREATE_PINVOICE_FROM_OUTS (used v_priceActual directly as it was returned by db functions) - C_GENERATEPOFROMPROJECT, C_GENERATESOFROMPROJECT, C_GENERATESOFROMPROJECTORDER, C_GENERATESOFROMPROJECTPHASE, C_PROJECT_GENERATE, MRP_PURCHASEORDER, M_COPY_PRODUCT_TEMPLATE, (used v_PriceStd directly as it was returned by db functions.) - M_EXPLODEBOMNOTSTOCK (used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_unit_price, v_price_actual and M_BOM_PriceList(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_price_list) - M_INOUT_CREATEINVOICE (used v_PriceActual for v_PriceActual, v_LineNetAmt as v_PriceActual is directly by the db function) - M_INVEXPLODEBOMNOTSTOCK (Used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID)) - M_REQUISITION_CREATEPO (used COALESCE(Cur_Lines.PRICEACTUAL, pp.PRICESTD)) - UpdatePricesAndAmounts.java (used M_BOM_PriceStd(:productID, plv.id)) - M_BOM_PRICESTD(CL.M_PRODUCT_ID, M_GET_PRICELIST_VERSION(?, TO_DATE(?))) - ExpenseSOrder_data.xsql (Uses directly priceactual) - RequisitionToOrder_data.xsql (Uses directly priceactual) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersPriceCurrency method) m_get_offers_std_price: To remove this candidate below refactor could be safely implemented - CopyFromInvoiceData.getOffersStdPrice (uses only two parameters: priceStd & invoiceid) - CopyFromOrderData.getOffersStdPrice (uses only two parameters: priceStd & orderid) - GetPriceOffer_data.xsql (Uses directly priceStd in getOffersStdPriceCurrency method) m_warehouse_default_rule m_warehouse_default_rule_param GetPriceOfferData.getOffersPriceCurrency methods is to be changed as M_GET_OFFERS_PRICE is removed and the method return same values as sent parameter priceStd so the method has just two input parameter priceStd and currencyId. M_WAREHOUSE_DEFAULT_RULE_PARAM & M_WAREHOUSE_DEFAULT_RULE references removed from standard and sample referenceData.