Project:
| View Revisions: Issue #41109 | [ Back to Issue ] | ||
| Summary | 0041109: Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor | ||
| Revision | 2019-06-17 18:09 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. - Both component are not behaving in the same way: ImportEntryPreProcessor instances are executed for all type of data[4]. This is not the case of ImportEntryPostProcessor here[2]. As an additional comment, note that ImportEntryPostProcessor instances are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] [4] https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/service/importprocess/ImportEntryBuilder.java#l233 [^] |
||
| Revision | 2019-06-17 18:08 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. - ImportEntryPreProcessor instances are executed for all type of data[4]. This is not the case of ImportEntryPostProcessor here[2]. As an additional comment, note that ImportEntryPostProcessor instances are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] [4] https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/service/importprocess/ImportEntryBuilder.java#l233 [^] |
||
| Revision | 2019-06-17 18:04 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. As an additional comment, note that ImportEntryPostProcessor instances are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Revision | 2019-06-17 17:19 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. Also, note they are also being injected in an action handler used when importing data from the [Errors While Importing POS Data] window" module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Revision | 2019-06-17 17:18 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. Also, note they are also being used when importing data from the [Errors While Importing POS Data] window" module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Revision | 2019-06-17 17:12 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. Note they are also being used by an action handler in org.openbravo.retail.posterminal module[3]. [1] https://code.openbravo.com/erp/devel/pi/rev/302d949e828a772c0778017126f54b8563a9d6ec [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Revision | 2019-06-17 17:11 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor instances are not being injected in any component of the ImportEntryManager infrastructure (This was removed here[1]). Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [2]. Note they are also being used by an action handler in org.openbravo.retail.posterminal module[3]. [1] https://issues.openbravo.com/view.php?id=0036037 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Revision | 2019-06-17 17:10 by caristu | ||
| Description | There are some improvements related with ImportEntryPreProcessor and ImportEntryPostProcessor classes that can be applied: - ImportEntryPreProcessor should be defined as an interface instead of an abstract class. - ImportEntryPostProcessor should be defined as an interface instead of an abstract class. - Currently ImportEntryPostProcessor are not being injected in any component of the ImportEntryManager infrastructure. Instead, they are being injected in classes extending ImportEntryProcessRunnable. See [1]. Note they are also being used by an action handler in org.openbravo.retail.posterminal module[2]. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/MobileImportEntryProcessorRunnable.java#l38 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/SaveDataActionHandler.java#l53 [^] |
||
| Copyright © 2000 - 2009 MantisBT Group |
 |