Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0009653
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] F. Localizationminoralways2009-06-26 11:282009-08-20 00:00
ReporterpsarobeView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisiondc4ef5e3e537
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009653: Report Trial Balance is not translated correctly into spanish

DescriptionThe report still have some English words when you are login into Spanish.

See attach
Steps To Reproduce1. Login into Spanish
2. Go to Financial management->Accounting->Analysis tools-> Report trial balance

SEE ATTACH
Tags250MP2QAcylce
Attached Filespng file icon report_trial_balance.PNG [^] (115,725 bytes) 2009-06-26 11:28

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0009353 closedalostale With the application in spanish, terms of some reports are in English 
has duplicate defect 00105142.50MP4 closedrafaroda Report trial balance has hardcoded Spanish terms. 

-  Notes
(0017934)
vmromanos (manager)
2009-07-06 11:26

To be translated in the next version of the Spanish Translation Module (1.0.3):
- TRIAL BALANCE REPORT
- Organization:
- Accounting Schema
- ADD AND KEEP GOING.....

Strings already translated in the module, but not displayed by the application (see bug 0009353):
- From Account
- To Account

In the future, all the bugs in the Spanish translation module should be reported in the right forge's project, not here.
(0017960)
alostale (manager)
2009-07-07 12:04

It is not because of issue 0009353.

From and To accounts are hardcoded within org.openbravo.erpCommon.ad_reports.ReportTrialBalance class (line 398):

xmlDocument.setParameter("accounting", "From Account: "
          + ReportTrialBalanceData.selectAccountingName(this, strAccountFrom) + " - To Account: "
          + ReportTrialBalanceData.selectAccountingName(this, strAccountTo));
(0017965)
vmromanos (manager)
2009-07-07 13:04
edited on: 2009-07-07 13:04

alostale, you're right.
Before, this string was hardcoded in Spanish. In 0007774 it was changed to English, but still hardcoded so translation is not possible.

psarobe, what do you think if we remove these two strings "From Account" and "To Account" of the report?

(0018003)
rafaroda (developer)
2009-07-08 09:37

The solution is to set "From Account: " and "- To Account: " as it is done in From-To dates in, for instance, Orders Awaiting Invoice report.

ReportOrderNotInvoiceJR.java https://code.openbravo.com/erp/devel/pi/file/c60b37a5e784/src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceJR.java [^]

String strSubTitle = "";
strSubTitle = Utility.messageBD(this, "From", vars.getLanguage()) + " " + strdateFrom + " " + Utility.messageBD(this, "To", vars.getLanguage()) + " " + strdateTo;
(0018015)
vmromanos (manager)
2009-07-08 12:36

To sum up:
** Strings to be included in the new Spanish Translation Module:
- TRIAL BALANCE REPORT
- Organization:
- Accounting Schema
- ADD AND KEEP GOING.....
- From Account
- To Account

** Modifications required in the ReportTrialBalance class:
- Get "From Account" and "To account" from the AD_Message table
(0018016)
hgbot (developer)
2009-07-08 12:37

Repository: erp/devel/pi
Changeset: e8568557d20be9ceffcd8bd4a16f670f6c206a0e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 08 12:37:03 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e8568557d20be9ceffcd8bd4a16f670f6c206a0e [^]

Fixed bug 9653: Report Trial Balance is not translated correctly into Spanish

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
---
(0018467)
sureshbabu (reporter)
2009-07-21 11:04

ADD AND KEEP GOING..... text is not currently translated.
(0018553)
hgbot (developer)
2009-07-22 13:21

Repository: erp/devel/pi
Changeset: c4fd4ba4369ca4f504ab0720231137a0f3daa729
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 22 13:21:03 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c4fd4ba4369ca4f504ab0720231137a0f3daa729 [^]

fixed bug 0009653: Report Trial Balance is not translated correctly into spanish

---
M src-core/src/org/openbravo/xmlEngine/XmlTemplate.java
---
(0018562)
hgbot (developer)
2009-07-22 17:03

Repository: erp/devel/pi
Changeset: ec44e1737979f40d39017525ff11c632c6bf435a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 22 17:03:13 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ec44e1737979f40d39017525ff11c632c6bf435a [^]

issue 0009653: reverted previos fix since it brakes the compilation

---
M src-core/src/org/openbravo/xmlEngine/XmlTemplate.java
---
(0018563)
hgbot (developer)
2009-07-22 17:58

Repository: erp/devel/pi
Changeset: dc4ef5e3e5377e83788e8505823977133b7b0359
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 22 17:58:19 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dc4ef5e3e5377e83788e8505823977133b7b0359 [^]

fixed bug 0009653: Problems in some translations

---
M src-core/src/org/openbravo/xmlEngine/XmlTemplate.java
---
(0019034)
sureshbabu (reporter)
2009-08-19 08:45

As per the developers comments, the issue has been fixed.

- Issue History
Date Modified Username Field Change
2009-06-26 11:28 psarobe New Issue
2009-06-26 11:28 psarobe Assigned To => vmromanos
2009-06-26 11:28 psarobe File Added: report_trial_balance.PNG
2009-06-26 11:29 psarobe Relationship added related to 0009353
2009-06-26 11:29 psarobe Status new => scheduled
2009-06-26 11:29 psarobe fix_in_branch => pi
2009-06-26 11:29 psarobe Tag Attached: 250MP2QAcylce
2009-07-06 11:26 vmromanos Note Added: 0017934
2009-07-06 11:26 vmromanos Assigned To vmromanos => psarobe
2009-07-06 11:26 vmromanos Status scheduled => feedback
2009-07-07 12:04 alostale Note Added: 0017960
2009-07-07 13:04 vmromanos Note Added: 0017965
2009-07-07 13:04 vmromanos Note Edited: 0017965
2009-07-08 09:31 rafaroda Assigned To psarobe => vmromanos
2009-07-08 09:31 rafaroda Status feedback => scheduled
2009-07-08 09:31 rafaroda fix_in_branch pi =>
2009-07-08 09:37 rafaroda Note Added: 0018003
2009-07-08 12:36 vmromanos Note Added: 0018015
2009-07-08 12:37 hgbot Checkin
2009-07-08 12:37 hgbot Note Added: 0018016
2009-07-08 12:37 hgbot Status scheduled => resolved
2009-07-08 12:37 hgbot Resolution open => fixed
2009-07-08 12:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8568557d20be9ceffcd8bd4a16f670f6c206a0e [^]
2009-07-21 11:04 sureshbabu Status resolved => new
2009-07-21 11:04 sureshbabu Resolution fixed => open
2009-07-21 11:04 sureshbabu Note Added: 0018467
2009-07-21 11:10 vmromanos Assigned To vmromanos => alostale
2009-07-22 13:21 hgbot Checkin
2009-07-22 13:21 hgbot Note Added: 0018553
2009-07-22 13:21 hgbot Status new => resolved
2009-07-22 13:21 hgbot Resolution open => fixed
2009-07-22 13:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e8568557d20be9ceffcd8bd4a16f670f6c206a0e [^] => http://code.openbravo.com/erp/devel/pi/rev/c4fd4ba4369ca4f504ab0720231137a0f3daa729 [^]
2009-07-22 17:03 hgbot Checkin
2009-07-22 17:03 hgbot Note Added: 0018562
2009-07-22 17:03 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/c4fd4ba4369ca4f504ab0720231137a0f3daa729 [^] => http://code.openbravo.com/erp/devel/pi/rev/ec44e1737979f40d39017525ff11c632c6bf435a [^]
2009-07-22 17:58 hgbot Checkin
2009-07-22 17:58 hgbot Note Added: 0018563
2009-07-22 17:58 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/ec44e1737979f40d39017525ff11c632c6bf435a [^] => http://code.openbravo.com/erp/devel/pi/rev/dc4ef5e3e5377e83788e8505823977133b7b0359 [^]
2009-08-19 08:45 sureshbabu Status resolved => closed
2009-08-19 08:45 sureshbabu Note Added: 0019034
2009-08-19 08:45 sureshbabu Fixed in Version => pi
2009-08-20 00:00 anonymous sf_bug_id 0 => 2840620
2009-09-09 06:46 rafaroda Relationship added has duplicate 0010514


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker