Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0009230
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformmajorhave not tried2009-05-28 20:022009-07-16 17:55
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc979fa657fce
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009230: The publically usable sqlc-generated data classes should be defined and all non-public ones should not be accessible by modules

DescriptionTo be able to keep the public java API stable. The public parts needs to be defined.

This part is about the sqlc generated data classes (*Data.java). All classes which are not explicitly defined as public should be hidden so and not be usable by modules.
Proposed SolutionAudit all sqlc generated classes and decide which ones should be public and which not.

All the classes not defined to be public should not be public java classes and be changed to package level access.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0009317 closedshuehner The publically usable java classes should be defined and all non-public ones should not be accessible by modules 

-  Notes
(0016742)
hgbot (developer)
2009-05-28 20:09

 Repository: erp/devel/api-checks
Changeset: 6cb9d6dfb42fc8898c3dea5be4d3ba5b78472d7b
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu May 28 20:08:40 2009 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/6cb9d6dfb42fc8898c3dea5be4d3ba5b78472d7b [^]

Issue 9230: update java reference files to acknowledge all changes done to make public/private split for sqlc-generated data-classes

---
M java/reference/250.japi.gz
---
(0016743)
hgbot (developer)
2009-05-28 20:09

 Repository: erp/devel/pi
Changeset: c979fa657fce68e6c93c3cc4cd55ccc2dcb14ece
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu May 28 20:07:36 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c979fa657fce68e6c93c3cc4cd55ccc2dcb14ece [^]

Fixed 9230: Define the public sqlc-generated classes and hide all non-public classes from users outside of their package.
- Change SqlC to not make *Data classes public by default anymore. New accessModifier for classes is package-level
- Add optional attribute to SqlC to make individual classes public (accessModifier="public")
- Make a small number of sqlc-generated Data-classes public (mostly utility,businessUtility packages)
- refactor (move,split,copy) other xsql files to allow to make more xsql files non-public
- indirectly make most sqlc-generated files non-public (about 400)

---
M src-core/src/org/openbravo/data/Sqlc.java
M src-wad/src/org/openbravo/wad/ActionButton_data.xsqlxml
M src/org/openbravo/authentication/basic/AutologonAuthenticationManager.java
M src/org/openbravo/authentication/lam/LamAuthenticationManager.java
M src/org/openbravo/base/secureApp/ClassInfo_data.xsql
M src/org/openbravo/base/secureApp/DefaultOptions_data.xsql
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/base/secureApp/Seguridad_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/ActionButtonDefault_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.java
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder_data.xsql
M src/org/openbravo/erpCommon/ad_actionButton/InsertAcces.java
M src/org/openbravo/erpCommon/ad_actionButton/RequestAction.java
M src/org/openbravo/erpCommon/ad_actionButton/RequestAction_data.xsql
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner_data.xsql
M src/org/openbravo/erpCommon/ad_callouts/SE_Project_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Wh_SchedulePeriod.java
M src/org/openbravo/erpCommon/ad_callouts/SL_CreateFromMultiple_Warehouse.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
M src/org/openbravo/erpCommon/ad_combos/OrganizationCombo_data.xsql
M src/org/openbravo/erpCommon/ad_forms/CallAcctServer.java
M src/org/openbravo/erpCommon/ad_forms/CallAcctServer_data.xsql
M src/org/openbravo/erpCommon/ad_forms/Heartbeat.java
M src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java
M src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
M src/org/openbravo/erpCommon/ad_forms/Registration.java
M src/org/openbravo/erpCommon/ad_forms/RemittanceCancel.java
M src/org/openbravo/erpCommon/ad_forms/Role.java
M src/org/openbravo/erpCommon/ad_forms/Role_data.xsql
M src/org/openbravo/erpCommon/ad_forms/Translation.java
M src/org/openbravo/erpCommon/ad_process/AcctServerProcess_data.xsql
M src/org/openbravo/erpCommon/ad_process/CreateAccountingReport.java
M src/org/openbravo/erpCommon/ad_process/DeleteClient.java
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess_data.xsql
M src/org/openbravo/erpCommon/ad_process/ImportOrder.java
M src/org/openbravo/erpCommon/ad_process/ImportOrder_data.xsql
M src/org/openbravo/erpCommon/ad_process/SendMailText.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
M src/org/openbravo/erpCommon/ad_reports/ReportAnnualCertification.java
M src/org/openbravo/erpCommon/ad_reports/ReportBank.java
M src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportCashFlow.java
M src/org/openbravo/erpCommon/ad_reports/ReportCashflowForecast.java
M src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProductMovement.java
M src/org/openbravo/erpCommon/ad_reports/ReportStandardCostJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily.java
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDailyEnv.java
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementJR.java
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
M src/org/openbravo/erpCommon/businessUtility/PAttributeSet_data.xsql
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
M src/org/openbravo/erpCommon/businessUtility/TabAttachments_data.xsql
M src/org/openbravo/erpCommon/businessUtility/Tree_data.xsql
M src/org/openbravo/erpCommon/businessUtility/WindowTabs_data.xsql
M src/org/openbravo/erpCommon/info/Product.java
M src/org/openbravo/erpCommon/info/ProductComplete.java
M src/org/openbravo/erpCommon/modules/ModuleTree_data.xsql
M src/org/openbravo/erpCommon/reference/List_data.xsql
M src/org/openbravo/erpCommon/reference/PInstanceProcess_data.xsql
M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql
M src/org/openbravo/erpCommon/utility/DataGrid.java
M src/org/openbravo/erpCommon/utility/DateTime_data.xsql
M src/org/openbravo/erpCommon/utility/Menu_data.xsql
M src/org/openbravo/erpCommon/utility/PrintJR_data.xsql
M src/org/openbravo/erpCommon/utility/Tab_data.xsql
M src/org/openbravo/erpCommon/utility/Utility_data.xsql
M src/org/openbravo/erpCommon/utility/VerticalMenu.java
M src/org/openbravo/erpCommon/utility/WindowAccess_data.xsql
M src/org/openbravo/erpCommon/utility/WindowTree_data.xsql
M src/org/openbravo/erpCommon/utility/poc/Poc_Configuration_data.xsql
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
M src/org/openbravo/erpCommon/utility/reporting/Template_data.xsql
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
M src/org/openbravo/erpReports/ReportTaxPaymentJR.java
M src/org/openbravo/erpReports/ReportVatRegisterJR.java
M src/org/openbravo/scheduling/ProcessRequest_data.xsql
A src/org/openbravo/authentication/Authentication_data.xsql
A src/org/openbravo/base/secureApp/Preferences_data.xsql
A src/org/openbravo/erpCommon/ad_actionButton/ModuleCombo_data.xsql
A src/org/openbravo/erpCommon/ad_actionButton/TyperemittanceCombo_data.xsql
A src/org/openbravo/erpCommon/ad_callouts/InvoicingSchedule_data.xsql
A src/org/openbravo/erpCommon/ad_callouts/LocatorCombo_data.xsql
A src/org/openbravo/erpCommon/ad_forms/Client_data.xsql
A src/org/openbravo/erpCommon/ad_forms/Heartbeat_data.xsql
A src/org/openbravo/erpCommon/ad_forms/LanguageCombo_data.xsql
A src/org/openbravo/erpCommon/ad_forms/MonedaCombo_data.xsql
A src/org/openbravo/erpCommon/ad_forms/Organization_data.xsql
A src/org/openbravo/erpCommon/ad_forms/Register_data.xsql
A src/org/openbravo/erpCommon/ad_forms/RemittanceCombo_data.xsql
A src/org/openbravo/erpCommon/ad_forms/RoleCombo_data.xsql
A src/org/openbravo/erpCommon/ad_forms/Warehouse_data.xsql
A src/org/openbravo/erpCommon/ad_process/ClientCombo_data.xsql
A src/org/openbravo/erpCommon/ad_reports/AccountNumberCombo_data.xsql
A src/org/openbravo/erpCommon/ad_reports/AttributeSetInstanceCombo_data.xsql
A src/org/openbravo/erpCommon/ad_reports/Organization_data.xsql
A src/org/openbravo/erpCommon/ad_reports/ProcessPlanCombo_data.xsql
A src/org/openbravo/erpCommon/ad_reports/ProcessPlanVersionCombo_data.xsql
A src/org/openbravo/erpCommon/businessUtility/AccountingSchemaMisc_data.xsql
A src/org/openbravo/erpCommon/businessUtility/BpartnerMisc_data.xsql
A src/org/openbravo/erpCommon/businessUtility/DataTypeCombo_data.xsql
A src/org/openbravo/erpCommon/businessUtility/Email_data.xsql
A src/org/openbravo/erpCommon/businessUtility/Heartbeat_data.xsql
A src/org/openbravo/erpCommon/businessUtility/Registration_data.xsql
A src/org/openbravo/erpCommon/info/PriceListVersionCombo_data.xsql
A src/org/openbravo/erpCommon/info/WarehouseCombo_data.xsql
A src/org/openbravo/erpCommon/utility/Access_data.xsql
A src/org/openbravo/erpCommon/utility/reporting/printing/Email_data.xsql
A src/org/openbravo/erpCommon/utility/reporting/printing/Poc_data.xsql
A src/org/openbravo/erpCommon/utility/reporting/printing/Tools_data.xsql
R src/org/openbravo/erpCommon/ad_actionButton/InvoicingSchedule_data.xsql
R src/org/openbravo/erpCommon/ad_combos/AccountNumberCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/AttributeSetInstanceCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/ClientCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/DataTypeCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/LanguageCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/LocatorCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/ModuleCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/MonedaCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/PriceListVersionCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/ProcessPlanCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/ProcessPlanVersionCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/RemittanceCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/RoleCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/TyperemittanceCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/WarehouseCombo_data.xsql
R src/org/openbravo/erpCommon/ad_process/Register_data.xsql
R src/org/openbravo/erpCommon/info/Organization_data.xsql
R src/org/openbravo/erpCommon/reference/Preferences_data.xsql
R src/org/openbravo/erpCommon/security/Access_data.xsql
R src/org/openbravo/erpCommon/security/Client_data.xsql
R src/org/openbravo/erpCommon/security/Organization_data.xsql
R src/org/openbravo/erpCommon/security/Warehouse_data.xsql
R src/org/openbravo/erpCommon/utility/poc/Email_data.xsql
R src/org/openbravo/erpCommon/utility/poc/Poc_data.xsql
R src/org/openbravo/erpCommon/utility/reporting/Tools_data.xsql
---

- Issue History
Date Modified Username Field Change
2009-05-28 20:02 shuehner New Issue
2009-05-28 20:02 shuehner Assigned To => shuehner
2009-05-28 20:09 hgbot Checkin
2009-05-28 20:09 hgbot Note Added: 0016742
2009-05-28 20:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/6cb9d6dfb42fc8898c3dea5be4d3ba5b78472d7b [^]
2009-05-28 20:09 hgbot Checkin
2009-05-28 20:09 hgbot Note Added: 0016743
2009-05-28 20:09 hgbot Status new => resolved
2009-05-28 20:09 hgbot Resolution open => fixed
2009-05-28 20:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/api-checks/rev/6cb9d6dfb42fc8898c3dea5be4d3ba5b78472d7b [^] => http://code.openbravo.com/erp/devel/pi/rev/c979fa657fce68e6c93c3cc4cd55ccc2dcb14ece [^]
2009-06-03 20:52 shuehner Relationship added related to 0009317
2009-07-11 08:08 pjuvara Status resolved => closed
2009-07-16 17:55 anonymous sf_bug_id 0 => 2822552

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker