0009187: In the generate invoices window, review which sales orders should appear

Description

In the generate invoices window, review which sales orders should appear in the combobox

Steps To Reproduce

1) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Immediate". Create some lines but do NOT Complete it. Invoicerule = 'I'
2) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Customer Schedule After Delivery". Create some lines and Complete it. Invoicerule = 'S'
3) Create a Sales Order with Transaction Document = Standard Order and InvoiNe Terms = "Do not invoice". Create some lines and Complete it. Invoicerule = 'N'
4) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "After order delivered". Create some lines (more than one) and Complete it. Invoicerule = 'O'
5) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "After delivery". Create some lines (more than one) and Complete it. Invoicerule = 'D'
6) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Immediate". Create some lines and Complete it. Invoicerule = 'I'
7) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that ONLY Sale Order 6 appears in Sales Order drop-down.
8) Select it and click on OK: an invoice is created for Sale Order 6.
9) Go to "Sales Management || Transactions || Goods Shipment" and create a good shipment for the business partner of sales order 5.
10) Click on "Create Lines From" and select Sale Order 5.
11) Select ONLY one line of the sale order and click on OK.
12) Click on "Create Lines From" and select Sale Order 4.
13) Select ONLY one line of the sale order and click on OK.
14) Complete this good shipment.
15) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that ONLY Sales Order 5 appears in Sales Order drop-down.
16) Select it and click on OK: an invoice is created for lines of Sale Order 5 which has been previously delivered.
Click again on "Generate Invoices" process and check that no sales orders appear in the drop-down.
17) Go to "Sales Management || Transactions || Create Shipments from Orders", select Sales Orders 4 and 5 (some lines are pending to be delivered for both orders) and click on Process button: 2 goods shipments are created and completed.
18) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that Sales Order 4 and 5 appear in Sales Order drop-down.
19) Do not select any and click on OK: 2 invoices are created for Sale Order 4 and 5 respectively.

Proposed Solution

The functional requirements for orders to be displayed in Sales Order combo-box inside Generate Invoices process window are the following:
1) Orders have to be Sales Orders
2) Orders Document Status has to be in Completed or Closed.
3) Orders which ALL lines have already been invoiced have to be excluded.
4) Orders with Invoice Terms "Customer Schedule After Delivery" and "Do not invoice" have to be excluded: http://wiki.openbravo.com/wiki/Functional_Documentation/Sales_Management#Invoice_Terms [^]
5) Orders which Invoice Terms are "After order delivered" do not have to appear unless all their lines have been completely delivered.
6) Orders which Invoice Terms are "After delivery" do not have to appear unless any of their lines has been partially or totally delivered.
7) Orders which Invoice Terms are "Immediate" have to be displayed always.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0009104

closed

rafaroda

In the generate invoices window, review which sales orders should appear

Notes
(0016692) hgbot (developer) 2009-05-27 18:41	Repository: erp/stable/2.40 Changeset: 1d19b1d06f37ce9ff6931ecc9326c96a59b2f61d Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com> Date: Wed May 27 18:38:32 2009 +0200 URL: http://code.openbravo.com/erp/stable/2.40/rev/1d19b1d06f37ce9ff6931ecc9326c96a59b2f61d [^] Fixes issue 0009187 Changed \"C_Order SO to be invoiced\" and \"C_BPartner w SO to invoice\" validation rules to properly display sales orders and business partners to be shown in \"Generate Invoices\" process. --- M src-db/database/sourcedata/AD_VAL_RULE.xml ---

(0016700) hgbot (developer) 2009-05-28 09:42	Repository: erp/stable/2.40 Changeset: 4f0d55022e298f5c58bc8fcb39b9ec9c900fdd24 Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com> Date: Thu May 28 09:41:35 2009 +0200 URL: http://code.openbravo.com/erp/stable/2.40/rev/4f0d55022e298f5c58bc8fcb39b9ec9c900fdd24 [^] Fixes issue 0009187 Corrected criteria for \"After delivery\" invoice term, --- M src-db/database/sourcedata/AD_VAL_RULE.xml ---

(0016768) sureshbabu (reporter) 2009-05-29 15:45	Tested working fine

Issue History
Date Modified	Username	Field	Change
2009-05-26 16:49	rafaroda	Type	defect => backport
2009-05-26 16:49	rafaroda	fix_in_branch	=> 2.40
2009-05-27 10:39	rafaroda	Proposed Solution updated
2009-05-27 18:41	hgbot	Checkin
2009-05-27 18:41	hgbot	Note Added: 0016692
2009-05-27 18:41	hgbot	Status	scheduled => resolved
2009-05-27 18:41	hgbot	Resolution	open => fixed
2009-05-27 18:41	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/stable/2.40/rev/1d19b1d06f37ce9ff6931ecc9326c96a59b2f61d [^]
2009-05-28 09:42	hgbot	Checkin
2009-05-28 09:42	hgbot	Note Added: 0016700
2009-05-28 09:42	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/stable/2.40/rev/1d19b1d06f37ce9ff6931ecc9326c96a59b2f61d [^] => http://code.openbravo.com/erp/stable/2.40/rev/4f0d55022e298f5c58bc8fcb39b9ec9c900fdd24 [^]
2009-05-28 17:57	psarobe	Fixed in Version	=> 2.40MP5
2009-05-29 15:45	sureshbabu	Status	resolved => closed
2009-05-29 15:45	sureshbabu	Note Added: 0016768