0008312: Exception reporting for navigation in generated windows uses DEBUG instead of error

Description

Meaning that the java exception (error messages) are only visible if you enable DEBUG logging which is normally disabled.

In addition the stacktrace (for finding the error) and the error message go into different logfiles which makes finding the error much harder.

Proposed Solution

- change error-message to use type error instead of debug
- log the stacktrace together with the error message.

Tags

No tags attached.

Attached Files

navigation_logging.diff [^] (2,602 bytes) 2009-03-26 16:32 [Show Content] [Hide Content]

diff --git a/src-wad/src/org/openbravo/wad/javasource.javaxml b/src-wad/src/org/openbravo/wad/javasource.javaxml
--- a/src-wad/src/org/openbravo/wad/javasource.javaxml
+++ b/src-wad/src/org/openbravo/wad/javasource.javaxml
@@ -666,8 +666,7 @@
         ExecuteQuery execquery = new ExecuteQuery(this, strSQL, tableSQL.getParameterValuesOnlyId());
         data = execquery.selectAndSearch(ExecuteQuery.SearchType.NEXT, strSelected, tableSQL.getKeyColumn());
       } catch (Exception e) { 
-        if (log4j.isDebugEnabled()) log4j.debug("Error getting next element");
-        e.printStackTrace();
+        log4j.error("Error getting next element", e);
       }
       if (data!=null) {
         if (data!=null) return data;
@@ -685,8 +684,7 @@
         ExecuteQuery execquery = new ExecuteQuery(this, strSQL, tableSQL.getParameterValuesOnlyId());
         data = execquery.selectAndSearch(ExecuteQuery.SearchType.GETPOSITION, strSelected, tableSQL.getKeyColumn());
       } catch (Exception e) { 
-        if (log4j.isDebugEnabled()) log4j.debug("Error getting key position");
-        e.printStackTrace();
+        log4j.error("Error getting key position", e);
       }
       if (data!=null) {
         if (data!=null) return Integer.valueOf(data);
@@ -704,8 +702,7 @@
         ExecuteQuery execquery = new ExecuteQuery(this, strSQL, tableSQL.getParameterValuesOnlyId());
         data = execquery.selectAndSearch(ExecuteQuery.SearchType.PREVIOUS, strSelected, tableSQL.getKeyColumn());
       } catch (Exception e) { 
-        if (log4j.isDebugEnabled()) log4j.debug("Error getting previous element");
-        e.printStackTrace();
+        log4j.error("Error getting previous element", e);
       }
       if (data!=null) {
         return data;
@@ -723,8 +720,7 @@
         data = execquery.selectAndSearch(ExecuteQuery.SearchType.FIRST, "", tableSQL.getKeyColumn());
 
       } catch (Exception e) { 
-        if (log4j.isDebugEnabled()) log4j.debug("Error getting first element");
-        e.printStackTrace();
+        log4j.error("Error getting first element", e);
       }
       if (data!=null) return data;
     }
@@ -739,8 +735,7 @@
         ExecuteQuery execquery = new ExecuteQuery(this, strSQL, tableSQL.getParameterValuesOnlyId());
         data = execquery.selectAndSearch(ExecuteQuery.SearchType.LAST, "", tableSQL.getKeyColumn());
       } catch (Exception e) { 
-        if (log4j.isDebugEnabled()) log4j.debug("Error getting last element");
-        e.printStackTrace();
+        log4j.error("Error getting last element", e);
       }
       if (data!=null) return data;
     }

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0008316

closed

shuehner

Exception reporting for navigation in generated windows uses DEBUG instead of error

Notes
(0015015) shuehner (administrator) 2009-03-26 16:32	attached patch to show proposed solution.

(0015019) hgbot (developer) 2009-03-26 18:11	Repository: erp/devel/pi Changeset: 306e035f42982d75c4b4d250b0fdbab771fc4c01 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Mar 26 18:11:02 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/306e035f42982d75c4b4d250b0fdbab771fc4c01 [^] Fixed 8312: Use log-level error instead of debug for logging exceptions --- M src-wad/src/org/openbravo/wad/javasource.javaxml ---

Issue History
Date Modified	Username	Field	Change
2009-03-26 16:32	shuehner	New Issue
2009-03-26 16:32	shuehner	Assigned To	=> shuehner
2009-03-26 16:32	shuehner	OBNetwork customer	=> No
2009-03-26 16:32	shuehner	Regression testing	=> No
2009-03-26 16:32	shuehner	File Added: navigation_logging.diff
2009-03-26 16:32	shuehner	Note Added: 0015015
2009-03-26 16:51	shuehner	Status	new => scheduled
2009-03-26 16:51	shuehner	fix_in_branch	=> pi
2009-03-26 18:11	hgbot	Checkin
2009-03-26 18:11	hgbot	Note Added: 0015019
2009-03-26 18:11	hgbot	Status	scheduled => resolved
2009-03-26 18:11	hgbot	Resolution	open => fixed
2009-03-26 18:11	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/306e035f42982d75c4b4d250b0fdbab771fc4c01 [^]
2009-04-21 10:53	psarobe	Status	resolved => closed
2009-04-22 00:01	anonymous	sf_bug_id	0 => 2778094