Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0007130 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] 02. Master data management | minor | always | 2009-01-26 12:30 | 2011-05-25 17:00 | |||
| Reporter | villind | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 5240baa48ad6 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0007130: Invalid substr index in SQL query in used parse-method of FileImport_data.xsql | |||||||
| Description | File src/org/openbravo/erpCommon/ad_forms/FileImport_data.xsql contains SQL SUBSTR index 0. | |||||||
| Proposed Solution | Change the start position to 1 (first character). This works both Oracle and postgresql. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Issue-7130.diff [^] (658 bytes) 2009-01-26 12:33 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0012908) rafaroda (developer) 2009-01-30 14:55 |
Hi Ville, Thanks for the patch. But could you please write down the steps to make this fail within Openbravo ERP. Thank you. |
|
(0012912) villind (developer) 2009-01-30 15:28 |
Try using this functionality with Postgresql. The SQL specification says that the substr position parameter specification is not zero based. Oracle treats 0 and 1 the same, but Postgresql is more strict with this. |
|
(0012920) shuehner (administrator) 2009-01-30 16:17 |
I tried to find a user for the parse-method in which this sql statement is in and could not find a single in-tree user? Do you use this method in a custom modification or did i overlook a in-tree user? |
|
(0013016) shuehner (administrator) 2009-02-02 14:31 |
I did create and link issue 7315 to fix all of the invalid substr instances in the codebase. I would like to retitle this issue to feature request to remove the unused parse function. |
|
(0013019) villind (developer) 2009-02-02 15:15 |
We are not using this method. |
|
(0013020) shuehner (administrator) 2009-02-02 15:19 |
Changing to feature request to check if that method can be removed completely, as it is not used anywhere. |
|
(0036312) shuehner (administrator) 2011-05-03 13:53 |
The functionality related to that file has been removed from core and put into the module containing the old deprecated content (for 3.0). As the broken function was not even used before and now is moved out of core no need to fix the function -> Closing as resolved (with issue moving the code out of core). |
|
(0037438) shuehner (administrator) 2011-05-25 17:00 |
The cleanup commit below removes the wrong methods completely from the module as it wasn't used at all. https://code.openbravo.com/erp/mods/org.openbravo.importdata/rev/ac752dcd8f55 [^] |
|
(0037439) shuehner (administrator) 2011-05-25 17:00 |
Marking as closed. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-01-26 12:30 | villind | New Issue | |
| 2009-01-26 12:30 | villind | Assigned To | => rafaroda |
| 2009-01-26 12:30 | villind | sf_bug_id | 0 => 2537443 |
| 2009-01-26 12:30 | villind | Regression testing | => No |
| 2009-01-26 12:33 | villind | File Added: Issue-7130.diff | |
| 2009-01-30 14:55 | rafaroda | Note Added: 0012908 | |
| 2009-01-30 14:55 | rafaroda | Status | new => feedback |
| 2009-01-30 15:28 | villind | Note Added: 0012912 | |
| 2009-01-30 16:16 | shuehner | Assigned To | rafaroda => shuehner |
| 2009-01-30 16:17 | shuehner | Note Added: 0012920 | |
| 2009-01-30 16:48 | villind | Relationship added | depends on 0007069 |
| 2009-01-30 16:49 | villind | Relationship deleted | depends on 0007069 |
| 2009-01-30 16:49 | villind | Relationship added | related to 0007069 |
| 2009-01-30 17:18 | villind | Relationship deleted | related to 0007069 |
| 2009-01-30 17:18 | villind | Relationship added | related to 0007129 |
| 2009-02-02 14:28 | shuehner | Relationship added | related to 0007315 |
| 2009-02-02 14:31 | shuehner | Note Added: 0013016 | |
| 2009-02-02 15:15 | villind | Note Added: 0013019 | |
| 2009-02-02 15:19 | shuehner | Note Added: 0013020 | |
| 2009-02-02 15:19 | shuehner | Severity | major => minor |
| 2009-02-02 15:19 | shuehner | Status | feedback => new |
| 2009-02-02 15:19 | shuehner | Type | defect => feature request |
| 2009-02-02 15:19 | shuehner | version | 2.40MP1 => trunk |
| 2009-02-02 15:19 | shuehner | Summary | Invalid substr index in SQL query => Invalid substr index in SQL query in used parse-method of FileImport_data.xsql |
| 2009-02-02 15:19 | shuehner | Relationship added | blocks 0007236 |
| 2011-05-03 13:52 | shuehner | Status | new => scheduled |
| 2011-05-03 13:52 | shuehner | fix_in_branch | => pi |
| 2011-05-03 13:53 | shuehner | Note Added: 0036312 | |
| 2011-05-03 13:53 | shuehner | Status | scheduled => resolved |
| 2011-05-03 13:53 | shuehner | Fixed in SCM revision | => https://code.openbravo.com/erp/devel/pi/rev/5240baa48ad6 [^] |
| 2011-05-03 13:53 | shuehner | Resolution | open => fixed |
| 2011-05-25 17:00 | shuehner | Note Added: 0037438 | |
| 2011-05-25 17:00 | shuehner | Note Added: 0037439 | |
| 2011-05-25 17:00 | shuehner | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |