Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0006553 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | N/A | 2008-12-15 15:09 | 2009-05-28 10:40 | |||
| Reporter | rafaroda | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 2.40MP5 | |||
| Status | closed | Fix in branch | 2.40 | Fixed in SCM revision | 646b9636ad7b | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0006553: Logging of this exception in HttpSecureAppServlet is done very badly | |||||||
| Description | This issue is a spin-off of issue 6131 (part 4.): Logging of Exception as (at least) the indicated source-code position has to be improved, as with the current code it is very hard to get all needed information. 4.) Logging of this exception is done very badly It is catched in HttpSecureAppServlet.java (line 262) Only the exception name is logged to log4j4j, not stacktrace the Stacktrace is printed on std-out Outcome: Info for this exception is spread over 2 log-files - openbravo.log for seeing "Error captured: NPE" - catalina.out (capturing std-out) for seeing the stacktrace without any timestamp and context information. | |||||||
| Proposed Solution | change the logging from log4j.error("text..." + e.getMessage()) e.printStackTrace() to log4j.error("text...", e) remove the printStackTrace line verify that the exception (text + stacktrace) is correctly logged into the log4j logfile | |||||||
| Tags | comsup_sprint5 | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0012687) svnbot (reporter) 2009-01-27 14:31 |
Repository: openbravo Revision: 12318 Author: gmauleon Date: 2009-01-27 14:31:31 +0100 (Tue, 27 Jan 2009) fixes 0006553: Logging of this exception in HttpSecureAppServlet is done very badly --- U branches/r2.40/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java --- https://dev.openbravo.com/websvn/openbravo/?rev=12318&sc=1 [^] |
|
(0015795) shuehner (administrator) 2009-04-27 15:38 |
reopen, as related defect is reopened. |
|
(0016524) shuehner (administrator) 2009-05-20 15:14 |
Issue pending, waiting for 2.40 branch to reopen. |
|
(0016564) hgbot (developer) 2009-05-21 18:33 |
Repository: erp/stable/2.40 Changeset: 646b9636ad7bb77a82450d94712522033413675f Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Wed May 13 11:00:43 2009 +0200 URL: http://code.openbravo.com/erp/stable/2.40/rev/646b9636ad7bb77a82450d94712522033413675f [^] Fixed 6553: improve logging of exceptions (include stacktraces) --- M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2008-12-15 15:09 | rafaroda | New Issue | |
| 2008-12-15 15:09 | rafaroda | Assigned To | => gmauleon |
| 2008-12-15 15:09 | rafaroda | Regression testing | => No |
| 2008-12-15 15:09 | rafaroda | Issue generated from | 0006182 |
| 2008-12-15 15:09 | rafaroda | Relationship added | blocks 0006182 |
| 2008-12-15 15:10 | rafaroda | Status | new => scheduled |
| 2008-12-15 15:10 | rafaroda | fix_in_branch | => 2.40 |
| 2009-01-15 17:06 | svnbot | Checkin | |
| 2009-01-15 17:06 | svnbot | Note Added: 0012230 | |
| 2009-01-15 17:06 | svnbot | Status | scheduled => resolved |
| 2009-01-15 17:06 | svnbot | Resolution | open => fixed |
| 2009-01-15 17:06 | svnbot | svn_revision | => 11949 |
| 2009-01-15 17:26 | gmauleon | Status | resolved => new |
| 2009-01-15 17:26 | gmauleon | Resolution | fixed => open |
| 2009-01-15 17:26 | gmauleon | Note Added: 0012232 | |
| 2009-01-15 17:26 | gmauleon | Status | new => scheduled |
| 2009-01-15 17:26 | gmauleon | fix_in_branch | 2.40 => trunk |
| 2009-01-15 17:28 | gmauleon | Note Deleted: 0012230 | |
| 2009-01-15 17:28 | gmauleon | Note Deleted: 0012232 | |
| 2009-01-15 17:29 | gmauleon | svn_revision | 11949 => |
| 2009-01-15 17:29 | gmauleon | fix_in_branch | trunk => 2.40 |
| 2009-01-27 14:31 | svnbot | Checkin | |
| 2009-01-27 14:31 | svnbot | Note Added: 0012687 | |
| 2009-01-27 14:31 | svnbot | Status | scheduled => resolved |
| 2009-01-27 14:31 | svnbot | Resolution | open => fixed |
| 2009-01-27 14:31 | svnbot | svn_revision | => 12318 |
| 2009-01-28 12:10 | gmauleon | Tag Attached: comsup_sprint5 | |
| 2009-03-03 17:32 | psarobe | Fixed in Version | => 2.40MP3 |
| 2009-03-04 17:29 | psarobe | Status | resolved => closed |
| 2009-04-27 15:38 | shuehner | Status | closed => new |
| 2009-04-27 15:38 | shuehner | Resolution | fixed => open |
| 2009-04-27 15:38 | shuehner | Note Added: 0015795 | |
| 2009-04-27 15:38 | shuehner | Fixed in Version | 2.40MP3 => |
| 2009-04-28 13:43 | shuehner | Assigned To | gmauleon => shuehner |
| 2009-05-20 15:14 | shuehner | Note Added: 0016524 | |
| 2009-05-21 18:33 | hgbot | Checkin | |
| 2009-05-21 18:33 | hgbot | Note Added: 0016564 | |
| 2009-05-21 18:33 | hgbot | Status | new => resolved |
| 2009-05-21 18:33 | hgbot | Resolution | open => fixed |
| 2009-05-21 18:33 | hgbot | Fixed in SCM revision | 12318 => http://code.openbravo.com/erp/stable/2.40/rev/646b9636ad7bb77a82450d94712522033413675f [^] |
| 2009-05-28 10:40 | psarobe | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |