Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0058106
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2025-02-27 18:112025-03-18 10:28
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR25Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0058106: Messaging API(websockets) has some issues regarding concurrency and CDI

DescriptionThere are several problems related with the messaging API which should be fixed.

Primarly the main one is usage of Singleton and CDI injection in MessageClientRegistry which is not correct, it should be changed as it is not thread-safe. Also some hashmaps are used instead of their concurrent versions, possibly creating difficult to find bugs.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0056195 closedcberner New infrastructure for sending messages, using websockets 
causes defect 0058266 closedalostale [API Change] Renamed and restructured WebSockets/Messaging API 

-  Notes
(0176659)
hgbot (developer)
2025-03-11 11:27

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1580 [^]
(0176664)
hgbot (developer)
2025-03-11 13:04

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/demo/org.openbravo.demo.messaging/-/merge_requests/1 [^]
(0176921)
hgbot (developer)
2025-03-18 09:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo [^]
Changeset: 3ca1c9a5963a69778e31e4b905e0ae4b03ede58c
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 18-03-2025 09:46:04
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/3ca1c9a5963a69778e31e4b905e0ae4b03ede58c [^]

Fixes ISSUE-58106: Messaging API(websockets) has some issues regarding concurrency and CDI

Includes several changes to the Messaging API, including its renaming
and proper CDI support.

---
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/DatabaseMessageRegistryPersistence.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageBroadcaster.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageConnectionHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageEndpoint.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageEndpointRegistry.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageEnvelope.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageRegistry.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageRegistryPersistence.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageSystemContextListener.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageSystemManager.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageSystemManagerEnabledPreferenceChangeEventHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/MessageSystemUtils.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/WebSocketConfigurator.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/WebSocketConnectionHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/messagesystem/WebSocketEndpoint.java
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
R modules/org.openbravo.client.application/src/org/openbravo/client/application/messageclient/MessageClientRegistry.java
---
(0176922)
hgbot (developer)
2025-03-18 09:46

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1580 [^]
(0176926)
hgbot (developer)
2025-03-18 09:52

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/demo/org.openbravo.demo.messaging [^]
Changeset: f143474402f2874a390523501dce8df44f05b7ae
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 11-03-2025 11:31:07
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/demo/org.openbravo.demo.messaging/-/commit/f143474402f2874a390523501dce8df44f05b7ae [^]

Related to ISSUE-58106: Messaging API related changes

---
M src/org/openbravo/demo/messaging/ExampleNotificationMessageHandler.java
M src/org/openbravo/demo/messaging/GenerateMessage.java
M src/org/openbravo/demo/messaging/GetAvailableMessageTopics.java
---
(0176927)
hgbot (developer)
2025-03-18 09:52

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/demo/org.openbravo.demo.messaging/-/merge_requests/1 [^]
(0176933)
hgbot (developer)
2025-03-18 10:28

Merge request closed: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.service.messagequeue.amqp/-/merge_requests/2 [^]

- Issue History
Date Modified Username Field Change
2025-02-27 18:11 cberner New Issue
2025-02-27 18:11 cberner Assigned To => cberner
2025-02-27 18:11 cberner OBNetwork customer => No
2025-02-27 18:11 cberner Modules => Core
2025-02-27 18:11 cberner Triggers an Emergency Pack => No
2025-02-28 09:03 cberner Relationship added related to 0056195
2025-03-11 11:27 hgbot Merge Request Status => open
2025-03-11 11:27 hgbot Note Added: 0176659
2025-03-11 13:04 hgbot Note Added: 0176664
2025-03-11 13:26 cberner Status new => scheduled
2025-03-17 13:45 hgbot Merge Request Status open => approved
2025-03-18 09:07 cberner Relationship added causes 0058266
2025-03-18 09:46 hgbot Resolution open => fixed
2025-03-18 09:46 hgbot Status scheduled => closed
2025-03-18 09:46 hgbot Fixed in Version => PR25Q2
2025-03-18 09:46 hgbot Note Added: 0176921
2025-03-18 09:46 hgbot Note Added: 0176922
2025-03-18 09:52 hgbot Note Added: 0176926
2025-03-18 09:52 hgbot Note Added: 0176927
2025-03-18 10:28 hgbot Note Added: 0176933


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker