Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0057822
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2025-01-31 13:062025-02-19 17:06
Reporterander_floresView Statuspublic 
Assigned Toander_flores 
PrioritynormalResolutionfixedFixed in Version25Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057822: Move duplicate component MessageIcon.jsx to core2

DescriptionA component called MessageIcon.jsx is duplicated in these two modules:
 - org.openbravo.events.client
 - org.openbravo.pos2

These two components share almost exactly the same code.
In order to avoid code duplication, the MessageIcon.jsx component should only be defined in the org.openbravo.core2 module
Steps To ReproduceMove the MessageIcon.jsx component to core2 and replace all the references to the other two components
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0175091)
hgbot (developer)
2025-02-04 10:15

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1752 [^]
(0175092)
hgbot (developer)
2025-02-04 10:15

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/103 [^]
(0175093)
hgbot (developer)
2025-02-04 10:15

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3454 [^]
(0175094)
hgbot (developer)
2025-02-04 10:15

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/151 [^]
(0175095)
hgbot (developer)
2025-02-04 10:15

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/43 [^]
(0175643)
hgbot (developer)
2025-02-14 10:54

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.webpayment/-/merge_requests/6 [^]
(0175644)
hgbot (developer)
2025-02-14 10:54

Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/144 [^]
(0175904)
hgbot (developer)
2025-02-19 17:01

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1752 [^]
(0175905)
hgbot (developer)
2025-02-19 17:01

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 9e62ec20dd52f2217ff86fffe8378c9275e85944
Author: Ander Flores <a.flores@orisha.com>
Date: 19-02-2025 16:01:34
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/9e62ec20dd52f2217ff86fffe8378c9275e85944 [^]

Fixed ISSUE-57822: Move duplicate MessagesIcon component from pos2 and events.client to core2

---
A web-jspack/org.openbravo.core2/src/components/MessagesIcon/MessagesIcon.jsx
A web-jspack/org.openbravo.core2/src/components/MessagesIcon/MessagesIcon.scss
A web-jspack/org.openbravo.core2/src/components/MessagesIcon/index.js
---
(0175906)
hgbot (developer)
2025-02-19 17:02

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: 5f1f31884ea05610f5b8e6a40b42fc9b7a1280e2
Author: Ander Flores <a.flores@orisha.com>
Date: 19-02-2025 16:02:28
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/commit/5f1f31884ea05610f5b8e6a40b42fc9b7a1280e2 [^]

Related to ISSUE-57822: Move MessagesIcon component to core2

---
M web-jspack/org.openbravo.events.client/src/components/EventsLoginDialog/EventsLoginDialog.jsx
M web-jspack/org.openbravo.events.client/src/components/MainMessagesManagerContentPOS.jsx
M web-jspack/org.openbravo.events.client/src/components/MessagesManager.scss
R web-jspack/org.openbravo.events.client/src/components/MessagesIcon.jsx
---
(0175907)
hgbot (developer)
2025-02-19 17:02

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/103 [^]
(0175908)
hgbot (developer)
2025-02-19 17:02

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3454 [^]
(0175909)
hgbot (developer)
2025-02-19 17:03

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3cdd0533ba316245a3dfe93cef94b6a2a4a6e384
Author: Ander Flores <a.flores@orisha.com>
Date: 19-02-2025 16:02:56
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/3cdd0533ba316245a3dfe93cef94b6a2a4a6e384 [^]

Related to ISSUE-57822: Move MessagesIcon component to core2

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/AdditionalInfoDialog.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/ConfirmProcessProvider.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/ConfirmProcessProviderPOS.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/DefaultProcessProvider.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/MockProvider.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/__test__/MockPaymentProvider.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/stories/AdditionalInfoDialog.stories.jsx
R web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/MessagesIcon.jsx
---
(0175910)
hgbot (developer)
2025-02-19 17:03

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/43 [^]
(0175911)
hgbot (developer)
2025-02-19 17:03

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider [^]
Changeset: ca369809c4ade89e97d2b2a0df4ced4c382fd841
Author: Ander Flores <a.flores@orisha.com>
Date: 19-02-2025 16:03:32
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/commit/ca369809c4ade89e97d2b2a0df4ced4c382fd841 [^]

Related to ISSUE-57822: Replace the import path of the MessagesIcon component

---
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/RequestConfirmation.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/RequestMenuEntry.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/RequestPassword.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/RequestText.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/test/MessagesRender.test.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/test/RequestMenuEntry.test.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/test/RequestPassword.test.jsx
M web-jspack/org.openbravo.retail.asyncpayprovider/src/components/PaymentIntegration/test/RequestText.test.jsx
---
(0175912)
hgbot (developer)
2025-02-19 17:03

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.webpayment [^]
Changeset: 34f745b4cfb69e34b566c879e86217588144fb28
Author: Ander Flores <a.flores@orisha.com>
Date: 14-02-2025 10:51:05
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.webpayment/-/commit/34f745b4cfb69e34b566c879e86217588144fb28 [^]

Related to ISSUE-57822: Rename MessageIcon css classname

---
M web-jspack/org.openbravo.retail.webpayment/src/components/PaymentIntegration/WebPaymentProvider.js
M web-jspack/org.openbravo.retail.webpayment/src/components/PaymentIntegration/__test__/WebPaymentProvider.test.js
---
(0175913)
hgbot (developer)
2025-02-19 17:03

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.webpayment/-/merge_requests/6 [^]
(0175914)
hgbot (developer)
2025-02-19 17:04

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/144 [^]
(0175915)
hgbot (developer)
2025-02-19 17:04

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^]
Changeset: 2e6b20ea3010de84371378e978ff153255ac3d0d
Author: Ander Flores <a.flores@orisha.com>
Date: 14-02-2025 14:28:01
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/2e6b20ea3010de84371378e978ff153255ac3d0d [^]

Related to ISSUE-57822: Rename MessageIcon css classname

---
M project/src/com/openbravo/eventspayment/PaymentDev.java
---
(0175916)
hgbot (developer)
2025-02-19 17:04

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2.selfcheckout [^]
Changeset: cc9edf631f7a11615d14483673cec58a20354260
Author: Ander Flores <a.flores@orisha.com>
Date: 19-02-2025 16:04:31
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/commit/cc9edf631f7a11615d14483673cec58a20354260 [^]

Related to ISSUE-57822: Replace the import path of the MessagesIcon component

---
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/BooleanSelectionForm/BooleanSelectionForm.jsx
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/BooleanSelectionForm/BooleanSelectionForm.scss
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/ConfirmProcessProvider/ConfirmProcessProviderSCO.scss
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/ConfirmProcessProvider/stories/ConfirmProcessProviderSCO.stories.scss
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/ConfirmSuccessfulPayment/ConfirmSuccessfulPayment.jsx
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/MainMessagesManagerContainerSCO/MainMessagesManagerContainerSCO.scss
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/MainMessagesManagerContentSCO/MainMessagesManagerContentSCO.jsx
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/MessagesContainer/MessagesContainer.scss
---
(0175917)
hgbot (developer)
2025-02-19 17:04

Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/151 [^]
(0175918)
hgbot (developer)
2025-02-19 17:06

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^]
Changeset: 8669f52276c1ac332e940619f80f46ba6995667c
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 19-02-2025 17:06:36
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/8669f52276c1ac332e940619f80f46ba6995667c [^]

Related to ISSUE-57822: Rename MessageIcon css classname

---
M bin/poshw.jar
M bin/rev.id
---

- Issue History
Date Modified Username Field Change
2025-01-31 13:06 ander_flores New Issue
2025-01-31 13:06 ander_flores Assigned To => Triage Platform Base
2025-01-31 13:06 ander_flores Triggers an Emergency Pack => No
2025-02-04 10:15 hgbot Note Added: 0175091
2025-02-04 10:15 hgbot Note Added: 0175092
2025-02-04 10:15 hgbot Note Added: 0175093
2025-02-04 10:15 hgbot Note Added: 0175094
2025-02-04 10:15 hgbot Note Added: 0175095
2025-02-04 10:19 ander_flores Assigned To Triage Platform Base => ander_flores
2025-02-14 10:54 hgbot Note Added: 0175643
2025-02-14 10:54 hgbot Note Added: 0175644
2025-02-19 17:01 hgbot Note Added: 0175904
2025-02-19 17:01 hgbot Resolution open => fixed
2025-02-19 17:01 hgbot Status new => closed
2025-02-19 17:01 hgbot Fixed in Version => 25Q2
2025-02-19 17:01 hgbot Note Added: 0175905
2025-02-19 17:02 hgbot Note Added: 0175906
2025-02-19 17:02 hgbot Note Added: 0175907
2025-02-19 17:02 hgbot Note Added: 0175908
2025-02-19 17:03 hgbot Note Added: 0175909
2025-02-19 17:03 hgbot Note Added: 0175910
2025-02-19 17:03 hgbot Note Added: 0175911
2025-02-19 17:03 hgbot Note Added: 0175912
2025-02-19 17:03 hgbot Note Added: 0175913
2025-02-19 17:04 hgbot Note Added: 0175914
2025-02-19 17:04 hgbot Note Added: 0175915
2025-02-19 17:04 hgbot Note Added: 0175916
2025-02-19 17:04 hgbot Note Added: 0175917
2025-02-19 17:06 hgbot Note Added: 0175918


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker