Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057217 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Retail Configuration | minor | have not tried | 2024-11-20 19:44 | 2024-11-22 16:44 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Retail | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR25Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057217: Retail Config: Remove some unused ad_message & ad_val_rule entries | |||||||
| Description | Removing usage of application dictionary entries found some unused entries: ad_message - OBRETCO_NotStockedWithStatus - OBRETCO_AssortmentWithStatus ad_val_rule - ECC12A5FFD0949FCA5DC26C116C7217F (Price list including taxes) With any usage they should be removed as: - not having any purpose - Each adds to strings to translate for every new translation | |||||||
| Steps To Reproduce | Do full text search on both ad_message values - in code - in all git clones - in published modules in forge => No usages found | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0172372) hgbot (developer) 2024-11-20 19:53 |
Merge Request created: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/33 [^] |
|
(0172373) hgbot (developer) 2024-11-20 19:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/35 [^] |
|
(0172487) hgbot (developer) 2024-11-22 16:43 |
Repository: https://gitlab.com/openbravo/ci/mobile-api [^] Changeset: a173143e35b2843268a0f2321e66f582f7ce71c8 Author: Stefan Huehner <s.huehner@orisha.com> Date: 21-11-2024 12:21:23 URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/a173143e35b2843268a0f2321e66f582f7ce71c8 [^] ISSUE-57217: Accept API-change --- M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_MESSAGE.xml M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_VAL_RULE.xml --- |
|
(0172488) hgbot (developer) 2024-11-22 16:43 |
Merge request merged: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/33 [^] |
|
(0172489) hgbot (developer) 2024-11-22 16:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/35 [^] |
|
(0172490) hgbot (developer) 2024-11-22 16:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^] Changeset: d1227a64f1e424aa6c334dc991eb712423847e4b Author: Stefan Huehner <s.huehner@orisha.com> Date: 21-11-2024 12:22:08 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/d1227a64f1e424aa6c334dc991eb712423847e4b [^] Fixes ISSUE-57217: Remove unused AD_MESSAGE and AD_VAL_RULE entries AD_MESSAGE: - Commit 3420ba00 in 2015 added OBRETCO_NotStockedWithStatus message entry using it in both AssortmentEventHandler & ProductEventHandler files. - Commmit 363df189 in same day added OBRETCO_AssortmentWithStatus and swapped out usage of first message in ProductEventHandler.java Later in 2019 commit 83f8a5e8430adcd9436a20afa95452484d616054 from mantis issue 40201 removed both eventhandler but left now unused message in place. AD_VAL_RULE Commit 6f97af74 in 2012 added a validation rule to only show price lists including taxes. Later commit 1684c5c4bb83f0071a2b45f76c8f290982caf4fb in 2013 remove the only usage of the validation rule again but left the rule in place. --- M src-db/database/sourcedata/AD_MESSAGE.xml M src-db/database/sourcedata/AD_VAL_RULE.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-11-20 19:44 | shuehner | New Issue | |
| 2024-11-20 19:44 | shuehner | Assigned To | => Retail |
| 2024-11-20 19:44 | shuehner | OBNetwork customer | => No |
| 2024-11-20 19:44 | shuehner | Triggers an Emergency Pack | => No |
| 2024-11-20 19:45 | shuehner | Relationship added | blocks 0057210 |
| 2024-11-20 19:48 | shuehner | Relationship added | related to 0040201 |
| 2024-11-20 19:53 | hgbot | Merge Request Status | => open |
| 2024-11-20 19:53 | hgbot | Note Added: 0172372 | |
| 2024-11-20 19:54 | hgbot | Note Added: 0172373 | |
| 2024-11-20 20:07 | shuehner | Description Updated | View Revisions |
| 2024-11-20 20:14 | shuehner | Summary | Retail Config: Remove some unused ad_messages => Retail Config: Remove some unused ad_message & ad_val_rule entries |
| 2024-11-22 07:59 | hgbot | Merge Request Status | open => approved |
| 2024-11-22 16:43 | hgbot | Note Added: 0172487 | |
| 2024-11-22 16:43 | hgbot | Note Added: 0172488 | |
| 2024-11-22 16:44 | hgbot | Note Added: 0172489 | |
| 2024-11-22 16:44 | hgbot | Resolution | open => fixed |
| 2024-11-22 16:44 | hgbot | Status | new => closed |
| 2024-11-22 16:44 | hgbot | Fixed in Version | => RR25Q1 |
| 2024-11-22 16:44 | hgbot | Note Added: 0172490 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |