0057086: EWI: NPE in org.openbravo.retail.posterminal.OrderLoader.lambda$getLocationFromAddress$0(OrderLoader.java:680)

Description

EWI: NPE in org.openbravo.retail.posterminal.OrderLoader.lambda$getLocationFromAddress$0(OrderLoader.java:680)

the whole stack trace attached

Fixed removing these 2 properties from the json:
"alternateShippingLocation": null,
"alternateInvoicingLocation": null,

Steps To Reproduce

Backoffice:
1)

POS2
1) Change BP to "Arturo"
2) Add product
3) Put breakpoint in 'completeTicket' State action "ticket/actions/CompleteTicket.js"
Update ticket properties like below
newTicket.alternateShippingLocation = null;
newTicket.alternateInvoicingLocation = null;

4) Complete Ticket

Error/EWI occurs

Tags

No tags attached.

Attached Files

stackTrace.txt [^] (5,741 bytes) 2024-11-13 12:53 [Show Content] [Hide Content]

"org.openbravo.base.exception.OBException: Error in OrderLoader: null
	at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:531)
	at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
	at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
	at org.openbravo.retail.posterminal.POSUtils.processErrorEntry(POSUtils.java:909)
	at org.openbravo.retail.posterminal.SaveDataActionHandler.execute(SaveDataActionHandler.java:52)
	at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:70)
	at org.openbravo.retail.posterminal.SaveDataActionHandler$Proxy$_$$_WeldClientProxy.execute(Unknown Source)
	at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:319)
	at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:208)
	at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:291)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
	at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:200)
	at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:461)
	at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:89)
	at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:60)
	at org.openbravo.client.kernel.KernelServlet.service(KernelServlet.java:170)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:38)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:65)
	at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47)
	at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:74)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:96)
	at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47)
	at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:118)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:747)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:351)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:375)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1594)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
	at org.openbravo.retail.posterminal.OrderLoader.lambda$getLocationFromAddress$0(OrderLoader.java:680)
	at org.openbravo.retail.posterminal.OrderLoader.getLocationFromAddress(OrderLoader.java:682)
	at org.openbravo.retail.posterminal.OrderLoader.addAlternateInvoicingLocation(OrderLoader.java:698)
	at org.openbravo.retail.posterminal.OrderLoader.createOrder(OrderLoader.java:1333)
	at org.openbravo.retail.posterminal.OrderLoader.createOrderAndLines(OrderLoader.java:1293)
	at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:371)
	... 57 more"

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0172259) hgbot (developer) 2024-11-20 06:59	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1790 [^]

(0172294) hgbot (developer) 2024-11-20 08:51	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: c02fd4158414bf23b36f4fe87ba1e19a59f740a3 Author: Ranjith S R <r.rangaraju@external.orisha.com> Date: 19-11-2024 18:45:36 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c02fd4158414bf23b36f4fe87ba1e19a59f740a3 [^] Fixed ISSUE-57086: Alternate address should be added to Order if address is valid --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0172295) hgbot (developer) 2024-11-20 08:51	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1790 [^]

Issue History
Date Modified	Username	Field	Change
2024-11-13 12:53	malsasua	New Issue
2024-11-13 12:53	malsasua	Assigned To	=> Retail
2024-11-13 12:53	malsasua	File Added: stackTrace.txt
2024-11-13 12:53	malsasua	Triggers an Emergency Pack	=> No
2024-11-13 12:53	malsasua	Assigned To	Retail => guilleaer
2024-11-18 13:27	guilleaer	Status	new => acknowledged
2024-11-18 13:30	ranjith_qualiantech_com	Assigned To	guilleaer => ranjith_qualiantech_com
2024-11-19 07:12	ranjith_qualiantech_com	Status	acknowledged => scheduled
2024-11-20 06:59	hgbot	Note Added: 0172259
2024-11-20 07:13	ranjith_qualiantech_com	Steps to Reproduce Updated	View Revisions
2024-11-20 08:51	hgbot	Resolution	open => fixed
2024-11-20 08:51	hgbot	Status	scheduled => closed
2024-11-20 08:51	hgbot	Fixed in Version	=> RR25Q1
2024-11-20 08:51	hgbot	Note Added: 0172294
2024-11-20 08:51	hgbot	Note Added: 0172295