Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057026 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Retail Configuration | minor | have not tried | 2024-11-06 17:19 | 2024-11-07 13:47 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR25Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057026: Retail config: old Auxiliarinput OBRETCO_RemoteProduct is no longer used and should be removed | |||||||
| Description | Issue 30553 from 2015 added an Auxiliarinput in retail config module OBRETCO_RemoteProduct which back then was used in display logic of the product category tab. Another commit in issue 41006 in 2019 as part of Cross Store Assortment removed the usage of this auxiliarinput https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/6cfbe785a9c742ad90fa832d356958eea039451e [^] "[CrossStoreAssortment] Remove Filter Product Categories tab display logic" But it did not remove the auxinput itself back then. The auxinput should be removed because: - it is no longer used - no other reference in published OBX or product repos could be found - If does access posterminal preference which is not in dependencies of retail.config module | |||||||
| Steps To Reproduce | Look at definition of auxiliarinput OBRETCO_RemoteProduct / F94E1C2071A54A7CB8F4AFEA71974D43 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0171585) hgbot (developer) 2024-11-06 17:29 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/29 [^] |
|
(0171586) hgbot (developer) 2024-11-06 17:33 |
Merge Request created: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/31 [^] |
|
(0171638) hgbot (developer) 2024-11-07 13:47 |
Repository: https://gitlab.com/openbravo/ci/mobile-api [^] Changeset: ee1c96eef693efe2e6df54d6fc9cdc0796c299b9 Author: Stefan Huehner <s.huehner@orisha.com> Date: 06-11-2024 17:32:56 URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/ee1c96eef693efe2e6df54d6fc9cdc0796c299b9 [^] ISSUE-57026: Accept API change --- M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_AUXILIARINPUT.xml --- |
|
(0171639) hgbot (developer) 2024-11-07 13:47 |
Merge request merged: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/31 [^] |
|
(0171640) hgbot (developer) 2024-11-07 13:47 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^] Changeset: d434f1e432147a4c4d033547601931c41ea4f2ba Author: Stefan Huehner <s.huehner@orisha.com> Date: 07-11-2024 12:45:27 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/d434f1e432147a4c4d033547601931c41ea4f2ba [^] Fixes ISSUE-57026: Remove unused Auxiliarinput OBRETCO_RemoteProduct This Auxinput was added in issue 30553 and used in Displaylogic of product category tab. However later commit from issue 41006 removed it's only usage. Additionally this auxinput is defined here in org.openbravo.retail.config module but it's SQL query refences the OBPOS_remote.product preference from posterminal module. That's not following declared dependencies of retail.config module. --- M src-db/database/sourcedata/AD_AUXILIARINPUT.xml --- |
|
(0171641) hgbot (developer) 2024-11-07 13:47 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/29 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-11-06 17:19 | shuehner | New Issue | |
| 2024-11-06 17:19 | shuehner | Assigned To | => shuehner |
| 2024-11-06 17:19 | shuehner | Triggers an Emergency Pack | => No |
| 2024-11-06 17:29 | hgbot | Note Added: 0171585 | |
| 2024-11-06 17:33 | hgbot | Note Added: 0171586 | |
| 2024-11-07 13:45 | hgbot | Resolution | open => fixed |
| 2024-11-07 13:45 | hgbot | Status | new => closed |
| 2024-11-07 13:45 | hgbot | Fixed in Version | => RR25Q1 |
| 2024-11-07 13:45 | hgbot | Note Added: 0171636 | |
| 2024-11-07 13:47 | hgbot | Note Added: 0171638 | |
| 2024-11-07 13:47 | hgbot | Note Added: 0171639 | |
| 2024-11-07 13:47 | hgbot | Note Added: 0171640 | |
| 2024-11-07 13:47 | hgbot | Note Added: 0171641 | |
| 2024-11-07 13:55 | shuehner | Note Deleted: 0171636 | |
| 2024-11-20 16:09 | shuehner | Relationship added | blocks 0057210 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |