Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0056950
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail Configurationminorhave not tried2024-10-31 15:422024-11-06 15:32
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056950: Remove obsolete (demo) ZohoReports servlet from org.openbravo.retail.config

DescriptionThat Servlet:
- has an ad_process but its not referenced in any menu or button
- loads a hardcoded zoho reports URL
- which seems not (or no longer acessible)
- Code was added in 2012 with a comment
  "Adds a report that displays a Zoho chart"
  "This code is part of a demo, and should not be taken as an example on how to implement a report"

With all that looks like just obsolete / dead code which could/should be removed.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0057210 closedshuehner Openbravo ERP Move content of org.openbravo.retail.config module to backoffice/core repo 

-  Notes
(0171236)
hgbot (developer)
2024-10-31 16:01

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/25 [^]
(0171249)
hgbot (developer)
2024-11-03 10:53

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/177 [^]
(0171250)
hgbot (developer)
2024-11-03 10:57

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/30 [^]
(0171557)
hgbot (developer)
2024-11-06 15:32

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/30 [^]
(0171558)
hgbot (developer)
2024-11-06 15:32

 Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: 26763dede268f15d2a9f3485ef920ee7312dc501
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 03-11-2024 11:05:16
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/26763dede268f15d2a9f3485ef920ee7312dc501 [^]

ISSUE-56950. Remove old/obsolete demo servlet called ZohoReports

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_PROCESS.xml
R model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0171559)
hgbot (developer)
2024-11-06 15:32

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: e4bf95372a2076f3237f82203c951cb53d9c4058
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 06-11-2024 15:24:14
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/e4bf95372a2076f3237f82203c951cb53d9c4058 [^]

ISSUE-56950. Remove old/obsolete demo servlet called ZohoReports

Remove ad_process_access entry for the removed process.

---
M referencedata/sampledata/The_White_Valley_Group/AD_PROCESS_ACCESS.xml
---
(0171560)
hgbot (developer)
2024-11-06 15:32

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/177 [^]
(0171561)
hgbot (developer)
2024-11-06 15:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^]
Changeset: 94cd046c329b05fdf03bdef5c1e55e133d5ebab0
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 06-11-2024 15:31:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/94cd046c329b05fdf03bdef5c1e55e133d5ebab0 [^]

Fixes ISSUE-56950. Remove old/obsolete demo servlet called ZohoReports

That was added in 2012 with a note inside the java saying 'for demo
purposes only'
Now in 2024:
- The hardcoded URL it loads does not show any data
- There's no reference to the ad_process (i.e. menu or button)

=> Remove it as old/obsolete demo code.

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_PROCESS.xml
R src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
R src/org/openbravo/retail/config/ad_reports/ZohoReports.java
---
(0171562)
hgbot (developer)
2024-11-06 15:32

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/25 [^]

- Issue History
Date Modified Username Field Change
2024-10-31 15:42 shuehner New Issue
2024-10-31 15:42 shuehner Assigned To => Retail
2024-10-31 15:42 shuehner OBNetwork customer => No
2024-10-31 15:42 shuehner Triggers an Emergency Pack => No
2024-10-31 15:47 shuehner Assigned To Retail => shuehner
2024-10-31 16:01 hgbot Merge Request Status => open
2024-10-31 16:01 hgbot Note Added: 0171236
2024-11-03 10:53 hgbot Note Added: 0171249
2024-11-03 10:57 hgbot Note Added: 0171250
2024-11-06 11:44 hgbot Merge Request Status open => approved
2024-11-06 15:32 hgbot Note Added: 0171557
2024-11-06 15:32 hgbot Note Added: 0171558
2024-11-06 15:32 hgbot Note Added: 0171559
2024-11-06 15:32 hgbot Note Added: 0171560
2024-11-06 15:32 hgbot Resolution open => fixed
2024-11-06 15:32 hgbot Status new => closed
2024-11-06 15:32 hgbot Fixed in Version => RR25Q1
2024-11-06 15:32 hgbot Note Added: 0171561
2024-11-06 15:32 hgbot Note Added: 0171562
2024-11-20 16:09 shuehner Relationship added blocks 0057210

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker