Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0056692
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2024-10-08 14:172025-01-10 09:06
Reporterdorian_robillardView Statuspublic 
Assigned ToBimla_vm 
PrioritynormalResolutionfixedFixed in Version25Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelPre packaging ( pi )
Regression date2025-01-09
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5ee26b1ddfe51fc5f8da2d8d4c23ab0410678d1c [^]
Triggers an Emergency PackNo
Summary

0056692: VIP price : ‘display discount in order line when not apply’ is not working in POS

DescriptionWhen the ‘display discount in order line when not apply’ field is ticked in the BO, the ‘lack’ of promotion does not appear on the ticket line on the POS, unlike the ‘display discount in order total when not apply’ field, which is correctly applied on the POS
Steps To ReproduceCreate a promotion "Price adjustment"
set "price adjustment for all products"
Percentage 20%
Min 3
Boolean"‘display discount in order line when not apply’ selected
Boolean"‘display discount in order total when not apply’ selected

In pos Add one product --> the display is not done at line level
TagsNo tags attached.
Attached Filespng file icon Capture d’écran 2024-10-08 141444.png [^] (60,174 bytes) 2024-10-08 14:17


png file icon Capture d’écran 2024-10-08 141828.png [^] (33,663 bytes) 2024-10-08 14:18

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0056937 closedRetail POS2 Discounts Visibility some problems 
related to defect 0057397 closedBimla_vm POS2 VIP price : Product planned in the future is considered as promotion missing 
depends on backport 005760325Q1 closedBimla_vm POS2 VIP price : ‘display discount in order line when not apply’ is not working in POS 
caused by feature request 0055872 closedgaboflash Retail Modules Add a new API similar to the currently existing Discounts API to get the discounts visibility feature 
has duplicate defect 0057446 closedRetail POS2 Promotions not applied are not displayed in the POS lines 

-  Notes
(0172850)
hgbot (developer)
2024-12-02 06:49

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3185 [^]
(0172851)
hgbot (developer)
2024-12-02 06:50

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/159 [^]
(0173951)
hgbot (developer)
2025-01-09 15:40

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/159 [^]
(0173962)
hgbot (developer)
2025-01-09 18:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b4b26e3fd05f183bfc74c795d45cd31b6947407a
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 09-01-2025 17:00:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b4b26e3fd05f183bfc74c795d45cd31b6947407a [^]

Fixed ISSUE-56692: fix discounts visibility

- ticket line: send productId instead id
- overwrite getDiscountValues and calculateShortLabel
since they called inside the main method, and needs the discount from cache,
instead the discount that returns the main method of discounts visibility
- use formatCurrency instead OB.I18N.formatCurrency, to have the currency symbol
- adapt tests

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
M web-jspack/org.openbravo.pos2/src/core/discount/__test__/registerDiscountVisibilityPosFunctions.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/registerDiscountVisibilityPosFunctions.js
---
(0173963)
hgbot (developer)
2025-01-09 18:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3185 [^]

- Issue History
Date Modified Username Field Change
2024-10-08 14:17 dorian_robillard New Issue
2024-10-08 14:17 dorian_robillard Assigned To => Retail
2024-10-08 14:17 dorian_robillard File Added: Capture d’écran 2024-10-08 141444.png
2024-10-08 14:17 dorian_robillard Triggers an Emergency Pack => No
2024-10-08 14:18 dorian_robillard File Added: Capture d’écran 2024-10-08 141828.png
2024-11-08 08:38 guilleaer Assigned To Retail => guilleaer
2024-11-08 08:38 guilleaer Status new => acknowledged
2024-11-08 09:38 Bimla_vm Assigned To guilleaer => Bimla_vm
2024-11-08 09:38 Bimla_vm Status acknowledged => scheduled
2024-11-11 09:56 gorka_gil Relationship added related to 0056937
2024-12-02 06:49 hgbot Note Added: 0172850
2024-12-02 06:50 hgbot Note Added: 0172851
2024-12-18 15:15 guillermogil Relationship added related to 0057397
2025-01-09 07:46 Bimla_vm Regression level => Pre packaging ( pi )
2025-01-09 07:46 Bimla_vm Regression date => 2025-01-09
2025-01-09 07:46 Bimla_vm Regression introduced in release => pi
2025-01-09 07:46 Bimla_vm Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5ee26b1ddfe51fc5f8da2d8d4c23ab0410678d1c [^]
2025-01-09 15:40 hgbot Note Added: 0173951
2025-01-09 15:45 guillermogil Status scheduled => acknowledged
2025-01-09 15:46 guillermogil Status acknowledged => scheduled
2025-01-09 18:00 hgbot Resolution open => fixed
2025-01-09 18:00 hgbot Status scheduled => closed
2025-01-09 18:00 hgbot Fixed in Version => 25Q2
2025-01-09 18:00 hgbot Note Added: 0173962
2025-01-09 18:00 hgbot Note Added: 0173963
2025-01-10 09:06 gorka_gil Relationship added caused by 0055872
2025-01-21 12:56 gorka_gil Relationship added has duplicate 0057446

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker