Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0056587 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | have not tried | 2024-09-30 15:39 | 2024-10-14 11:49 | |||
| Reporter | jayala | View Status | public | |||||
| Assigned To | Rajesh_18 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0056587: [DraftOrders] Manual discounts are lost | |||||||
| Description | When a draft order which contain a manual discount is loaded, the manual discount is lost when the discount engine is executed. Discounts engine is executeb doing several actions: - Add new items to the ticket - Press pay button | |||||||
| Steps To Reproduce | 1. Add a product to a ticket. 2. Add a manual discount to the line. 3. Save the ticket as Draft Order. 4. Load the saved Draft Order (the discount is keeped). 5a. Click pay button. 5b. Modify the ticket. 6. The discount is lost. | |||||||
| Proposed Solution | When a draft order is loaded the information abot discounts is retrieved but not the information about manual discounts. We need to re-generate manual discounts info. To do that we can use this code [ https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/blob/59b2f8c0168a9e3aa794b4610cce853fd16f8801/web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js#L341 [^]] This information must be generated here [https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/8a8a0429859bac4c63459f5fbf418cebd7b00ea2/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js#L108 [^]] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0170188) hgbot (developer) 2024-10-09 13:23 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/155 [^] |
|
(0170345) hgbot (developer) 2024-10-14 11:49 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 634bfb6f49b59debb5c8b573536a99de8166c915 Author: Rajesh Senthilkumar <r.senthilkumar@external.orisha.com> Date: 14-10-2024 09:49:35 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/634bfb6f49b59debb5c8b573536a99de8166c915 [^] Fixed ISSUE-56587: [DraftOrders] Manual discounts are added to draft ticket --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js --- |
|
(0170346) hgbot (developer) 2024-10-14 11:49 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/155 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-09-30 15:39 | jayala | New Issue | |
| 2024-09-30 15:39 | jayala | Assigned To | => Retail |
| 2024-09-30 15:39 | jayala | OBNetwork customer | => No |
| 2024-09-30 15:39 | jayala | Triggers an Emergency Pack | => No |
| 2024-09-30 15:39 | jayala | Assigned To | Retail => jayala |
| 2024-10-08 08:34 | guilleaer | Type | design defect => defect |
| 2024-10-08 08:34 | guilleaer | Description Updated | View Revisions |
| 2024-10-08 08:34 | guilleaer | Proposed Solution updated | |
| 2024-10-08 08:35 | guilleaer | OBNetwork customer | No => OBPS |
| 2024-10-08 08:35 | guilleaer | Status | new => acknowledged |
| 2024-10-08 09:07 | guilleaer | Assigned To | jayala => Retail |
| 2024-10-08 09:22 | Rajesh_18 | Assigned To | Retail => Rajesh_18 |
| 2024-10-08 09:22 | Rajesh_18 | Status | acknowledged => scheduled |
| 2024-10-09 13:23 | hgbot | Merge Request Status | => open |
| 2024-10-09 13:23 | hgbot | Note Added: 0170188 | |
| 2024-10-14 11:49 | hgbot | Merge Request Status | open => approved |
| 2024-10-14 11:49 | hgbot | Resolution | open => fixed |
| 2024-10-14 11:49 | hgbot | Status | scheduled => closed |
| 2024-10-14 11:49 | hgbot | Fixed in Version | => RR25Q1 |
| 2024-10-14 11:49 | hgbot | Note Added: 0170345 | |
| 2024-10-14 11:49 | hgbot | Note Added: 0170346 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |