Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0055876
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2024-07-01 13:022024-11-07 06:31
ReportergorkaionView Statuspublic 
Assigned Tokousalya_r 
PriorityhighResolutionfixedFixed in VersionRR25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055876: Tax calculation in the WebPOS distrubute the adjustment amount on different lines

DescriptionSometimes, the tax engine needs to perform an adjustment on the lines if "Document based" tax calculation is used, in order to ensure that line amount match with the calculated taxes.

Currently the line adjusted is the one with highest rounding amount in the opposite direction. However if the required adjustment amount is for more than 1 cent the adjustment should be spread on different lines.

For example if the adjustment amount is of 0.02 the 2 lines with highest rounded amount shall be adjusted with 1 cent each.
Steps To ReproduceEnsure that the tax calculation base is at document level.
Create a ticket with 10 lines of 0.01 eur each.
POS calculates a tax of 0.00EUR on each line.
At header level the total is 0.10EUR with 0.02EUR tax.

To adjust those 0.02 cents if chooses one of the lines and changes the tax amount to 0.02. These makes the line net amount to be -0.01.

The negative line net amount causes some integrations to fail.
Proposed SolutionInstead of adjusting one line the tax engine should have adjusted 2 lines leaving the line net amount of those to 0Eur which is accepted by the integration.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046071 closedranjith_qualiantech_com Tax calculation in the WebPOS should adjust the tax line with the greatest rounded difference 
related to defect 0056612 closedkousalya_r Error in tax calculation 

-  Notes
(0166570)
frank_gonzalez (developer)
2024-07-02 08:56

 Jir: https://openbravo.atlassian.net/browse/RM-15092 [^]
(0170457)
hgbot (developer)
2024-10-15 18:37

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1721 [^]
(0170528)
hgbot (developer)
2024-10-17 12:34

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/17 [^]
(0170561)
hgbot (developer)
2024-10-18 09:25

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/427 [^]
(0170809)
hgbot (developer)
2024-10-23 10:06

 Merge request closed: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/427 [^]
(0170846)
hgbot (developer)
2024-10-23 21:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1721 [^]
(0170847)
hgbot (developer)
2024-10-23 21:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 489f7b8c1611c784fc9bb8dcfadcc1050539516f
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 23-10-2024 19:00:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/489f7b8c1611c784fc9bb8dcfadcc1050539516f [^]

Fixed ISSUE-55876: Tax amount adjustment in lines

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/rules/priceincluding-tax.js
---
(0170848)
hgbot (developer)
2024-10-23 21:00

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/17 [^]
(0170849)
hgbot (developer)
2024-10-23 21:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes [^]
Changeset: ab96683b9b95b5773869eedcc9b8826490222487
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 23-10-2024 19:00:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/commit/ab96683b9b95b5773869eedcc9b8826490222487 [^]

Fixed ISSUE-55876: Tax Data Adjustment

---
A src-test/org/openbravo/taxes/test/data/TaxesTestData59.java
M src-test/org/openbravo/taxes/test/unittests/TaxesTest.java
---
(0170856)
hgbot (developer)
2024-10-24 07:14

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1730 [^]
(0170858)
hgbot (developer)
2024-10-24 07:31

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1730 [^]
(0170859)
hgbot (developer)
2024-10-24 07:31

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d1a8120895aa35daed939ebd130d1144333db21b
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 24-10-2024 05:31:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d1a8120895aa35daed939ebd130d1144333db21b [^]

Fixed ISSUE-55876: Jslint fix

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/rules/priceincluding-tax.js
---
(0170968)
hgbot (developer)
2024-10-25 14:33

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1736 [^]
(0170972)
hgbot (developer)
2024-10-25 17:38

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/18 [^]
(0171333)
hgbot (developer)
2024-11-04 16:14

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/434 [^]
(0171598)
hgbot (developer)
2024-11-07 06:30

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1736 [^]
(0171599)
hgbot (developer)
2024-11-07 06:30

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a3a792ca46a48ed37a627e6b984f598e7a459533
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 07-11-2024 05:30:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a3a792ca46a48ed37a627e6b984f598e7a459533 [^]

Fixes ISSUE-55876: price adjustment

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/rules/priceincluding-tax.js
---
(0171600)
hgbot (developer)
2024-11-07 06:31

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/18 [^]
(0171601)
hgbot (developer)
2024-11-07 06:31

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes [^]
Changeset: 17a5bc9d0759a119bf22b7a4485462bf003785fa
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 07-11-2024 05:31:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/commit/17a5bc9d0759a119bf22b7a4485462bf003785fa [^]

Fixed ISSUE-55876: Fixed Test Data for tax adjustment fix

---
M src-test/org/openbravo/taxes/test/data/TaxesTestData09.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData24.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData26.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData27.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData32.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData34.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData35.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData36.java
M src-test/org/openbravo/taxes/test/data/TaxesTestData59.java
---
(0171602)
hgbot (developer)
2024-11-07 06:31

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/434 [^]
(0171603)
hgbot (developer)
2024-11-07 06:31

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: a9c272da0c1a99a45c2cdd33b57253febadaa737
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 07-11-2024 05:31:13
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/a9c272da0c1a99a45c2cdd33b57253febadaa737 [^]

Fixed ISSUE-55876: Price Adjustment data fix

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifySimpleReturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I32217_MPLDiscountOnlyForOneCustomerAndDifferentTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/MPLDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/prepaymentsAndInvoiceTerms/OMNI080_CancelLayawayServiceAsPerProductUndeliverableProductPrepaymentWithApprovalAfterOrderDelivery.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/MultipleLinesSameProductCascadeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/NormalCascadeAndDependantTaxesI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/NormalCascadeAndDependantTaxesII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/TwoSetsTaxesWithDependantTaxes.java
---

- Issue History
Date Modified Username Field Change
2024-07-01 13:02 gorkaion New Issue
2024-07-01 13:02 gorkaion Assigned To => Retail
2024-07-01 13:02 gorkaion Triggers an Emergency Pack => No
2024-07-01 13:02 gorkaion Issue generated from 0046071
2024-07-01 13:02 gorkaion Relationship added related to 0046071
2024-07-01 13:21 marvintm Assigned To Retail => Triage Omni OMS
2024-07-02 08:56 frank_gonzalez Note Added: 0166570
2024-07-16 16:07 aferraz Type defect => design defect
2024-09-02 15:52 dmitry_mezentsev Severity major => minor
2024-09-02 15:52 dmitry_mezentsev Type design defect => defect
2024-10-08 12:13 egoitz Severity minor => major
2024-10-14 10:42 jonae Assigned To Triage Omni OMS => kousalya_r
2024-10-15 18:37 hgbot Note Added: 0170457
2024-10-17 12:34 hgbot Note Added: 0170528
2024-10-18 09:25 hgbot Note Added: 0170561
2024-10-23 10:06 hgbot Note Added: 0170809
2024-10-23 21:00 hgbot Note Added: 0170846
2024-10-23 21:00 hgbot Resolution open => fixed
2024-10-23 21:00 hgbot Status new => closed
2024-10-23 21:00 hgbot Fixed in Version => RR25Q1
2024-10-23 21:00 hgbot Note Added: 0170847
2024-10-23 21:00 hgbot Note Added: 0170848
2024-10-23 21:00 hgbot Note Added: 0170849
2024-10-24 07:14 hgbot Note Added: 0170856
2024-10-24 07:31 hgbot Note Added: 0170858
2024-10-24 07:31 hgbot Note Added: 0170859
2024-10-25 14:33 hgbot Note Added: 0170968
2024-10-25 17:38 hgbot Note Added: 0170972
2024-10-28 09:22 aferraz Relationship added related to 0056612
2024-11-04 16:14 hgbot Note Added: 0171333
2024-11-07 06:30 hgbot Note Added: 0171598
2024-11-07 06:30 hgbot Note Added: 0171599
2024-11-07 06:31 hgbot Note Added: 0171600
2024-11-07 06:31 hgbot Note Added: 0171601
2024-11-07 06:31 hgbot Note Added: 0171602
2024-11-07 06:31 hgbot Note Added: 0171603

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker