0055630: Gift card in another currency doesn't work as expected

Description

Test done after this issue : https://issues.openbravo.com/view.php?id=55554 [^]
There are issues after the correction :

1) The gift card take in account the organization where its belong for currency -> wrong, that should be the one used when you credited the gift card, so the creation organization currency or have its own saved on the gift card object based on the payment method used to pay it.

1-2) If the organization of the gift card has a different currency, it doesn't do the conversion (I pay 100XPF gift card, it will be created on a EUR organization, the system consider that I have a 100€ gift card)

2) When you try to use it you must define a currency or an error occur without any warning -> No alert message explaining the issue that the currency is missing

3) When you look for it in another currency the amount display isn't the right one (it's the amount of the gift card + currency of the store) so if I have a 100€ gift card, on a XPF store, the POS show me 100XPF for this gift card, it should display the amount after conversion if needed

4) You can only apply this amount maximum and not the one wanted (in my exemple only 100CFPF while i asked and should be able to use 2384CFPF)

Steps To Reproduce

To reproduce :
1 / 1-2 ) Set the organization for gift cards in €
Go on a XPF store
Create a gift card, you have a 100€ gift cards (should be a 100XPF gift card)

2) Don't define a currency in the organization where gift card are created, try to pay with it

3) Go on a € pos, search for the 100XPF gift card, it show a 100€ gift card

4) create a 100€ gift card
On a XPF POS, try to pay the maximum amount with it
It will display a 100 XPF gift card, select it
it only apply 100xpf payment, while i should be able to pay maximum 11 933 XPF

Proposed Solution

1) Use the currency of the creation organization, or use the currency of the payment method used to pay it.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0165701) hgbot (developer) 2024-06-07 15:06	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/345 [^]

(0165702) hgbot (developer) 2024-06-07 15:07	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2705 [^]

(0165704) hgbot (developer) 2024-06-08 05:19	Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/142 [^]

(0169958) hgbot (developer) 2024-10-03 14:39	Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2705 [^]

(0169959) hgbot (developer) 2024-10-03 14:39	Merge request closed: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/142 [^]

(0169960) hgbot (developer) 2024-10-03 14:39	Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/345 [^]

Issue History
Date Modified	Username	Field	Change
2024-05-30 16:06	remibrunet	New Issue
2024-05-30 16:06	remibrunet	Assigned To	=> Retail
2024-05-30 16:06	remibrunet	Triggers an Emergency Pack	=> No
2024-05-31 10:00	jorgewederago	Status	new => acknowledged
2024-05-31 12:58	Rajesh_18	Assigned To	Retail => Rajesh_18
2024-05-31 12:58	Rajesh_18	Status	acknowledged => scheduled
2024-06-07 15:06	hgbot	Note Added: 0165701
2024-06-07 15:07	hgbot	Note Added: 0165702
2024-06-08 05:19	hgbot	Note Added: 0165704
2024-10-03 14:39	hgbot	Note Added: 0169958
2024-10-03 14:39	hgbot	Note Added: 0169959
2024-10-03 14:39	hgbot	Note Added: 0169960
2024-10-21 08:36	jorgewederago	Type	defect => feature request