Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055260 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Retail API Gift Cards | major | always | 2024-04-08 11:19 | 2024-04-23 09:11 | |||
| Reporter | gorkaion | View Status | public | |||||
| Assigned To | Rajesh_18 | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR24Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055260: Consume GiftCards API returns a 500 error when the coupon is consumed | |||||||
| Description | When the Consume Giftcards API is called with a giftcard that it is already closed the response has 500 status. The expected result is a 2XX status with an error message since the call has not fail technically. | |||||||
| Steps To Reproduce | 1. Create new GiftCard instance. 2. Check using the API that the giftcard is available using /org.openbravo.api.ExportService/GiftCard/bySearchKey 3. Consume completelly (with an amount higher than the available) the giftcard using /ws/org.openbravo.retail.api.giftcards.ImportService/ConsumeGiftCard the response is 2XX 4. Check again the giftcard and notice it is closed. 5. Try to consume again the giftcards using the ConsumeGiftcard api, notice that the response is a 500 error. This is wrong, status should be 2XX with a message indicating that the giftcard is already expired/consumed/... | |||||||
| Proposed Solution | change the response status to 2XX | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0163560) hgbot (developer) 2024-04-23 08:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards/-/merge_requests/35 [^] |
|
(0163571) hgbot (developer) 2024-04-23 09:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards [^] Changeset: 71f91ef1badf10a32de32dcd2fa3573238514716 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 23-04-2024 12:15:28 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards/-/commit/71f91ef1badf10a32de32dcd2fa3573238514716 [^] Fixed ISSUE-55260: Catched OBException and returned the response status as 200 --- M src/org/openbravo/retail/api/giftcards/service/ConsumeGiftCardApiImportWebService.java --- |
|
(0163572) hgbot (developer) 2024-04-23 09:11 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards/-/merge_requests/35 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-04-19 08:13 | marvintm | Type | defect => backport |
| 2024-04-19 08:13 | marvintm | Target Version | => RR24Q2 |
| 2024-04-23 08:48 | hgbot | Note Added: 0163560 | |
| 2024-04-23 09:11 | hgbot | Resolution | open => fixed |
| 2024-04-23 09:11 | hgbot | Status | scheduled => closed |
| 2024-04-23 09:11 | hgbot | Note Added: 0163571 | |
| 2024-04-23 09:11 | hgbot | Note Added: 0163572 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |