Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054558 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Modules] Commercial Operations | trivial | have not tried | 2024-02-02 12:42 | 2024-05-15 12:18 | |||
| Reporter | RobinB | View Status | public | |||||
| Assigned To | justin_patterson | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0054558: New extra validity logic for Coupons - giftcards - creditnote - giftcertificate | |||||||
| Description | New extra validity days logic for Coupons - giftcards - creditnote - giftcertificate. Possibility to add an extra validity days period for those payments that can be addtionned in case of manager approval. Standars modules affected : org.openbravo.retail.discounts.coupons org.openbravo.retail.discounts.coupons.otf org.openbravo.retail.giftcards | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0160629) hgbot (developer) 2024-02-12 15:26 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/42 [^] |
|
(0162876) hgbot (developer) 2024-04-05 10:50 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/48 [^] |
|
(0162877) hgbot (developer) 2024-04-05 10:52 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/315 [^] |
|
(0162984) hgbot (developer) 2024-04-09 12:40 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/42 [^] |
|
(0162985) hgbot (developer) 2024-04-09 12:41 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/48 [^] |
|
(0163408) hgbot (developer) 2024-04-18 18:11 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/48 [^] |
|
(0163409) hgbot (developer) 2024-04-18 18:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/50 [^] |
|
(0164647) hgbot (developer) 2024-05-15 12:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: 063c967817d247d87a98eec2c33028989fdab7a9 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 06-05-2024 09:53:04 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/063c967817d247d87a98eec2c33028989fdab7a9 [^] Fixes FR-54558: Extra Validity Days -Added new column to OBDISCP_COUPON to store number of extra days a coupon may be valid beyond its expiration date -Added new field to back office in appropriate window -Added logic to CouponAvailability.java to return correct properties for coupon taking into account new field -Added logic to SearchAndAddCouponToTicketActionPreparation.js to add coupon to ticket if within valid grace period --- M src-db/database/model/tables/OBDISCP_COUPON.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js --- |
|
(0164648) hgbot (developer) 2024-05-15 12:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: b0d9bb4ab8c15ec138dd41da9c105f46ab8d60d9 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 06-05-2024 09:53:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/b0d9bb4ab8c15ec138dd41da9c105f46ab8d60d9 [^] Fixes FR-54558: Extra Validity Days -Added tests --- M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/__test__/SearchAndAddCouponToTicketActionPreparation.test.js --- |
|
(0164649) hgbot (developer) 2024-05-15 12:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^] Changeset: f3c303c8a8070d8ffe297607bb6fdcaca5f5847b Author: Jorge Wederago <j.wederago@orisha.com> Date: 15-05-2024 12:11:10 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/f3c303c8a8070d8ffe297607bb6fdcaca5f5847b [^] Fixes FR-54558: Set extra validity date on coupons --- A web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AllowExtraValidityDays.js M src-db/database/model/tables/OBDISCP_COUPON.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java M web-jspack/org.openbravo.retail.discounts.coupons/src/components/CouponsPanelGrid/AvailableCouponsList/AvailableCouponsList.jsx M web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/coupons/user-actions/AddCoupon.js M web-jspack/org.openbravo.retail.discounts.coupons/src/ob-init.js M web-jspack/org.openbravo.retail.discounts.coupons/src/services/scan/handlers/CouponScanEventHandler.js R web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCoupon.js R web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/SearchAndAddCouponToTicketActionPreparation.js R web-jspack/org.openbravo.retail.discounts.coupons/src/model/ticket/actions/__test__/SearchAndAddCouponToTicketActionPreparation.test.js --- |
|
(0164650) hgbot (developer) 2024-05-15 12:18 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/48 [^] |
|
(0164651) hgbot (developer) 2024-05-15 12:18 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: feb1623226f9578895d50c47422e3073dde09c43 Author: Jorge Wederago <j.wederago@orisha.com> Date: 15-05-2024 12:14:35 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/feb1623226f9578895d50c47422e3073dde09c43 [^] Related to FR-54558: Set extra validity date on coupons --- A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/GiftCardUtils.js A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/__test__/GiftCardUtils.test.js A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/user-actions/AllowExtraValidityDays.js M src-db/database/model/modifiedTables/AD_ORG.xml M src-db/database/model/modifiedTables/M_PRODUCT.xml M src-db/database/model/tables/GCNV_GIFTCARD_REASON.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src-db/database/sourcedata/OBC2_USER_ACTION.xml M src/org/openbravo/retail/giftcards/FindGiftCards.java M src/org/openbravo/retail/giftcards/FindGiftCardsProperties.java M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js --- |
|
(0164652) hgbot (developer) 2024-05-15 12:18 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^] Changeset: 01668c4ba04e8c1588d5cf9e1975676f275f036b Author: Jorge Wederago <j.wederago@orisha.com> Date: 15-05-2024 12:15:59 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/01668c4ba04e8c1588d5cf9e1975676f275f036b [^] Related to FR-54558: Set extra validity date on coupons --- M src-db/database/model/tables/OBCPOTF_COUPONRULES.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/retail/discounts/coupons/otf/OrderLoaderHookOTFCoupons.java --- |
|
(0164653) hgbot (developer) 2024-05-15 12:18 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/315 [^] |
|
(0164654) hgbot (developer) 2024-05-15 12:18 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/50 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-02-02 12:42 | RobinB | New Issue | |
| 2024-02-02 12:42 | RobinB | Assigned To | => Triage Omni OMS |
| 2024-02-02 12:59 | aferraz | Assigned To | Triage Omni OMS => Retail |
| 2024-02-12 15:26 | hgbot | Note Added: 0160629 | |
| 2024-04-05 10:50 | hgbot | Note Added: 0162876 | |
| 2024-04-05 10:52 | hgbot | Note Added: 0162877 | |
| 2024-04-09 12:40 | hgbot | Note Added: 0162984 | |
| 2024-04-09 12:41 | hgbot | Note Added: 0162985 | |
| 2024-04-18 18:11 | hgbot | Note Added: 0163408 | |
| 2024-04-18 18:15 | hgbot | Note Added: 0163409 | |
| 2024-04-22 11:39 | aaroncalero | Assigned To | Retail => justin_patterson |
| 2024-04-22 11:39 | aaroncalero | Status | new => scheduled |
| 2024-05-15 12:18 | hgbot | Resolution | open => fixed |
| 2024-05-15 12:18 | hgbot | Status | scheduled => closed |
| 2024-05-15 12:18 | hgbot | Note Added: 0164647 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164648 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164649 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164650 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164651 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164652 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164653 | |
| 2024-05-15 12:18 | hgbot | Note Added: 0164654 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |