Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0005352

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

trivial

always

2008-10-01 10:29

2008-12-13 20:30

Reporter

rafaroda

View Status

public

Assigned To

Hennadzi

Priority

low

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 32 bit

Database

PostgreSQL

Java version

1.5

OS Version

Ubuntu 7.10

Database version

8.3

Ant version

1.7

Product Version

pi

SCM revision

8115

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0005352: Malformed ORDER BY clause in some reports

Description

The following reports (Java files) form a malformed ORDER BY clause:
1) ReportDimensionalAnalysesPDF.java
2) ReportInvoiceCustomerDimensionalAnalyses.java
3) ReportInvoiceCustomerDimensionalAnalysesJR.java
4) ReportInvoiceCustomerDimensionalPDF.java
5) ReportInvoiceVendorDimensionalAnalysesJR.java
6) ReportMaterialDimensionalAnalysesJR.java
7) ReportPurchaseDimensionalAnalysesJR.java
8) ReportRefundInvoiceCustomerDimensionalAnalyses.java
9) ReportRefundSalesDimensionalAnalyses.java
10) ReportRefundSalesDimensionalAnalysesPDF.java
11) ReportSalesDimensionalAnalyzeJR.java
12) ReportSalesOrderDimensionalPDF.java
13) ReportShipmentDimensionalAnalyzeJR.java

Steps To Reproduce

For 11) ReportSalesDimensionalAnalyzeJR.java:
* Put a break point in the line 'String strHaving = "";' in order to evaluate 'strOrderby' variable at this point.
* Go to 'Sales Management || Analysis Tools || Sales Dimensional Report':
A1) Select 1 dimension (Product) and 'Standard' check-box: strOrderby = ORDER BY NIVEL1 (Correct)
B1) Select 1 dimension (Product) and 'By Ascending Amount' check-box: strOrderby = ORDER BY AMOUNT ASC (Correct)
C1) Select 1 dimension (Product) and 'By Descending Amount' check-box: strOrderby = ORDER BY AMOUNT DESC (Correct)
A2) Select 2 dimensions (Product Group and Product) and 'Standard' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,NIVEL2 (Wrong: NIVEL1 is repeated)
B2) Select 2 dimensions (Product Group and Product) and 'By Ascending Amount' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,AMOUNT ASC (Wrong: NIVEL1 is repeated)
C2) Select 2 dimensions (Product Group and Product) and 'By Descending Amount' check-box: strOrderby = ORDER BY NIVEL1,NIVEL1,AMOUNT DESC (Wrong: NIVEL1 is repeated)

Since the only problem here is that the SQL is malformed (the report does not crash and the data are shown correctly) this defect will not be backported.

Proposed Solution

Patch attached for ReportSalesDimensionalAnalyzeJR.java.

Tags

No tags attached.

patch-ReportSalesDimensionalAnalyzeJR.diff [^] (754 bytes) 2008-10-01 10:29 [Show Content] [Hide Content]

### Eclipse Workspace Patch 1.0
#P openbravo
Index: src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
===================================================================
--- src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java	(revision 7783)
+++ src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java	(working copy)
@@ -339,7 +339,11 @@
     }
     if (intDiscard != 0 || intAuxDiscard != -1){
       int k=1;
-      strOrderby = " ORDER BY NIVEL"+k+",";
+      if (intDiscard == 1){
+        strOrderby = " ORDER BY NIVEL"+k+",";
+      } else {
+        strOrderby = " ORDER BY ";
+      }
       while (k<intDiscard){
         strOrderby = strOrderby+"NIVEL"+k+",";
         k++;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0009299) svnbot (reporter) 2008-10-01 12:58	Repository: openbravo Revision: 8120 Author: hennadzi Date: 2008-10-01 12:57:57 +0200 (Wed, 01 Oct 2008) fixed bug 0005352: Malformed ORDER BY clause in some reports --- U trunk/src/org/openbravo/erpCommon/ad_reports/ReportDimensionalAnalysesPDF.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java --- https://dev.openbravo.com/websvn/openbravo/?rev=8120&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-10-01 10:29	rafaroda	New Issue
2008-10-01 10:29	rafaroda	Assigned To	=> Hennadzi
2008-10-01 10:29	rafaroda	sf_bug_id	0 => 2139916
2008-10-01 10:29	rafaroda	File Added: patch-ReportSalesDimensionalAnalyzeJR.diff
2008-10-01 10:29	rafaroda	Regression testing	=> No
2008-10-01 10:29	rafaroda	Status	new => scheduled
2008-10-01 10:29	rafaroda	fix_in_branch	=> trunk
2008-10-01 12:58	svnbot	Checkin
2008-10-01 12:58	svnbot	Note Added: 0009299
2008-10-01 12:58	svnbot	Status	scheduled => resolved
2008-10-01 12:58	svnbot	Resolution	open => fixed
2008-10-01 12:58	svnbot	svn_revision	=> 8120
2008-12-13 20:30	psarobe	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group