0053466: ExternalOrderLoader API: C&R doesn't work

Description

C&R is not working anymore using the external order loader API.

Steps To Reproduce

1. Import Retail API collection in postman https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json?ref_type=heads [^]
2. Execute the request "Import Order - Simple ticket with 2 lines"
3. Execute the request "Import Order - Order cancel and replace" (with the id of replacedorder done in point 2)
4.In Openbravo.log is present following error

2023-09-05 16:22:08,435 [Import Entry - 4] ERROR org.openbravo.retail.posterminal.POSDataSynchronizationErrorHandler - An error happened when processing a record:
org.openbravo.base.exception.OBException: CancelAndReplaceUtils.cancelAndReplaceOrder:
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:578) ~[classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
        at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
        at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430) [classes/:?]
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347) [classes/:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.POSUtils.setDefaultPaymentType(POSUtils.java:579) ~[classes/:?]
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:566) ~[classes/:?]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0053390

closed

sreehari

ExternalOrderLoader API: C&R doesn't work

Notes
(0154924) hgbot (developer) 2023-09-18 07:17	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1346 [^]

(0154963) hgbot (developer) 2023-09-19 06:10	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 91e11a1a025c6e65a6636468ed83a471fe3453b0 Author: Sreehari Venkataraman <sreehari@qualiantech.com> Date: 16-09-2023 12:10:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/91e11a1a025c6e65a6636468ed83a471fe3453b0 [^] Fixes ISSUE-53466: Changed cancelled order to Replacedorder --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0154964) hgbot (developer) 2023-09-19 06:10	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1346 [^]

Issue History
Date Modified	Username	Field	Change
2023-09-15 14:00	sreehari	Type	defect => backport
2023-09-15 14:00	sreehari	Target Version	=> RR23Q2.4
2023-09-18 07:17	hgbot	Merge Request Status	=> open
2023-09-18 07:17	hgbot	Note Added: 0154924
2023-09-19 06:10	hgbot	Merge Request Status	open => approved
2023-09-19 06:10	hgbot	Resolution	open => fixed
2023-09-19 06:10	hgbot	Status	scheduled => closed
2023-09-19 06:10	hgbot	Fixed in Version	=> RR23Q2.4
2023-09-19 06:10	hgbot	Note Added: 0154963
2023-09-19 06:10	hgbot	Note Added: 0154964