Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053461
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[POS2] POSmajorhave not tried2023-09-15 05:442023-10-16 17:39
Reporterprakashmurugesan88View Statuspublic 
Assigned Toprakashmurugesan88 
PrioritynormalResolutionfixedFixed in Version24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053461: Block payment methods combination on the same ticket

DescriptionImplement new functionality consisting of defining for a payment method the impossibility of mixing with specific other payment methods.
In some specific client cases, a payment method cannot be mixed with another or other payment methods..
That means if a cashier uses this payment method, it should be impossible to partially pay the ticket with this kind of payment method because it cannot be mixed with another one.

Steps To Reproducehttps://docs.google.com/document/d/1uCF7YH0shZDHp7Lw-V-5AJmYXCjAEynDd45qwxJr7zE/edit [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0155298)
hgbot (developer)
2023-09-27 13:43

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1367 [^]
(0155299)
hgbot (developer)
2023-09-27 13:47

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2126 [^]
(0155383)
hgbot (developer)
2023-09-29 11:42

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/merge_requests/8 [^]
(0155442)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 236c339ef121d05da556a914e1df74e1e4bbf511
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/236c339ef121d05da556a914e1df74e1e4bbf511 [^]

Related to ISSUE-53461: Created new field PMs Allowed to Mix in Touchpoint Type Payment Method
* Created new tab for PMs to Mix

---
A src-db/database/model/tables/OBPOS2_PM_FOR_MIX.xml
M src-db/database/model/modifiedTables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0155443)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f08a817ec1dd1a6078ececd16f17eb070600e2aa
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f08a817ec1dd1a6078ececd16f17eb070600e2aa [^]

Related to ISSUE-53461: Loaded PM to Mix info into POS through Terminal Payment Method Info

---
A src/org/openbravo/pos2/hook/term/AddPaymentMethodsToMix.java
---
(0155444)
hgbot (developer)
2023-10-04 08:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 391980d6ac44655283a89825d4a7769728942b2b
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/391980d6ac44655283a89825d4a7769728942b2b [^]

Fixes ISSUE-53461: Validated and disabled payment method based on PMs Allowed to Mix configuration

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
---
(0155445)
hgbot (developer)
2023-10-04 08:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f2625f3b5845ed4d764621e1f7f0c7b7fc7ea839
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f2625f3b5845ed4d764621e1f7f0c7b7fc7ea839 [^]

Fixes ISSUE-53461: Displayed tooltip message for disabling Payment Method

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
---
(0155446)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a66bfb19cb379fcbbb48a436869c8995f427e31d
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a66bfb19cb379fcbbb48a436869c8995f427e31d [^]

Related to ISSUE-53461: Added jest test for PaymentMethodAllowedToMix in utility function and payment button

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/__test__/PaymentButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
---
(0155447)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c6e98b7863708169c93410f33355f0266a054109
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c6e98b7863708169c93410f33355f0266a054109 [^]

Related to ISSUE-53461: Fixed failing Test and Stories

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/PaymentMock.config.json
M web-jspack/org.openbravo.pos2/src/components/Payments/CoinsAndBills/__test__/CoinsAndBills.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/stories/PaymentButton.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsHighVolumePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsStandardPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/componentsListSnapshot.json
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__mock__/payments.json
---
(0155448)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3386d5dbc8f45be231b2ad9dae4adfe1c115b406
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3386d5dbc8f45be231b2ad9dae4adfe1c115b406 [^]

Related to ISSUE-53461: Added Cypress test for PM allowed to Mix
* Included PM to Mix table in POS2SampleData dataset

---
A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/paymentMethodAllowedToMix.spec.js
A web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/e2eFixtures/PaymentMethodAllowedToMix.json
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-db/database/sourcedata/AD_TABLE.xml
---
(0155449)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b8c649d57df8a69b4a6342f237c8b84647c90242
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b8c649d57df8a69b4a6342f237c8b84647c90242 [^]

Related to ISSUE-53461: Included new spec in runFeaturesSpecsPOS2.spec.js

---
M web-jspack/org.openbravo.pos2/src-test/cypress/runAllSpecs/runFeaturesSpecsPOS2.spec.js
---
(0155450)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cca26aeb4beb4264355965222a110d9baf5c9772
Author: Prakash M <prakash@qualiantech.com>
Date: 04-10-2023 08:08:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cca26aeb4beb4264355965222a110d9baf5c9772 [^]

Related to ISSUE-53461: Passed ticket and terminal payments as parameters to util function
* To transform it into a pure function

---
M web-jspack/org.openbravo.pos2/src/components/Payments/CoinsAndBills/__test__/CoinsAndBills.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/__test__/PaymentButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
---
(0155451)
hgbot (developer)
2023-10-04 08:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2126 [^]
(0155452)
hgbot (developer)
2023-10-04 08:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d911301b1e81b74b0d6d16178157ca7f91a16e41
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 04-10-2023 08:09:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d911301b1e81b74b0d6d16178157ca7f91a16e41 [^]

Fixed ISSUE-53461: Implemented payment mixing functionality

---
A src-db/database/model/tables/OBPOS2_PM_FOR_MIX.xml
A src/org/openbravo/pos2/hook/term/AddPaymentMethodsToMix.java
A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/paymentMethodAllowedToMix.spec.js
A web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/e2eFixtures/PaymentMethodAllowedToMix.json
M src-db/database/model/modifiedTables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M web-jspack/org.openbravo.pos2/src-test/cypress/runAllSpecs/runFeaturesSpecsPOS2.spec.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/PaymentMock.config.json
M web-jspack/org.openbravo.pos2/src/components/Payments/CoinsAndBills/__test__/CoinsAndBills.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/__test__/PaymentButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/stories/PaymentButton.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsHighVolumePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsStandardPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/componentsListSnapshot.json
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__mock__/payments.json
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
---
(0155453)
hgbot (developer)
2023-10-04 08:10

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/merge_requests/8 [^]
(0155454)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata [^]
Changeset: 11e9606c382188be5e160d8a63e5fba8c9f52b14
Author: Prakash M <prakash@qualiantech.com>
Date: 29-09-2023 11:26:18
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/commit/11e9606c382188be5e160d8a63e5fba8c9f52b14 [^]

Related to ISSUE-53461: Added sample data for PM allowed to Mix
* This sample data is required for cypress test

---
A referencedata/sampledata/The_White_Valley_Group/OBPOS2_PM_FOR_MIX.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0155455)
hgbot (developer)
2023-10-04 08:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c4ad71d634d7464015146b20195a443a070f8ac3
Author: Prakash M <prakash@qualiantech.com>
Date: 03-10-2023 13:10:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c4ad71d634d7464015146b20195a443a070f8ac3 [^]

Related to ISSUE-53461: Added hook in Payments to allow extension from external modules
* There are some cases where data to be fetched based existing payment data for eg: pmForRefund

---
A src/org/openbravo/retail/posterminal/term/FetchTerminalPaymentDetailsPostHook.java
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0155456)
hgbot (developer)
2023-10-04 08:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1367 [^]
(0155894)
hgbot (developer)
2023-10-16 17:39

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2172 [^]
(0155895)
hgbot (developer)
2023-10-16 17:39

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/59 [^]

- Issue History
Date Modified Username Field Change
2023-09-15 05:44 prakashmurugesan88 New Issue
2023-09-15 05:44 prakashmurugesan88 Assigned To => prakashmurugesan88
2023-09-15 05:44 prakashmurugesan88 OBNetwork customer => No
2023-09-15 05:44 prakashmurugesan88 Triggers an Emergency Pack => No
2023-09-15 05:45 prakashmurugesan88 Status new => scheduled
2023-09-19 12:26 jarmendariz Relationship added caused by 0053489
2023-09-19 12:26 jarmendariz Relationship deleted caused by 0053489
2023-09-27 13:43 hgbot Merge Request Status => open
2023-09-27 13:43 hgbot Note Added: 0155298
2023-09-27 13:47 hgbot Note Added: 0155299
2023-09-29 11:42 hgbot Note Added: 0155383
2023-10-03 07:45 hgbot Merge Request Status open => approved
2023-10-04 08:10 hgbot Note Added: 0155442
2023-10-04 08:10 hgbot Note Added: 0155443
2023-10-04 08:10 hgbot Resolution open => fixed
2023-10-04 08:10 hgbot Status scheduled => closed
2023-10-04 08:10 hgbot Fixed in Version => 24Q1
2023-10-04 08:10 hgbot Note Added: 0155444
2023-10-04 08:10 hgbot Note Added: 0155445
2023-10-04 08:10 hgbot Note Added: 0155446
2023-10-04 08:10 hgbot Note Added: 0155447
2023-10-04 08:10 hgbot Note Added: 0155448
2023-10-04 08:10 hgbot Note Added: 0155449
2023-10-04 08:10 hgbot Note Added: 0155450
2023-10-04 08:10 hgbot Note Added: 0155451
2023-10-04 08:10 hgbot Note Added: 0155452
2023-10-04 08:10 hgbot Note Added: 0155453
2023-10-04 08:10 hgbot Note Added: 0155454
2023-10-04 08:10 hgbot Note Added: 0155455
2023-10-04 08:10 hgbot Note Added: 0155456
2023-10-16 17:39 hgbot Note Added: 0155894
2023-10-16 17:39 hgbot Note Added: 0155895

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker