0052937: Warehouse dropdown showing all warehouse in PO window

From 1bf8e6bfa8e625b43917d018932167c3fccba00f Mon Sep 17 00:00:00 2001 From: Atul Gaware <atul.gaware@openbravo.com> Date: Tue, 11 Jul 2023 23:21:26 +0530 Subject: [PATCH] Fixes BUG-0052937: Warehouse dropdown showing all warehouse in PO window **Added check whether warehouse organization is in the transaction org natural tree or not only in the case of non sales transaction --- src-db/database/sourcedata/OBUISEL_SELECTOR.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-db/database/sourcedata/OBUISEL_SELECTOR.xml b/src-db/database/sourcedata/OBUISEL_SELECTOR.xml index 20b7cb16673..a42b55861eb 100644 --- a/src-db/database/sourcedata/OBUISEL_SELECTOR.xml +++ b/src-db/database/sourcedata/OBUISEL_SELECTOR.xml @@ -1316,7 +1316,7 @@ where @additional_filters@  <NAME><![CDATA[On hand warehouse]]></NAME>  <AD_REFERENCE_ID><![CDATA[263693E51C7847BF90C897ADB830E2BB]]></AD_REFERENCE_ID>  <AD_TABLE_ID><![CDATA[190]]></AD_TABLE_ID> - <FILTER_EXPRESSION><![CDATA["( (" + OB.isSalesTransaction() + " = true and w.id in (select ow.warehouse.id from OrganizationWarehouse ow where ow.warehouse.id = w.id and ow.organization.id = \'" + OB.getParameters().get('inpadOrgId') + "\' )) or ((" + OB.isSalesTransaction() + " = false or \'"+OB.getWindowId()+"\' in (\'123271B9AD60469BAE8A924841456B63\'))))"]]></FILTER_EXPRESSION> + <FILTER_EXPRESSION><![CDATA["( ( (" + OB.isSalesTransaction() + " = true and w.id in (select ow.warehouse.id from OrganizationWarehouse ow where ow.warehouse.id = w.id and ow.organization.id = \'" + OB.getParameters().get('inpadOrgId') + "\' )) or ((" + OB.isSalesTransaction() + " = false or \'"+OB.getWindowId()+"\' in (\'123271B9AD60469BAE8A924841456B63\')))) and AD_ORG_ISINNATURALTREE(w.organization.id, \'" + OB.getParameters().get('inpadOrgId') + "\' , w.client.id) = \'Y\')"]]></FILTER_EXPRESSION>  <OBCLKER_TEMPLATE_ID><![CDATA[9314DE8599AD44E7BFC4CC50699042AB]]></OBCLKER_TEMPLATE_ID>  <ISACTIVE><![CDATA[Y]]></ISACTIVE>  <VALUEFIELD_ID><![CDATA[13CA3020FEB644D9AA51B4797181BB29]]></VALUEFIELD_ID> -- GitLab

Notes
(0152201) axelmercado (viewer) 2023-07-08 00:30	Hi team, we need the backport of this fix for the 3.0PR20Q1.1 version.

(0152346) hgbot (developer) 2023-07-11 19:55	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/938 [^]

(0152347) AtulOpenbravo (viewer) 2023-07-11 20:12	Test Plan - Login with Role F&B US Inc Procurement Role. This role has access to F&B US Inc, East Coast and West Coast Organzination. - Create Purchase Order with F&B US Inc Organization. - Check in Warehouse you have two options available i.e East Coast Warehouse and West Coast Warehouse. - Set Organization as F&B US East Coast Org, check that only organization available is East Coast Warehouse - Set Organziation as F&B US West Coast Org, check that only organization available is West Coast Warehouse - Create a new Warehouse in F&B Internation Group Organization i.e for eg Group Warehouse. - Create Purchase Order with F&B US Inc Organization. - Check in Warehouse you have three options available i.e Group Warehouse, East Coast Warehouse and West Coast Warehoue. - Set Organization as F&B US East Coast Org, check that only organization available are Group Warehouse and East Coast Warehouse - Set Organziation as F&B US West Coast Org, check that only organization available are Group Warehouse and West Coast Warehouse

(0152712) mtaal (viewer) 2023-07-20 08:52	Hello Axel, We don't do backports to such an old release. You can find the diff/patch to apply linked to this mantis. Please re-open if you have any further doubts.

(0152713) hgbot (developer) 2023-07-20 08:54	Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/938 [^]

Issue History
Date Modified	Username	Field	Change
2023-07-08 00:28	axelmercado	New Issue
2023-07-08 00:28	axelmercado	Assigned To	=> Triage Omni WMS
2023-07-08 00:28	axelmercado	OBNetwork customer	=> No
2023-07-08 00:28	axelmercado	Modules	=> Core
2023-07-08 00:28	axelmercado	Triggers an Emergency Pack	=> No
2023-07-08 00:30	axelmercado	Note Added: 0152201
2023-07-08 00:31	axelmercado	Relationship added	blocks 0049494
2023-07-11 19:55	hgbot	Merge Request Status	=> open
2023-07-11 19:55	hgbot	Note Added: 0152346
2023-07-11 20:06	AtulOpenbravo	Assigned To	Triage Omni WMS => AtulOpenbravo
2023-07-11 20:07	AtulOpenbravo	Status	new => scheduled
2023-07-11 20:12	AtulOpenbravo	Note Added: 0152347
2023-07-17 16:20	hgbot	Merge Request Status	open => approved
2023-07-20 08:51	mtaal	File Added: 938.diff
2023-07-20 08:51	mtaal	File Added: 938.patch
2023-07-20 08:52	mtaal	Note Added: 0152712
2023-07-20 08:52	mtaal	Status	scheduled => resolved
2023-07-20 08:52	mtaal	Fixed in SCM revision	=> .
2023-07-20 08:52	mtaal	Resolution	open => fixed
2023-07-20 08:52	mtaal	Status	resolved => closed
2023-07-20 08:54	hgbot	Note Added: 0152713