Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2023-05-08 10:192023-07-28 10:00
Reporterasier_perezView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052378: 'Order is not found' error message appears when switching between two existing orders

DescriptionWhen there are two new open orders, and we try to switch from one to the other, an error message appears, saying that the order is not found when it is.
Steps To Reproduce1) Log in POS2
2) Add any product to the current order
3) Click 'New Order'
4) Add any product to the new order
5) Click 'Switch Order'
6) Select the first order => The error message appears
TagsNo tags attached.
Attached Filespng file icon ordererror.png [^] (112,393 bytes) 2023-05-08 10:19

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0052342 closedcaristu POS2 No error feedback provided in the UI when some requests fail 
depends on backport 005309623Q3 closedjavierRodriguez POS2 'Order is not found' error message appears when switching between two existing orders 
has duplicate defect 0052827 closed POS2 [SALES] Error 'Order not found' when switching between draft tickets 
related to defect 0053425 closedranjith_qualiantech_com Retail Modules POS draft tickets should be validated in backoffice when completing/deleting the ticket 

-  Notes
(0149485)
hgbot (developer)
2023-05-09 12:21

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f8d199f4b85d19ced4efcff68bfd8c1169f51512
Author: Asier Perez <asier.perez@openbravo.com>
Date: 09-05-2023 12:21:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f8d199f4b85d19ced4efcff68bfd8c1169f51512 [^]

[cypress] Related to ISSUE-52378: Temporarily skipping failing tests until issue is solved

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/returnOrder.spec.js
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/RunAllSpecs/runAllSpecs.spec.js
---
(0149490)
hgbot (developer)
2023-05-09 13:13

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7b30877d55a908af634a47df1195f82fce7de1fb
Author: Asier Perez <asier.perez@openbravo.com>
Date: 09-05-2023 13:13:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7b30877d55a908af634a47df1195f82fce7de1fb [^]

[cypress] Related to ISSUE-52378: Temporarily skipping failing tests until issue is solved

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/returnOrder.spec.js
---
(0149522)
hgbot (developer)
2023-05-09 21:25

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1183 [^]
(0150237)
hgbot (developer)
2023-05-24 17:15

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1183 [^]
(0150238)
hgbot (developer)
2023-05-24 17:15

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 10a0e14e494339ad7d7be8fb195087d6e73bcffa
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 24-05-2023 15:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/10a0e14e494339ad7d7be8fb195087d6e73bcffa [^]

Fixed ISSUE-52378: Refactor duplicated order id sanity check

Instead of using paid receipt request to validate if an order id has been used for any other order,
a new web service is created to check it

Paid receipt web service fails if the order id which the application is trying to check does not exist.
This fail action makes the application to show an error as a notification.

For that reason, a new web service is created. This ws only fails due to technical errors. If the order exist,
the response has an exist parametes set to true, otherwise, false
- Create utility java class to find orders and avoid to have duplicated code
- Create new web service
- Refactor isOrderIdUsedInBackend function to use this new ws

---
A src/org/openbravo/retail/posterminal/CheckOrderExist.java
A src/org/openbravo/retail/posterminal/utility/OrderFinder.java
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0150239)
hgbot (developer)
2023-05-24 17:15

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ac5f5be31b054698ad3d6ccacd4fd78b3e0a5f62
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 24-05-2023 15:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ac5f5be31b054698ad3d6ccacd4fd78b3e0a5f62 [^]

Related to ISSUE-52378: Refactor json to send if something went wrong during execution

---
M src/org/openbravo/retail/posterminal/CheckOrderExist.java
---
(0150240)
hgbot (developer)
2023-05-24 17:15

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4a1409097e8dbe7e9a2f98bca8f5177ac4be8637
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 24-05-2023 15:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4a1409097e8dbe7e9a2f98bca8f5177ac4be8637 [^]

Related to ISSUE-52378: Create message to send on error

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0150241)
hgbot (developer)
2023-05-24 17:15

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7a008914ab97d7da3a96417d409bd77953259386
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 24-05-2023 15:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7a008914ab97d7da3a96417d409bd77953259386 [^]

 Related to ISSUE-52378: Improve log error message if something went wrong

---
M src/org/openbravo/retail/posterminal/CheckOrderExist.java
---
(0150303)
asier_perez (developer)
2023-05-25 17:33
edited on: 2023-05-25 17:35

 The fix should have been executed against try-pos2 since the error reported was causing some Cypress tests to fail. The fix is incomplete because it causes more errors on try-pos2. These errors can be seen here: https://builds.openbravo.com/job/mod-cypress/2712/ [^]

Once the fix is ready, but before merging it, skipped tests should be unskipped in order to check if everything is fixed. These tests are mainworkflows.spec and the last test of returnOrder.spec.
(0150309)
hgbot (developer)
2023-05-25 18:23

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b05834346e9f613038af31cc5215ebf64b216d7a
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 25-05-2023 18:23:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b05834346e9f613038af31cc5215ebf64b216d7a [^]

Revert " Related to ISSUE-52378: Improve log error message if something went wrong"

This reverts commit 7a008914ab97d7da3a96417d409bd77953259386.

Revert "Related to ISSUE-52378: Create message to send on error"

This reverts commit 4a1409097e8dbe7e9a2f98bca8f5177ac4be8637.

Revert "Related to ISSUE-52378: Refactor json to send if something went wrong during execution"

This reverts commit ac5f5be31b054698ad3d6ccacd4fd78b3e0a5f62.

Revert "Fixed ISSUE-52378: Refactor duplicated order id sanity check"

This reverts commit 10a0e14e494339ad7d7be8fb195087d6e73bcffa.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
R src/org/openbravo/retail/posterminal/CheckOrderExist.java
R src/org/openbravo/retail/posterminal/utility/OrderFinder.java
---
(0152158)
hgbot (developer)
2023-07-06 12:10

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1267 [^]
(0152197)
hgbot (developer)
2023-07-07 16:11

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1942 [^]
(0152369)
hgbot (developer)
2023-07-12 09:06

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1267 [^]
(0152370)
hgbot (developer)
2023-07-12 09:06

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ff6a0e77a508ca69fe0742fa1d3e1b10b465dcef
Author: Javier Ayala <javier.ayala@openbravo.com>
Date: 12-07-2023 07:06:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ff6a0e77a508ca69fe0742fa1d3e1b10b465dcef [^]

Fixed ISSUE-52378: Refactor of the sanity check to detect duplicated order ids

---
A src/org/openbravo/retail/posterminal/CheckOrderExist.java
A src/org/openbravo/retail/posterminal/utility/OrderFinder.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0152371)
hgbot (developer)
2023-07-12 09:07

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 502b24837d92c0c108fb93363d7646f1be5b52c8
Author: Javier Ayala <javier.ayala@openbravo.com>
Date: 12-07-2023 07:07:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/502b24837d92c0c108fb93363d7646f1be5b52c8 [^]

Related to ISSUE-52378: Adapt cypress to work with new Order Finder + Adapt order list test

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/returnOrder.spec.js
M web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/CancelAndReplace.json
M web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/CashUp.json
M web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/ReversePayment.json
M web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/ViewOrdersOfCustomer.json
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/backOfficeRequests.js
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/paidReceipts.int.spec.js
---
(0152372)
hgbot (developer)
2023-07-12 09:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1942 [^]
(0152375)
hgbot (developer)
2023-07-12 09:44

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1278 [^]
(0152376)
hgbot (developer)
2023-07-12 11:19

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 946de8c3870c821d9aa710b4042ac32cdce80eb4
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 12-07-2023 09:40:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/946de8c3870c821d9aa710b4042ac32cdce80eb4 [^]

related to ISSUE-52378: Use import and fix java format

---
M src/org/openbravo/retail/posterminal/utility/OrderFinder.java
---
(0152377)
hgbot (developer)
2023-07-12 11:19

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1278 [^]

- Issue History
Date Modified Username Field Change
2023-05-08 10:19 asier_perez New Issue
2023-05-08 10:19 asier_perez Assigned To => Retail
2023-05-08 10:19 asier_perez File Added: ordererror.png
2023-05-08 10:19 asier_perez Regression level => Automated tests
2023-05-08 10:19 asier_perez Regression date => 2023-05-05
2023-05-08 10:19 asier_perez Triggers an Emergency Pack => No
2023-05-08 10:37 asier_perez Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1080 [^]
2023-05-09 12:21 hgbot Note Added: 0149485
2023-05-09 12:23 asier_perez Regression level Automated tests =>
2023-05-09 12:23 asier_perez Regression date 2023-05-05 =>
2023-05-09 12:23 asier_perez Regression introduced by commit https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1080 [^] =>
2023-05-09 12:23 asier_perez Assigned To Retail => javierRodriguez
2023-05-09 12:23 asier_perez Steps to Reproduce Updated View Revisions
2023-05-09 12:25 asier_perez Description Updated View Revisions
2023-05-09 12:25 caristu Relationship added related to 0052342
2023-05-09 12:28 asier_perez Summary Order is not found when switching from an order to another => 'Order is not found' error message appears when switching between two existing orders
2023-05-09 12:29 asier_perez Steps to Reproduce Updated View Revisions
2023-05-09 13:13 hgbot Note Added: 0149490
2023-05-09 21:25 hgbot Note Added: 0149522
2023-05-18 10:48 javierRodriguez Status new => scheduled
2023-05-24 17:15 hgbot Resolution open => fixed
2023-05-24 17:15 hgbot Status scheduled => closed
2023-05-24 17:15 hgbot Note Added: 0150237
2023-05-24 17:15 hgbot Fixed in Version => RR23Q3
2023-05-24 17:15 hgbot Note Added: 0150238
2023-05-24 17:15 hgbot Note Added: 0150239
2023-05-24 17:15 hgbot Note Added: 0150240
2023-05-24 17:15 hgbot Note Added: 0150241
2023-05-25 17:33 asier_perez Note Added: 0150303
2023-05-25 17:33 asier_perez Status closed => new
2023-05-25 17:33 asier_perez Resolution fixed => open
2023-05-25 17:33 asier_perez Fixed in Version RR23Q3 =>
2023-05-25 17:35 asier_perez Note Edited: 0150303 View Revisions
2023-05-25 18:23 hgbot Resolution open => fixed
2023-05-25 18:23 hgbot Status new => closed
2023-05-25 18:23 hgbot Fixed in Version => RR23Q3
2023-05-25 18:23 hgbot Note Added: 0150309
2023-06-27 11:52 marvintm Status closed => new
2023-06-27 11:52 marvintm Resolution fixed => open
2023-06-27 11:52 marvintm Fixed in Version RR23Q3 =>
2023-06-27 11:52 marvintm Relationship added has duplicate 0052827
2023-06-27 15:43 hgbot Note Added: 0151673
2023-07-06 12:10 hgbot Note Added: 0152158
2023-07-07 16:11 hgbot Note Added: 0152197
2023-07-12 08:46 hgbot Note Added: 0152368
2023-07-12 09:05 guilleaer Note Deleted: 0151673
2023-07-12 09:05 guilleaer Note Deleted: 0152368
2023-07-12 09:06 hgbot Resolution open => fixed
2023-07-12 09:06 hgbot Status new => closed
2023-07-12 09:06 hgbot Note Added: 0152369
2023-07-12 09:06 hgbot Fixed in Version => RR23Q4
2023-07-12 09:06 hgbot Note Added: 0152370
2023-07-12 09:07 hgbot Note Added: 0152371
2023-07-12 09:07 hgbot Note Added: 0152372
2023-07-12 09:44 hgbot Note Added: 0152375
2023-07-12 11:19 hgbot Note Added: 0152376
2023-07-12 11:19 hgbot Note Added: 0152377
2023-07-28 10:00 guilleaer Status closed => new
2023-07-28 10:00 guilleaer Resolution fixed => open
2023-07-28 10:00 guilleaer Fixed in Version RR23Q4 =>
2023-07-28 10:00 guilleaer Status new => scheduled
2023-07-28 10:00 guilleaer Status scheduled => resolved
2023-07-28 10:00 guilleaer Resolution open => fixed
2023-07-28 10:00 guilleaer Status resolved => closed
2023-12-28 10:33 ranjith_qualiantech_com Relationship added related to 0053425

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker