0051473: The return button is not disabled if the OBPOS_ReturnLine preference is configured.

Description

For guatemala localization we need to disallow marking a line as to return,
The return button is not disabled if the OBPOS_ReturnLine preference is configured.

Steps To Reproduce

1- Configurate the preference OBPOS_ReturnLine in N
2- Try to return a line in the webPos

Proposed Solution

Attached diff with the solution

Tags

No tags attached.

Attached Files

returnline.diff [^] (560 bytes) 2023-01-26 16:21 [Show Content] [Hide Content]

--- a/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/actions/returnline.js	2023-01-26 15:02:46.672365000 +0100
+++ b/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/actions/returnline.js	2023-01-26 15:01:24.749696000 +0100
@@ -65,6 +65,10 @@
             return l.get('isEditable');
           });
 
+        active = OB.MobileApp.model.hasPermission(
+		            this.permission,
+		            true
+		          );
         return active;
       },
       command: async function(view) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0146235) ranjith_qualiantech_com (developer) 2023-02-03 09:52 edited on: 2023-02-10 06:23	In Backoffice, if logged role's Manual is checked, then "Return Line" button will be enabled/disabled based on preference in POS In Backoffice, if logged role's Manual is unchecked (Automatice Role), then "Return Line" button will be enabled always in POS

(0146409) marvintm (manager) 2023-02-13 08:04	The check is correctly done for manual roles. For automatic roles, permissions are always enabled. No change is actually required for this.

Issue History
Date Modified	Username	Field	Change
2023-01-26 16:21	sofidossant	New Issue
2023-01-26 16:21	sofidossant	Assigned To	=> Retail
2023-01-26 16:21	sofidossant	File Added: returnline.diff
2023-01-26 16:21	sofidossant	Triggers an Emergency Pack	=> No
2023-01-26 16:37	Practics	Issue Monitored: Practics
2023-01-30 13:19	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2023-02-03 09:52	ranjith_qualiantech_com	Note Added: 0146235
2023-02-10 06:23	ranjith_qualiantech_com	Note Edited: 0146235	View Revisions
2023-02-13 08:04	marvintm	Review Assigned To	=> marvintm
2023-02-13 08:04	marvintm	Note Added: 0146409
2023-02-13 08:04	marvintm	Status	new => closed
2023-02-13 08:04	marvintm	Resolution	open => no change required