Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051446 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2023-01-24 15:52 | 2023-01-26 12:36 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2022-08-29 | |||||||
| Regression introduced in release | RR22Q4 | |||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9b9213cd7d8c8c10553a4a4b2dfffe1256e970f6 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051446: Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs | |||||||
| Description | As part of this project: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/886 [^] new data was added to the cashup information, and the corresponding classes that process and save it were changed, and they are now expecting it to be there (and specifically, the "paymentMethods" object inside the cashupReportInformation data). However, if orders or cashups were generated while being offline, and then the customer is updated, this data will not be in the JSON, and the process will fail, generating records in Errors While Importing. This is not correct, the code should be smart and first check if the "paymentMethods" property exist, and if it doesn't the corresponding code to save it should not be executed. | |||||||
| Steps To Reproduce | - Create orders or cashups while being offline in a release before this development - Update to the newer version with this development, and then synchronize those orders - Verify that they generate Errors While importing | |||||||
| Proposed Solution | Handle the case of "paymentMethods" property not being present, by just ignoring this part of the code. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0145826) hgbot (developer) 2023-01-25 10:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1046 [^] |
|
(0145864) hgbot (developer) 2023-01-26 12:36 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1046 [^] |
|
(0145865) hgbot (developer) 2023-01-26 12:36 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: d97bf30fbd94638254d043a8f1d12184fe989e91 Author: Ranjith S R <ranjith@qualiantech.com> Date: 25-01-2023 14:50:45 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d97bf30fbd94638254d043a8f1d12184fe989e91 [^] Fixed ISSUE-51446: PaymentMethodCashup should updated with paymentMethods if exists * If paymentMethods is exists in cashup json, then it should be used to create the PaymentMethodCashup --- M src/org/openbravo/retail/posterminal/UpdateCashup.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-01-24 15:52 | marvintm | New Issue | |
| 2023-01-24 15:52 | marvintm | Assigned To | => Retail |
| 2023-01-24 15:52 | marvintm | OBNetwork customer | => No |
| 2023-01-24 15:52 | marvintm | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9b9213cd7d8c8c10553a4a4b2dfffe1256e970f6 [^] |
| 2023-01-24 15:52 | marvintm | Triggers an Emergency Pack | => No |
| 2023-01-24 15:53 | marvintm | Regression level | => Production - Confirmed Stable |
| 2023-01-24 15:53 | marvintm | Regression date | => 2022-08-29 |
| 2023-01-24 15:53 | marvintm | Regression introduced in release | => RR22Q4 |
| 2023-01-24 15:53 | marvintm | Status | new => scheduled |
| 2023-01-25 06:05 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2023-01-25 10:54 | hgbot | Merge Request Status | => open |
| 2023-01-25 10:54 | hgbot | Note Added: 0145826 | |
| 2023-01-26 12:36 | hgbot | Merge Request Status | open => approved |
| 2023-01-26 12:36 | hgbot | Resolution | open => fixed |
| 2023-01-26 12:36 | hgbot | Status | scheduled => closed |
| 2023-01-26 12:36 | hgbot | Note Added: 0145864 | |
| 2023-01-26 12:36 | hgbot | Fixed in Version | => RR23Q2 |
| 2023-01-26 12:36 | hgbot | Note Added: 0145865 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |