Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2023-01-24 15:522023-01-26 12:36
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - Confirmed Stable
Regression date2022-08-29
Regression introduced in releaseRR22Q4
Regression introduced by commit [^]
Triggers an Emergency PackNo

0051446: Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs

DescriptionAs part of this project: [^]

new data was added to the cashup information, and the corresponding classes that process and save it were changed, and they are now expecting it to be there (and specifically, the "paymentMethods" object inside the cashupReportInformation data).

However, if orders or cashups were generated while being offline, and then the customer is updated, this data will not be in the JSON, and the process will fail, generating records in Errors While Importing.

This is not correct, the code should be smart and first check if the "paymentMethods" property exist, and if it doesn't the corresponding code to save it should not be executed.
Steps To Reproduce- Create orders or cashups while being offline in a release before this development
- Update to the newer version with this development, and then synchronize those orders
- Verify that they generate Errors While importing
Proposed SolutionHandle the case of "paymentMethods" property not being present, by just ignoring this part of the code.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0051447RR22Q4.2 closedranjith_qualiantech_com Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs 
depends on backport 0051448RR23Q1 closedranjith_qualiantech_com Cashup update happening in orders and cashups is failing if the "paymentMethods" property is not defined, generating EWIs 

-  Notes
hgbot (developer)
2023-01-25 10:54

Merge Request created: [^]
hgbot (developer)
2023-01-26 12:36

Merge request merged: [^]
hgbot (developer)
2023-01-26 12:36

Directly closing issue as related merge request is already approved.

Repository: [^]
Changeset: d97bf30fbd94638254d043a8f1d12184fe989e91
Author: Ranjith S R <>
Date: 25-01-2023 14:50:45
URL: [^]

Fixed ISSUE-51446: PaymentMethodCashup should updated with paymentMethods if exists
* If paymentMethods is exists in cashup json, then it should be used
  to create the PaymentMethodCashup

M src/org/openbravo/retail/posterminal/

- Issue History
Date Modified Username Field Change
2023-01-24 15:52 marvintm New Issue
2023-01-24 15:52 marvintm Assigned To => Retail
2023-01-24 15:52 marvintm Regression introduced by commit => [^]
2023-01-24 15:52 marvintm Triggers an Emergency Pack => No
2023-01-24 15:53 marvintm Regression level => Production - Confirmed Stable
2023-01-24 15:53 marvintm Regression date => 2022-08-29
2023-01-24 15:53 marvintm Regression introduced in release => RR22Q4
2023-01-24 15:53 marvintm Status new => scheduled
2023-01-25 06:05 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-01-25 10:54 hgbot Note Added: 0145826
2023-01-26 12:36 hgbot Resolution open => fixed
2023-01-26 12:36 hgbot Status scheduled => closed
2023-01-26 12:36 hgbot Note Added: 0145864
2023-01-26 12:36 hgbot Fixed in Version => RR23Q2
2023-01-26 12:36 hgbot Note Added: 0145865

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker