Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051442
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Openbravo Business APImajorsometimes2023-01-23 13:382023-01-26 09:13
Reporterjorge-garciaView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0051442: Throw better error messages when importing a physical inventory through the API

DescriptionAs of now, if a "/ws/org.openbravo.api.ImportService/Inventory" request fails for any reason, this message is shown:

"Error while importing an item: null"

It is required to improve this message to indicate what is the actual error that occurs during the import process.
Steps To Reproduce1) Use this JSON body in Postman for "{{base_url}}/ws/org.openbravo.api.ImportService/Inventory" POST request:
  [
    {
      "client": "The White Valley Group",
      "organization": "Vall Blanca Store",
      "warehouse": "VBS/001",
      "date": "2022-04-21",
      "name": "2022-04-21",
      "description": "2022-04-21",
      "lines": [
        {
          "bin": "VBS/001 0-0-0",
          "product": "cacatua",
          "qty": 70,
          "uOM": "Unit"
        },
        {
          "bin": "VBS/001 0-0-0",
          "product": "WVG/B0017",
          "qty": 10,
          "uOM": "Unit"
        }
      ]
    }
  ]
2) Login in the ERP
3) Navigate to EDL Request
4) Search for last record created in error status
5) In Request Line, verify Error Message is "Error while importing an item: null" (this is wrong)
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
has duplicate feature request 0051037 newTriage Platform Conn Retail Modules inventory Import API V2: improved error handling 

-  Notes
(0145750)
jorge-garcia (developer)
2023-01-23 13:40

JIRA issue RM-2362[1]

[1]https://openbravo.atlassian.net/browse/RM-2362 [^]
(0145764)
hgbot (developer)
2023-01-23 14:39

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/120 [^]
(0145838)
hgbot (developer)
2023-01-25 14:59

Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/32 [^]
(0145849)
hgbot (developer)
2023-01-26 08:29

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 7ed6566d30ee0d59f7a0ec074a0ec513517f3e90
Author: Jorge García <jorge.garcia@openbravo.com>
Date: 26-01-2023 07:29:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/7ed6566d30ee0d59f7a0ec074a0ec513517f3e90 [^]

Fixes BUG-51442: Real exception is hidden when some Inventory import java mappings fail

---
M src/org/openbravo/api/mappings/inventoryline/ImportInventoryLineJavaPropertyMappingHandler.java
---
(0145850)
hgbot (developer)
2023-01-26 08:29

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/120 [^]
(0145852)
hgbot (developer)
2023-01-26 09:13

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 22c7d270c7753f93e66deffc6ed824d4c44a84df
Author: Jorge García <jorge.garcia@openbravo.com>
Date: 26-01-2023 08:13:20
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/22c7d270c7753f93e66deffc6ed824d4c44a84df [^]

Related to ISSUE-51442: Add tests to verify handled exceptions for inventory import

---
A src-test/data/importer/InventoryMissingBin.json
A src-test/data/importer/InventoryMissingProduct.json
M src-test/org/openbravo/api/tests/importer/ApiImportMappingBaseTest.java
M src-test/org/openbravo/api/tests/importer/ImportInventory.java
---
(0145853)
hgbot (developer)
2023-01-26 09:13

Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/32 [^]

- Issue History
Date Modified Username Field Change
2023-01-23 13:38 jorge-garcia New Issue
2023-01-23 13:38 jorge-garcia Assigned To => jorge-garcia
2023-01-23 13:40 jorge-garcia Note Added: 0145750
2023-01-23 13:40 jorge-garcia Summary RM2362 Throw better error messages when importing a physical inventory through the API => Throw better error messages when importing a physical inventory through the API
2023-01-23 13:42 jorge-garcia Status new => scheduled
2023-01-23 14:39 hgbot Note Added: 0145764
2023-01-24 13:21 rafaroda Relationship added has duplicate 0051037
2023-01-25 14:59 hgbot Note Added: 0145838
2023-01-26 08:29 hgbot Resolution open => fixed
2023-01-26 08:29 hgbot Status scheduled => closed
2023-01-26 08:29 hgbot Note Added: 0145849
2023-01-26 08:29 hgbot Note Added: 0145850
2023-01-26 09:13 hgbot Note Added: 0145852
2023-01-26 09:13 hgbot Note Added: 0145853


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker