Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051218
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Intercompany Documentsmajorhave not tried2022-12-21 10:432023-01-30 12:56
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0051218: Delete the "Internal Settlement" feature as it was never implemented for aprm (but only old-flow)

DescriptionThis module has an optional internal settlement feature which can be configured per c_doctype.

When using it c_settlement entries are inserted, c_debt_payment table is updated and c_settlement_post function is called.
All those 3 actions are related to the old-flow payment system.
Since 3.0 the aprm payment system is default and mandatory.
Using the aprm flow blocks using old-flow via trigger essentially disabling the feature.

The equivalent functionality for aprm in this module was requested in 2011 / issue 18018 but never implemented.

Given that 11 years has passed with that feature essentially being unusable remove it.
Steps To Reproducegrep -Iir settlement
Proposed SolutionRemove the old-flow integration from the module
Remove the now no longer implemented "Internal Settlement" feature
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0018018 closedpsanjuan Modules A "for APR" version of this module is required 
blocks design defect 0051144 newshuehner Openbravo ERP old-flow / pre-aprm: Remove code only useful when old-flow is still active 

-  Notes
(0144878)
hgbot (developer)
2022-12-21 10:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.interco/-/merge_requests/1 [^]
(0146022)
hgbot (developer)
2023-01-30 12:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.interco [^]
Changeset: 7a9cad0ee5b3f0715c30efd9c67b499563da0503
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 30-01-2023 11:56:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.interco/-/commit/7a9cad0ee5b3f0715c30efd9c67b499563da0503 [^]

Fixed ISSUE-51218: Remove internal settlement feature (only old-flow)

---
M src-db/database/model/functions/INTERCO_CREATE_INVOICE.xml
M src-db/database/model/modifiedTables/C_DOCTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODULE.xml
R src-db/database/model/functions/INTERCO_AUTO_SETTLEMENT.xml
R src-db/database/model/functions/INTERCO_COMMONPARENTORG.xml
R src-db/database/model/triggers/INTERCO_DOCTYPE_TRG.xml
R src-db/database/model/triggers/INTERCO_INTERCOMPANYORG_TRG.xml
---
(0146023)
hgbot (developer)
2023-01-30 12:56

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.interco/-/merge_requests/1 [^]

- Issue History
Date Modified Username Field Change
2022-12-21 10:43 shuehner New Issue
2022-12-21 10:43 shuehner Assigned To => Triage Omni OMS
2022-12-21 10:44 shuehner Relationship added related to 0018018
2022-12-21 10:45 shuehner Relationship added blocks 0051144
2022-12-21 10:58 hgbot Note Added: 0144878
2023-01-30 12:56 hgbot Resolution open => fixed
2023-01-30 12:56 hgbot Status new => closed
2023-01-30 12:56 hgbot Note Added: 0146022
2023-01-30 12:56 hgbot Note Added: 0146023
2023-01-30 12:56 aferraz Assigned To Triage Omni OMS => shuehner

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker