Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2022-12-12 10:202022-12-12 10:20
ReporteralostaleView Statuspublic 
Assigned ToTriage Platform Base 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0051095: OB.App.State.TerminalLog.addLog does not check preferences to send log

DescriptionThere are 2 client APIs to handle client logs:
1. OB.* (OB.error, OB.warn, it checks whether the log should be printed in console and/or sent to backend as terminal log
2. OB.App.State.TerminalLog.addLog: it sends the message to the backend as terminal log without further checks

The second option is a lower level API that should not be directly used by business logic code, but there are already some parts where it is used.
Steps To ReproduceN/A: this issue is technical related to code APIs.
Proposed SolutionDecide whether OB.App.State.TerminalLog.addLog should be usable from business logic code. Options:

1. Keep it as low level:
  * Review current usage from business logic code and change it to OB.*
  * Document in JSDoc it is a low level API so it shouldn't be used

2. Open it up to be usable from business logic code
  * As action preparation (?) check whether the message should be actually sent. Note this would double the checks that are already being executed in OB.*. The save parts might be moved to be executed only here.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0050505 scheduledguillermogil Post a message in TerminalLog when a Notification is shown to the user 

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2022-12-12 10:20 alostale New Issue
2022-12-12 10:20 alostale Assigned To => Triage Platform Base
2022-12-12 10:20 alostale Triggers an Emergency Pack => No
2022-12-12 10:20 alostale Relationship added related to 0050505

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker