Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051071 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2022-12-05 16:37 | 2022-12-14 11:36 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051071: Cleanup (delete) all modulescript not running on install and only required for updates from <16Q1 | |||||||
| Description | Issue 51068 blocks upgrades from versions older than 16Q1. With such updates no longer (directly) possible any code which runs on upgrades from <16Q1 is no longer needed. This issue is about the removal of modulescript from retail.pack (and modules contained in there) which: - Have executeOnInstall=false - ExecutionLimits.endversion<=16Q1 | |||||||
| Steps To Reproduce | 51068 change ensures that old version (before update) is at least 16Q1 (x.x.28207) Any modulescript defined with ExecutionLimits end-version before that (and moduleId of a module contained in backoffice repo) which is not also running during install.source => is no longer needed. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0144424) hgbot (developer) 2022-12-05 17:00 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1009 [^] |
|
(0144650) hgbot (developer) 2022-12-14 10:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: ab3be44517719daabe1133ad6593acbd8cea22bd Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 14-12-2022 09:19:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ab3be44517719daabe1133ad6593acbd8cea22bd [^] Related to ISSUE-51071: Remove obsolete old modulescripts from <14Q2 Those modulescripts will never be called anymore because they: - have executeOnInstall=false - ExecutionLimits.endversion<=14Q2 - Issue 51068 blocks direct updates from version <16Q1 --- R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue24147.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue25555.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixWrongPaymentScheduled.class R build/classes/org/openbravo/retail/posterminal/modulescript/InsertDiscountPreference.class R build/classes/org/openbravo/retail/posterminal/modulescript/InsertDiscountPreferenceData.class R build/classes/org/openbravo/retail/posterminal/modulescript/ModuleScriptPosterminal.class R src-db/database/model/functions/OBPOS_FIXISSUE24147.xml R src-db/database/model/functions/OBPOS_FIXISSUE25555.xml R src-db/database/model/functions/OBPOS_FIXWRONGPAYMENTSCHEDULED.xml R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue24147.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue25555.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixWrongPaymentScheduled.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InsertDiscountPreference.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/InsertDiscountPreference_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/ModuleScriptPosterminal.java --- |
|
(0144651) hgbot (developer) 2022-12-14 10:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: e285c92cf2affe52815fcb4a2b382a9aaa3a252c Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 14-12-2022 09:19:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e285c92cf2affe52815fcb4a2b382a9aaa3a252c [^] Related to ISSUE-51071: Remove obsolete old modulescripts from <15Q1 Those modulescripts will never be called anymore because they: - have executeOnInstall=false - ExecutionLimits.endversion<=15Q1 - Issue 51068 blocks direct updates from version <16Q1 --- R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue24409.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue24409Data.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue25963.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue25963Data.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444Data.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue27695.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue27695Data.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue28722.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue28722Data.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixErrorTableData.class R build/classes/org/openbravo/retail/posterminal/modulescript/FixErrorTableDataData.class R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue24409.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue24409_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue25963.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue25963_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue27695.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue27695_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue28722.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue28722_Data.xsql R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixErrorTableData.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixErrorTableData_Data.xsql --- |
|
(0144652) hgbot (developer) 2022-12-14 10:29 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 6ea70225885f01e4d1adbba6e78d52b3c1a48b26 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 14-12-2022 09:19:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6ea70225885f01e4d1adbba6e78d52b3c1a48b26 [^] Related to ISSUE-51071: Remove obsolete old modulescripts from <16Q1 Those modulescripts will never be called anymore because they: - have executeOnInstall=false - ExecutionLimits.endversion<=16Q1 - Issue 51068 blocks direct updates from version <16Q1 --- R build/classes/org/openbravo/retail/posterminal/modulescript/EnableTerminalAuthForNewInstances.class R build/classes/org/openbravo/retail/posterminal/modulescript/EnableTerminalAuthForNewInstancesData.class R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/EnableTerminalAuthForNewInstances.java R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/EnableTerminalAuthForNewInstances_Data.xsql --- |
|
(0144653) hgbot (developer) 2022-12-14 10:29 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1009 [^] |
|
(0144659) shuehner (administrator) 2022-12-14 10:31 |
Moving to right project, was wrongly reported in backoffice instead of WebPos |
|
(0144660) shuehner (administrator) 2022-12-14 10:32 |
Close manually. Was reported in wrong project which is why MR being merged didn't resolve/close that automatically. |
|
(0144667) hgbot (developer) 2022-12-14 11:21 |
Merge Request created: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/13 [^] |
|
(0144668) hgbot (developer) 2022-12-14 11:34 |
Repository: https://gitlab.com/openbravo/ci/mobile-api [^] Changeset: b843eb41a2de61f2d38ae4ac687a853390a83973 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 14-12-2022 11:18:38 URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/b843eb41a2de61f2d38ae4ac687a853390a83973 [^] Related to ISSUE-51071: Accept api change Those 3 pl-functions where just called from 3 modulescript removed in this issue. As the modulescripts are obsolete and removed those functions were obsolete as well and are removed. --- R model/modules/org.openbravo.retail.posterminal/src-db/database/model/functions/OBPOS_FIXISSUE24147.xml R model/modules/org.openbravo.retail.posterminal/src-db/database/model/functions/OBPOS_FIXISSUE25555.xml R model/modules/org.openbravo.retail.posterminal/src-db/database/model/functions/OBPOS_FIXWRONGPAYMENTSCHEDULED.xml --- |
|
(0144669) hgbot (developer) 2022-12-14 11:36 |
Merge request merged: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/13 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-12-05 16:37 | shuehner | New Issue | |
| 2022-12-05 16:37 | shuehner | Assigned To | => shuehner |
| 2022-12-05 16:37 | shuehner | Modules | => Core |
| 2022-12-05 16:37 | shuehner | Triggers an Emergency Pack | => No |
| 2022-12-05 16:37 | shuehner | Issue generated from | 0051069 |
| 2022-12-05 16:38 | shuehner | Relationship added | depends on 0051068 |
| 2022-12-05 17:00 | hgbot | Note Added: 0144424 | |
| 2022-12-14 10:29 | hgbot | Note Added: 0144650 | |
| 2022-12-14 10:29 | hgbot | Note Added: 0144651 | |
| 2022-12-14 10:29 | hgbot | Note Added: 0144652 | |
| 2022-12-14 10:29 | hgbot | Note Added: 0144653 | |
| 2022-12-14 10:31 | shuehner | Project | Openbravo ERP => Retail Modules |
| 2022-12-14 10:31 | shuehner | Note Added: 0144659 | |
| 2022-12-14 10:31 | shuehner | Category | A. Platform => Web POS |
| 2022-12-14 10:32 | shuehner | Status | new => scheduled |
| 2022-12-14 10:32 | shuehner | Status | scheduled => resolved |
| 2022-12-14 10:32 | shuehner | Fixed in Version | => RR23Q1 |
| 2022-12-14 10:32 | shuehner | Resolution | open => fixed |
| 2022-12-14 10:32 | shuehner | Note Added: 0144660 | |
| 2022-12-14 10:32 | shuehner | Status | resolved => closed |
| 2022-12-14 11:21 | hgbot | Note Added: 0144667 | |
| 2022-12-14 11:34 | hgbot | Note Added: 0144668 | |
| 2022-12-14 11:36 | hgbot | Note Added: 0144669 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |