Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051041
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Corecriticalhave not tried2022-11-30 14:302022-12-12 07:32
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051041: Ticket should not be completed if businessPartner is missing

DescriptionIn normal circumstances, businessPartner info is always present but sometimes it is not and this causes the ticket is not removed from the ticket list, even if the payment is completed and the ticket is synchronized with the backoffice, leading to have multiple tickets with the same ID.
Steps To Reproduce- Apply the attached diff to force this error to happen.
- Once logged in to POS2, execute the following in the Chrome developer tools console:

# OB.App.TerminalProperty.get('context').forceFailure = true

- Refresh masterdata
- Add a product to the ticket and complete it. Notice that the ticket is saved in backoffice, but it is still available in the Terminal
TagsNo tags attached.
Attached Filesdiff file icon reproducer-51041.diff [^] (640 bytes) 2022-11-30 14:31 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0050049 closedradhakrishnan POS1 and POS2 return different type of messages for the same error. 
depends on backport 005105722Q4.1 closedjarmendariz Ticket should not be completed if businessPartner is missing 
depends on backport 005105822Q3.3 closedjarmendariz Ticket should not be completed if businessPartner is missing 

-  Notes
(0144255)
hgbot (developer)
2022-11-30 15:27

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1002 [^]
(0144256)
hgbot (developer)
2022-11-30 15:29

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1395 [^]
(0144365)
hgbot (developer)
2022-12-02 13:12

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1002 [^]
(0144366)
hgbot (developer)
2022-12-02 13:12

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f43b2c837ebdb3fcaf8b4020081556092558bda9
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 11:51:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f43b2c837ebdb3fcaf8b4020081556092558bda9 [^]

Related to ISSUE-51041: Throwing an error when attempting to create a new ticket with no business partner

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/TicketListUtils.js
---
(0144369)
hgbot (developer)
2022-12-02 13:46

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1395 [^]
(0144370)
hgbot (developer)
2022-12-02 13:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e0b34fe1a1191ce8026c4f9f770a967764d87fd8
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 11:51:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e0b34fe1a1191ce8026c4f9f770a967764d87fd8 [^]

Fixed ISSUE-51041: Adding action preparation to ensure ticket is not completed if BP is missing

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0144498)
hgbot (developer)
2022-12-11 16:32

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1013 [^]
(0144502)
hgbot (developer)
2022-12-12 07:32

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4d42157834c720985bd153c2cea09ed63687a288
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 11-12-2022 20:58:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4d42157834c720985bd153c2cea09ed63687a288 [^]

Related to ISSUE-51041: BP Info should be updated before window is loaded
* BP Info should be updated in OBPOS_LoadPOSWindow hook
  before loading window

---
A web/org.openbravo.retail.posterminal/js/hook/loadPOSWindow.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0144503)
hgbot (developer)
2022-12-12 07:32

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1013 [^]

- Issue History
Date Modified Username Field Change
2022-11-30 14:30 jarmendariz New Issue
2022-11-30 14:30 jarmendariz Assigned To => jarmendariz
2022-11-30 14:30 jarmendariz Triggers an Emergency Pack => No
2022-11-30 14:31 jarmendariz File Added: reproducer-51041.diff
2022-11-30 14:32 jarmendariz Relationship added related to 0050049
2022-11-30 15:27 hgbot Note Added: 0144255
2022-11-30 15:29 hgbot Note Added: 0144256
2022-12-02 12:20 jarmendariz Status new => scheduled
2022-12-02 13:12 hgbot Note Added: 0144365
2022-12-02 13:12 hgbot Note Added: 0144366
2022-12-02 13:46 hgbot Note Added: 0144369
2022-12-02 13:46 hgbot Resolution open => fixed
2022-12-02 13:46 hgbot Status scheduled => closed
2022-12-02 13:46 hgbot Fixed in Version => 23Q1
2022-12-02 13:46 hgbot Note Added: 0144370
2022-12-11 16:32 hgbot Note Added: 0144498
2022-12-12 07:32 hgbot Note Added: 0144502
2022-12-12 07:32 hgbot Note Added: 0144503
2024-02-21 13:14 ranjith_qualiantech_com Relationship added causes 0054593
2024-02-21 14:10 ranjith_qualiantech_com Relationship deleted causes 0054593


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker