Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050976
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2022-11-23 10:102023-02-19 09:30
ReporternoemierousselView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050976: [Promo] - Buy X Get Y - Number of gifts is multiplied by number of eligible products bought even if Max Y = 1

DescriptionWhen configuring Buy X Get Y, the number of gifts is multiplied by number of eligible products bought even if Max Y = 1. Moreover, when adding several gifts to the ticket, only one is free.
Steps To ReproduceStep 1: Definition of promotion

                Name: Test number of gift multiplied

                Type: Buy X get Y as a gift

               Subtype: Here Buy Any X Get Any Y (But this bug concerns the 4
               subtypes)

               Application Method: Optional

               Add in the list of products in "Product subtab":

               Product: “Alpine poles “

               Product: “Blue Coat “

               Gift Product: “Beer 0.5L”

X = 1
Min Y = 1
Max Y = 1

Step 2: Add one eligible product to the ticket, only one gift can be selected among the 3 possible gifts defined => Result OK

Step 3 : Add a second eligible product to the ticket --> KO
The pop up indicates that 2 eligible products can be selected instead of 1 (number of gifts is equal to the number of eligible products bought)
When we select only one gift and click on Apply, error message is displayed

Step 4: We select 2 gifts and click on Apply --> KO both gifts are added to the ticket, but only one is free
Proposed SolutionExpected behavior : If max Y = 1, only one gift can be offered to the client, even if he buys several eligible products - we expect the same pop up and behavior as when only one eligible product is bought (requirement 3 in the specification)
TagsFASH
Attached Filespng file icon gift not free.png [^] (52,141 bytes) 2022-11-23 10:10

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0144728)
hgbot (developer)
2022-12-15 09:10

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/79 [^]
(0146726)
hgbot (developer)
2023-02-19 09:30

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/79 [^]
(0146727)
hgbot (developer)
2023-02-19 09:30

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: d505d79ce62e71f12e09bb16b22920fc58d024a7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 14-12-2022 13:41:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/d505d79ce62e71f12e09bb16b22920fc58d024a7 [^]

Fixed ISSUE-50976: Discount X units should be used to calculated required gift qty
* Gift qty should be maximum of X Units if BuyXGetYasGift configured

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---

- Issue History
Date Modified Username Field Change
2022-11-23 10:10 noemieroussel New Issue
2022-11-23 10:10 noemieroussel Assigned To => Retail
2022-11-23 10:10 noemieroussel File Added: gift not free.png
2022-11-23 10:10 noemieroussel OBNetwork customer => Gold
2022-11-23 10:10 noemieroussel Triggers an Emergency Pack => No
2022-11-23 10:11 noemieroussel Tag Attached: FASH
2022-11-23 11:03 rafaroda Priority high => urgent
2022-12-12 12:39 noemieroussel Type design defect => defect
2022-12-13 10:36 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2022-12-13 10:36 ranjith_qualiantech_com Status new => scheduled
2022-12-15 09:10 hgbot Merge Request Status => open
2022-12-15 09:10 hgbot Note Added: 0144728
2023-02-19 09:30 hgbot Merge Request Status open => approved
2023-02-19 09:30 hgbot Note Added: 0146726
2023-02-19 09:30 hgbot Resolution open => fixed
2023-02-19 09:30 hgbot Status scheduled => closed
2023-02-19 09:30 hgbot Fixed in Version => RR23Q1
2023-02-19 09:30 hgbot Note Added: 0146727

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker