Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050891
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminorhave not tried2022-11-14 17:412022-11-17 12:11
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050891: Check and remove obsolete CostingMigration related modulescript

DescriptionIssue 41421 from 20Q1 deleted the old costing engine + the code to migrate to the new engine.
Instead it added a new buildvalidation to validate the migration was done before updating.

This commit:
https://gitlab.com/openbravo/product/openbravo/-/commit/5d32b264a91e3b3278588a84d3b101ac97e03771 [^]

Document that the modeulscript InitializeCostingMigrationPreference was deleted.
However it only deleted the .java + .xsql source files but left the compiled .class file present.
So that modulescript is still technically there and running today.

Probably just leftover to validate and remove as it was intended in issue 41421.
Steps To Reproducefind . -name InitializeCostingMigrationPreference*
- Notice 2 .class file are found but none of the related sources (.java + .xsql) are present
- Look at commit referenced above
Proposed SolutionDouble check original 41421 intention and remove the leftover of the modulescript.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 00414213.0PR20Q1 closedAtulOpenbravo Unsupport legacy cost engine 
related to feature request 0030706 new Remove or update modulescripts which need to be executed always 

-  Notes
(0143597)
shuehner (administrator)
2022-11-14 17:43

 Issue 30706 references the modulescript by test to be reviewed.
If it is being deleted in this issue 30706 should be updated to remove the reference.
(0143725)
hgbot (developer)
2022-11-16 16:30

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/766 [^]
(0143777)
hgbot (developer)
2022-11-17 12:09

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/766 [^]
(0143778)
hgbot (developer)
2022-11-17 12:09

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 65d14ea6e2f6aaa9493daa0730c4edb50c5c0b57
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 17-11-2022 11:09:51
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/65d14ea6e2f6aaa9493daa0730c4edb50c5c0b57 [^]

Fixes ISSUE-50891. Remove obsolete InitializeCostingMigrationPreference

---
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeCostingMigrationPreference.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeCostingMigrationPreferenceData.class
---

- Issue History
Date Modified Username Field Change
2022-11-14 17:41 shuehner New Issue
2022-11-14 17:41 shuehner Assigned To => Triage Omni WMS
2022-11-14 17:41 shuehner Modules => Core
2022-11-14 17:41 shuehner Triggers an Emergency Pack => No
2022-11-14 17:41 shuehner Relationship added related to 0041421
2022-11-14 17:43 shuehner Note Added: 0143597
2022-11-14 17:44 shuehner Relationship added related to 0030706
2022-11-14 18:05 vmromanos Assigned To Triage Omni WMS => Triage Omni OMS
2022-11-16 16:30 hgbot Note Added: 0143725
2022-11-17 12:09 hgbot Note Added: 0143777
2022-11-17 12:09 hgbot Resolution open => fixed
2022-11-17 12:09 hgbot Status new => closed
2022-11-17 12:09 hgbot Fixed in Version => PR23Q1
2022-11-17 12:09 hgbot Note Added: 0143778
2022-11-17 12:11 aferraz Assigned To Triage Omni OMS => shuehner

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker