Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. PlatformtrivialN/A2008-09-17 16:562009-05-22 19:34
ReportergorkaionView Statuspublic 
Assigned Toiciordia 
PrioritylowResolutionopenFixed in Version
StatusacknowledgedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0005083: Merge advisePopUp and bdErrorGeneralPopUp methods

DescriptionIn 'org.openbravo.base.secureApp.HttpSecureAppServlet' class there are these 2 methods (lines 396 and 421) that could be merged into one.

They are used to open a popup window with just a message box. At this moment the main difference is that 'bdErrorGeneralPopUp' always uses the ERROR type messageBox whatever message is displayed, while in 'advisePopUp' you can set the type.

There is also another trivial difference in the html template where the bdErrorGeneralPopUp uses a window logo icon of error and the other method uses the info icon.

The other differences can be defined as bugs.

I think that the bdErrorGeneralPopUp is not necessary and we should use only the advisePopUp method. That way we can also remove the correspondent templates and only maintain one.
TagsClean-up, ReleaseCandidate
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0005085 closedHennadzi Bad usage of advisePopUp 

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2008-09-17 16:56 gorkaion New Issue
2008-09-17 16:56 gorkaion Assigned To => cromero
2008-09-17 16:56 gorkaion sf_bug_id 0 => 2116308
2008-09-17 16:56 gorkaion Regression testing => No
2008-09-17 17:58 rafaroda Relationship added related to 0005085
2008-11-10 13:10 cromero Assigned To cromero => pjuvara
2008-11-16 21:53 pjuvara Tag Attached: Clean-up
2008-11-16 21:53 pjuvara Tag Attached: ReleaseCandidate
2008-11-16 21:53 pjuvara Status new => acknowledged
2009-05-22 19:34 pjuvara Assigned To pjuvara => iciordia

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker