Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||
ID | |||||||||||
0005083 | |||||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||||
feature request | [Openbravo ERP] A. Platform | trivial | N/A | 2008-09-17 16:56 | 2009-05-22 19:34 | ||||||
Reporter | gorkaion | View Status | public | ||||||||
Assigned To | iciordia | ||||||||||
Priority | low | Resolution | open | Fixed in Version | |||||||
Status | acknowledged | Fix in branch | Fixed in SCM revision | ||||||||
Projection | none | ETA | none | Target Version | |||||||
OS | Any | Database | Any | Java version | |||||||
OS Version | Database version | Ant version | |||||||||
Product Version | SCM revision | ||||||||||
Review Assigned To | |||||||||||
Web browser | |||||||||||
Modules | Core | ||||||||||
Regression level | |||||||||||
Regression date | |||||||||||
Regression introduced in release | |||||||||||
Regression introduced by commit | |||||||||||
Triggers an Emergency Pack | No | ||||||||||
Summary | 0005083: Merge advisePopUp and bdErrorGeneralPopUp methods | ||||||||||
Description | In 'org.openbravo.base.secureApp.HttpSecureAppServlet' class there are these 2 methods (lines 396 and 421) that could be merged into one. They are used to open a popup window with just a message box. At this moment the main difference is that 'bdErrorGeneralPopUp' always uses the ERROR type messageBox whatever message is displayed, while in 'advisePopUp' you can set the type. There is also another trivial difference in the html template where the bdErrorGeneralPopUp uses a window logo icon of error and the other method uses the info icon. The other differences can be defined as bugs. I think that the bdErrorGeneralPopUp is not necessary and we should use only the advisePopUp method. That way we can also remove the correspondent templates and only maintain one. | ||||||||||
Tags | Clean-up, ReleaseCandidate | ||||||||||
Attached Files | |||||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Issue History | |||
Date Modified | Username | Field | Change |
2008-09-17 16:56 | gorkaion | New Issue | |
2008-09-17 16:56 | gorkaion | Assigned To | => cromero |
2008-09-17 16:56 | gorkaion | sf_bug_id | 0 => 2116308 |
2008-09-17 16:56 | gorkaion | Regression testing | => No |
2008-09-17 17:58 | rafaroda | Relationship added | related to 0005085 |
2008-11-10 13:10 | cromero | Assigned To | cromero => pjuvara |
2008-11-16 21:53 | pjuvara | Tag Attached: Clean-up | |
2008-11-16 21:53 | pjuvara | Tag Attached: ReleaseCandidate | |
2008-11-16 21:53 | pjuvara | Status | new => acknowledged |
2009-05-22 19:34 | pjuvara | Assigned To | pjuvara => iciordia |
Copyright © 2000 - 2009 MantisBT Group |