0050288: Product characteristics values are not managing well incremental refresh. Not deleted when disactivated

Description

Product characteristics values are not managing well incremental refresh. Not deleted when disactivated

Steps To Reproduce

Login in poc with some prod characteristics value configured
check table in indexdb
go to backoffice and disable any value
Como back to POs and refresh indexdb

De-activated record is still there

Proposed Solution

Attached propossed diff to remove active for query filter

Tags

No tags attached.

Attached Files

diffChValues.diff [^] (1,121 bytes) 2022-09-20 00:03 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/master/CharacteristicValue.java b/src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
index 7bce28d40..05ac2619a 100644
--- a/src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
+++ b/src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
@@ -123,7 +123,6 @@ public class CharacteristicValue extends MasterDataProcessHQLQuery {
     query.append(" and $hqlCriteria");
     query.append(" and cv.$readableSimpleClientCriteria");
     query.append(" and ch.obposUseonwebpos = true");
-    query.append(" and cv.active = true");
     if (isCrossStoreSearch) {
       query.append(" and exists (");
       query.append("   select 1");
@@ -165,7 +164,6 @@ public class CharacteristicValue extends MasterDataProcessHQLQuery {
     query.append(" and $hqlCriteria");
     query.append(" and cv.$readableSimpleClientCriteria");
     query.append(" and ch.obposUseonwebpos = true");
-    query.append(" and cv.active = true");
     if (isCrossStoreSearch) {
       query.append(" and exists (");
       query.append("   select 1");

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0141469) hcurbelo (reporter) 2022-09-29 05:41 edited on: 2022-09-29 17:24	I tried test some variant. If remove the active filter from query in class CharacteristicValue, all work fine. Think that the filter "active" in query don't have sense. The data only set into the model if the values that are actives. The propossed diff to remove active for query filter is the correct.

(0141513) hgbot (developer) 2022-09-29 16:32	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/943 [^]

(0141589) hgbot (developer) 2022-10-03 18:25	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/943 [^]

Issue History
Date Modified	Username	Field	Change
2022-09-20 00:03	guilleaer	New Issue
2022-09-20 00:03	guilleaer	Assigned To	=> Retail
2022-09-20 00:03	guilleaer	File Added: diffChValues.diff
2022-09-20 00:03	guilleaer	Triggers an Emergency Pack	=> No
2022-09-26 18:42	gorka_gil	Assigned To	Retail => hcurbelo
2022-09-29 05:41	hcurbelo	Note Added: 0141469
2022-09-29 16:08	hcurbelo	Note Edited: 0141469	View Revisions
2022-09-29 16:32	hgbot	Note Added: 0141513
2022-09-29 17:24	hcurbelo	Note Edited: 0141469	View Revisions
2022-10-03 18:25	hgbot	Note Added: 0141589
2022-10-04 14:05	gorka_gil	Status	new => scheduled
2022-10-04 14:06	gorka_gil	Status	scheduled => resolved
2022-10-04 14:06	gorka_gil	Fixed in Version	=> RR23Q1
2022-10-04 14:06	gorka_gil	Resolution	open => fixed
2022-10-04 14:06	gorka_gil	Review Assigned To	=> gorka_gil
2022-10-04 14:06	gorka_gil	Status	resolved => closed