0050247: Prevent BO call when scan product to improve performance

Description

When scanning a barcode we are doing a call to backoffice, to check if there is one receipt with the same Document Number that code scanned. If it exists, then the Sales Order is loaded so we want to prevent the call to the backoffice when the code scanned does not seems a document number.

Steps To Reproduce

Scan a code and enter. Now check in network tab calls done to PaidReceiptsFilter.

Please find attached fix.

Tags

No tags attached.

Attached Files

89a129b8504f4670c0b5052c228750485df17ae4.diff [^] (2,760 bytes) 2022-09-14 16:30 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.merge.tickets/js/barcode-hook.js b/web/org.openbravo.retail.merge.tickets/js/barcode-hook.js
index 333cfddf1dd9fe7400e856d41fb9180936d4e6c9..739d678db91389ca310b4656505332b84b5bf38d 100644
--- a/web/org.openbravo.retail.merge.tickets/js/barcode-hook.js
+++ b/web/org.openbravo.retail.merge.tickets/js/barcode-hook.js
@@ -39,32 +39,36 @@ OB.UTIL.HookManager.registerHook('OBPOS_BarcodeSearch', function(
     }
   };
 
-  OB.OBMTR.findReceipt(
-    args.code,
-    function(receipt) {
-      if (OB.UTIL.isNullOrUndefined(receipt)) {
-        errorOperation();
-        return;
-      }
-      if (
-        receipt.get('obmtrSelected') ||
-        receipt.get('documentStatus') === 'CL' ||
-        receipt.get('iscancelled')
-      ) {
-        const errorMsg = receipt.get('obmtrSelected')
-          ? OB.I18N.getLabel('OBMTR_ReceiptAlreadyMerged', [
-              receipt.get('documentNo')
-            ])
-          : OB.I18N.getLabel('OBMTR_MergeClosedOrderError');
-        OB.UTIL.showConfirmation.display(
-          OB.I18N.getLabel('OBMOBC_Error'),
-          errorMsg
-        );
-        return;
-      }
+  if (OB.OBMTR.isReceiptDocumentNumber(args.code)) {
+    OB.OBMTR.findReceipt(
+      args.code,
+      function(receipt) {
+        if (OB.UTIL.isNullOrUndefined(receipt)) {
+          errorOperation();
+          return;
+        }
+        if (
+          receipt.get('obmtrSelected') ||
+          receipt.get('documentStatus') === 'CL' ||
+          receipt.get('iscancelled')
+        ) {
+          const errorMsg = receipt.get('obmtrSelected')
+            ? OB.I18N.getLabel('OBMTR_ReceiptAlreadyMerged', [
+                receipt.get('documentNo')
+              ])
+            : OB.I18N.getLabel('OBMTR_MergeClosedOrderError');
+          OB.UTIL.showConfirmation.display(
+            OB.I18N.getLabel('OBMOBC_Error'),
+            errorMsg
+          );
+          return;
+        }
 
-      OB.OBMTR.loadAndMergeReceipt(receipt);
-    },
-    errorOperation
-  );
+        OB.OBMTR.loadAndMergeReceipt(receipt);
+      },
+      errorOperation
+    );
+  } else {
+    OB.UTIL.HookManager.callbackExecutor(args, callbacks);
+  }
 });
diff --git a/web/org.openbravo.retail.merge.tickets/js/utils.js b/web/org.openbravo.retail.merge.tickets/js/utils.js
index 427a69be6c5f016e602edd447306cd42cf24d31b..06db44e6bdf6c56966f73a4c81e82454b7939446 100644
--- a/web/org.openbravo.retail.merge.tickets/js/utils.js
+++ b/web/org.openbravo.retail.merge.tickets/js/utils.js
@@ -604,3 +604,7 @@ OB.OBMTR.isAnonymousCustomer = function(businessPartnerId) {
 OB.OBMTR.isScannedReceiptCode = function(code) {
   return false;
 };
+
+OB.OBMTR.isReceiptDocumentNumber = function() {
+  return true;
+};

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0141306) ranjith_qualiantech_com (viewer) 2022-09-22 16:14	Its feature request and will be included in coming days

Issue History
Date Modified	Username	Field	Change
2022-09-14 16:30	kousalya_r	New Issue
2022-09-14 16:30	kousalya_r	Assigned To	=> Retail
2022-09-14 16:30	kousalya_r	File Added: 89a129b8504f4670c0b5052c228750485df17ae4.diff
2022-09-14 16:30	kousalya_r	OBNetwork customer	=> OBPS
2022-09-14 16:30	kousalya_r	Support ticket	=> 48919
2022-09-14 16:30	kousalya_r	Triggers an Emergency Pack	=> No
2022-09-20 11:41	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2022-09-22 16:13	ranjith_qualiantech_com	Assigned To	ranjith_qualiantech_com => Retail
2022-09-22 16:14	ranjith_qualiantech_com	Note Added: 0141306
2024-06-17 08:32	guillermogil	Review Assigned To	=> guillermogil
2024-06-17 08:32	guillermogil	Status	new => closed
2024-06-17 08:32	guillermogil	Resolution	open => invalid