Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0049640 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [POS2] POS | minor | have not tried | 2022-06-23 16:01 | 2022-07-04 16:58 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | ruben_jimenez | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | mtaal | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0049640: Allow pager codes of 1 or 2 digits and remove preceeding zeros | |||||||
Description | Two changes: - allow pager codes which are only 1 or 2 digits - if a pager starts with a zero(s), remove the zeros: 05 --> 5 078 --> 78 008 --> 8 12340889 -> 88 | |||||||
Steps To Reproduce | See pager code | |||||||
Proposed Solution | Change the validation logic for pager codes in the customer pager handler | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0138792) mtaal (manager) 2022-06-27 17:09 |
The code which is responsible for validation: https://gitlab.com/obcustomers/AGAP/com.openbravo.flunch.integration.beeper/-/blob/master/web-jspack/com.openbravo.flunch.integration.beeper/src/FlunchPagerDeliveryControlMethod.js#L76 [^] To do the conversion of 001 to 1 and 078 to 78 additional logic needs to be added to the same file in different places. |
(0138840) ruben_jimenez (developer) 2022-06-29 11:44 |
Pager code 0 or 00 or 000 is illegal. So pager code starting with 1234000 is also illegal. |
(0138843) hgbot (developer) 2022-06-29 13:04 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1054 [^] |
(0138920) hgbot (developer) 2022-07-01 12:53 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 90b280a4d775cef34ca0b6513eabf057dd22df1b Author: Ruben Jimenez <ruben.jimenez@openbravo.com> Date: 01-07-2022 10:53:52 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/90b280a4d775cef34ca0b6513eabf057dd22df1b [^] Related to ISSUE-49640: Checked pager number before set to remove preceeding zeros --- M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/BaseScanPagerKeypad.jsx M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/ScanPagerProductKeypad.jsx M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerUtils.js --- |
(0138921) hgbot (developer) 2022-07-01 12:53 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1054 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2022-06-23 16:01 | mtaal | New Issue | |
2022-06-23 16:01 | mtaal | Assigned To | => mtaal |
2022-06-23 16:01 | mtaal | Triggers an Emergency Pack | => No |
2022-06-26 18:59 | guilleaer | Status | new => scheduled |
2022-06-27 16:58 | mtaal | Assigned To | mtaal => ruben_jimenez |
2022-06-27 17:00 | mtaal | Description Updated | View Revisions |
2022-06-27 17:09 | mtaal | Note Added: 0138792 | |
2022-06-29 11:44 | ruben_jimenez | Note Added: 0138840 | |
2022-06-29 13:04 | hgbot | Note Added: 0138843 | |
2022-07-01 12:53 | hgbot | Note Added: 0138920 | |
2022-07-01 12:53 | hgbot | Note Added: 0138921 | |
2022-07-04 16:58 | guilleaer | Status | scheduled => acknowledged |
2022-07-04 16:58 | guilleaer | Status | acknowledged => scheduled |
2022-07-04 16:58 | guilleaer | Status | scheduled => resolved |
2022-07-04 16:58 | guilleaer | Resolution | open => fixed |
2022-07-04 16:58 | guilleaer | Review Assigned To | => mtaal |
2022-07-04 16:58 | guilleaer | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |