Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049453 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Modules] Discounts Engine for Backend | minor | have not tried | 2022-05-31 16:33 | 2022-06-15 13:21 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0049453: Support extending the discount rule filtering query used by the Discounts web service | |||||||
| Description | It would be nice if the query that filters the candidate discount rules to be used by the Discounts web service could be extended to add custom filters. | |||||||
| Steps To Reproduce | . | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0137902) hgbot (developer) 2022-05-31 16:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/17 [^] |
|
(0138112) hgbot (developer) 2022-06-07 13:57 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/55 [^] |
|
(0138367) hgbot (developer) 2022-06-15 13:21 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^] Changeset: 8f51c80580ca9a50d7dd9138ed986e43dcea0b7d Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 07-06-2022 14:01:38 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/8f51c80580ca9a50d7dd9138ed986e43dcea0b7d [^] fixes ISSUE-49453: extensible filtering in the applicable discount rule query --- M src/org/openbravo/discounts/engine/DiscountJSExecutor.java --- |
|
(0138368) hgbot (developer) 2022-06-15 13:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^] Changeset: 7cde17045d57f1d998c982938abadf7ca0910ec9 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 07-06-2022 15:37:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/7cde17045d57f1d998c982938abadf7ca0910ec9 [^] related to ISSUE-49453: code improvements - Can directly stream the query results - Avoid problems that may be caused because of SimpleDateFormat not being thread-safe --- M src/org/openbravo/discounts/engine/DiscountJSExecutor.java --- |
|
(0138369) hgbot (developer) 2022-06-15 13:21 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/17 [^] |
|
(0138370) hgbot (developer) 2022-06-15 13:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 01eb82685ffb6d0ea5b2eeeea8530b2239a0b9f7 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 07-06-2022 13:54:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/01eb82685ffb6d0ea5b2eeeea8530b2239a0b9f7 [^] related to ISSUE-49453: DiscountRuleFilter definition --- A src/org/openbravo/retail/discounts/DiscountRuleFilter.java A src/org/openbravo/retail/discounts/DiscountRuleFilterProvider.java --- |
|
(0138371) hgbot (developer) 2022-06-15 13:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 2eac2dde81d63363782eb3709419adb167c9cd47 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 08-06-2022 14:00:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/2eac2dde81d63363782eb3709419adb167c9cd47 [^] related to ISSUE-49453: support setting ticket date on tests --- M src-test/org/openbravo/retail/discounts/test/base/model/Ticket.java --- |
|
(0138372) hgbot (developer) 2022-06-15 13:21 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/55 [^] |
|
(0138373) hgbot (developer) 2022-06-15 13:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 2103e2872a63415ac0551b53107fc325fccf069e Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 13-06-2022 16:56:37 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/2103e2872a63415ac0551b53107fc325fccf069e [^] related to ISSUE-49453: fix warn in javadoc --- M src-test/org/openbravo/retail/discounts/test/base/model/ExternalBusinessPartner.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-05-31 16:33 | caristu | New Issue | |
| 2022-05-31 16:33 | caristu | Assigned To | => caristu |
| 2022-05-31 16:34 | caristu | Relationship added | related to 0049358 |
| 2022-05-31 16:37 | hgbot | Note Added: 0137902 | |
| 2022-06-07 13:57 | hgbot | Note Added: 0138112 | |
| 2022-06-15 13:21 | hgbot | Resolution | open => fixed |
| 2022-06-15 13:21 | hgbot | Status | new => closed |
| 2022-06-15 13:21 | hgbot | Note Added: 0138367 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138368 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138369 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138370 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138371 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138372 | |
| 2022-06-15 13:21 | hgbot | Note Added: 0138373 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |