Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049391
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Modules] Open APImajorhave not tried2022-05-24 18:262022-06-01 17:28
ReportervmromanosView Statuspublic 
Assigned ToTriage Omni WMS 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0049391: Use searchkey instead of name in warehouse related entity mappings

DescriptionRecently we added the following entity mappings related to warehouse:
* Goods movement (IN/OUT)
* Physical inventory (IN/OUT)
* Stock (OUT)

For all of them we tried to follow the same approach: to identify the warehouse and organization by name.

This approach is wrong and we should be using search key instead for both entities
Steps To ReproduceNA
Proposed SolutionChange all the places where we are using name to identify the organization or warehouse to use the searchkey instead.

This implies: imports, exports, and export filter parameters.

Note that it will require to change the Entity Mapping definition, any java code related (like Property mapping handlers), and automated tests.
TagsFASH
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0049329 closedTriage Omni WMS Openbravo ERP Openbravo API to support Goods Movement 
caused by feature request 0049164 closedTriage Omni WMS Openbravo ERP Openbravo API to export current Stock 
caused by feature request 0049155 closedTriage Omni WMS Openbravo ERP Openbravo API to support Physical Inventories 

-  Notes
(0137720)
hgbot (developer)
2022-05-25 11:18

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/51 [^]
(0137721)
hgbot (developer)
2022-05-25 11:19

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/17 [^]
(0137948)
hgbot (developer)
2022-06-01 17:28

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 9a7ace1fc502b10369aa52e5654e6494e942f32c
Author: Prakash M <prakash@qualiantech.com>
Date: 01-06-2022 15:28:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/9a7ace1fc502b10369aa52e5654e6494e942f32c [^]

Fixes ISSUE-49391: Changed to searchkey instead of name in warehouse and organization entity mappings

---
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
M src/org/openbravo/api/mappings/goodsmovementline/ImportGoodsMvmtLineJavaPropertyMappingHandler.java
---
(0137949)
hgbot (developer)
2022-06-01 17:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/51 [^]
(0137950)
hgbot (developer)
2022-06-01 17:28

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a30ddbf301ab53f2dd6d6a62247188ced44f536f
Author: Prakash M <prakash@qualiantech.com>
Date: 25-05-2022 14:45:47
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a30ddbf301ab53f2dd6d6a62247188ced44f536f [^]

Related to ISSUE-49391: Fixed test by changing to searchkey instead of name for warehouse and organization

---
M src-test/data/export/filter/inventory/InventoryByWarehouseDateRange.json
M src-test/data/export/filter/stock/StockByProduct.json
M src-test/data/export/filter/stock/StockByWarehouse.json
M src-test/data/export/filter/stock/StockByWarehouseBin.json
M src-test/data/export/filter/stock/StockByWarehouseBinProduct.json
M src-test/data/importer/GoodsMovement.json
M src-test/data/importer/Inventory.json
---
(0137951)
hgbot (developer)
2022-06-01 17:28

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/17 [^]

- Issue History
Date Modified Username Field Change
2022-05-24 18:26 vmromanos New Issue
2022-05-24 18:26 vmromanos Assigned To => Triage Platform Conn
2022-05-24 18:26 vmromanos OBNetwork customer => No
2022-05-24 18:26 vmromanos Assigned To Triage Platform Conn => ramprakash
2022-05-24 18:28 vmromanos Relationship added caused by 0049329
2022-05-24 18:28 vmromanos Relationship added caused by 0049164
2022-05-24 18:28 vmromanos Relationship added caused by 0049155
2022-05-25 08:20 vmromanos Assigned To ramprakash => Triage Omni WMS
2022-05-25 11:18 hgbot Merge Request Status => open
2022-05-25 11:18 hgbot Note Added: 0137720
2022-05-25 11:19 hgbot Note Added: 0137721
2022-05-30 08:48 rafaroda Issue Monitored: rafaroda
2022-05-30 08:48 rafaroda Tag Attached: FASH
2022-06-01 17:28 hgbot Merge Request Status open => approved
2022-06-01 17:28 hgbot Resolution open => fixed
2022-06-01 17:28 hgbot Status new => closed
2022-06-01 17:28 hgbot Note Added: 0137948
2022-06-01 17:28 hgbot Note Added: 0137949
2022-06-01 17:28 hgbot Note Added: 0137950
2022-06-01 17:28 hgbot Note Added: 0137951

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker