0049324: Missing coupon argument in obidcoPreAddCouponHook

Description

The coupon argument is missing in obidcoPreAddCouponHook and with the Check Barcode Duplicity preference enabled a ticket can't be paid using digital coupons

Steps To Reproduce

Enable Check Barcode Duplicity preference
Log In YS-11 Pos terminal
Create a new receipt and add a new payment using digital coupon

Proposed Solution

Add the coupon arg in the hook call to properly check if the coupon is duplicated

Tags

No tags attached.

Attached Files

Added-coupon-parameter-to-obidcoPreAddCoup.patch [^] (792 bytes) 2022-05-14 06:49 [Show Content] [Hide Content]

---
 .../js/modalDigitalCoupons.js                                  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js b/web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js
index bf70c20..4a05b35 100644
--- a/web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js
+++ b/web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js
@@ -311,7 +311,8 @@ enyo.kind({
           OB.UTIL.HookManager.executeHooks(
             'obidcoPreAddCouponHook',
             {
-              digitalCouponWindow: me
+              digitalCouponWindow: me,
+              coupon: coupon
             },
             function(args) {
               if (args && args.cancellation) {
-- 
2.30.2

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0049325

closed

rqueralta

Barcode duplicity in digital coupons doesn't check draft payments if more than one order is paid

Notes
(0137638) hgbot (developer) 2022-05-23 15:35	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/merge_requests/8 [^]

(0137800) hgbot (developer) 2022-05-27 07:59	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons [^] Changeset: 67d40a05fb180da1073e3e02d1d503aeec709ebd Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 19-05-2022 11:46:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/commit/67d40a05fb180da1073e3e02d1d503aeec709ebd [^] Fixed BUG-49324: Added coupon argument in obidcoPreAddCouponHook --- M web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js ---

(0137801) hgbot (developer) 2022-05-27 07:59	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/merge_requests/8 [^]

Issue History
Date Modified	Username	Field	Change
2022-05-14 06:22	collazoandy4	New Issue
2022-05-14 06:22	collazoandy4	Assigned To	=> Retail
2022-05-14 06:22	collazoandy4	OBNetwork customer	=> Gold
2022-05-14 06:22	collazoandy4	Triggers an Emergency Pack	=> No
2022-05-14 06:36	collazoandy4	Relationship added	blocks 0049325
2022-05-14 06:49	collazoandy4	File Added: Added-coupon-parameter-to-obidcoPreAddCoup.patch
2022-05-18 22:00	rqueralta	Assigned To	Retail => rqueralta
2022-05-18 22:00	rqueralta	Status	new => scheduled
2022-05-23 15:35	hgbot	Merge Request Status	=> open
2022-05-23 15:35	hgbot	Note Added: 0137638
2022-05-27 07:59	hgbot	Merge Request Status	open => approved
2022-05-27 07:59	hgbot	Resolution	open => fixed
2022-05-27 07:59	hgbot	Status	scheduled => closed
2022-05-27 07:59	hgbot	Note Added: 0137800
2022-05-27 07:59	hgbot	Note Added: 0137801