Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049315
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Restaurantsminorhave not tried2022-05-12 19:472022-05-25 15:13
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049315: Menu items: coupon on line level of a menu item prints also menuitems of the line

DescriptionSee attached screenshot. The coupon menu item is printed on the buy notification template but the menuitems are repeated on the coupon as well.
Steps To ReproduceConfigure two menu products of a menu to be coupon on line level. Add them to the menu, pay, check the printed coupon
Proposed SolutionWhen building the set of lines/menuItem to be printed on a coupon the line.menuItems property is copied into the object created for the menuItem. This code [1], prevent this.

[1]
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/blob/master/web-jspack/org.openbravo.pos2.restaurant/src/core/pickupPoint/RestaurantPickupHandler.js#L66 [^]
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2022-05-12 19-23-29.png [^] (58,568 bytes) 2022-05-12 19:47

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137239)
hgbot (developer)
2022-05-12 20:24

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/142 [^]
(0137726)
hgbot (developer)
2022-05-25 15:13

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 1587536dde2b14792bb88effba6fccc70d5d4c8b
Author: Martin Taal <martin.taal@openbravo.com>
Date: 25-05-2022 13:12:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/1587536dde2b14792bb88effba6fccc70d5d4c8b [^]

Fixes ISSUE-49315: make sure that menuItem lines do not contain menuItems

---
M web-jspack/org.openbravo.pos2.restaurant/src/core/pickupPoint/RestaurantPickupHandler.js
---
(0137727)
hgbot (developer)
2022-05-25 15:13

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/142 [^]

- Issue History
Date Modified Username Field Change
2022-05-12 19:47 mtaal New Issue
2022-05-12 19:47 mtaal Assigned To => mtaal
2022-05-12 19:47 mtaal File Added: Screenshot from 2022-05-12 19-23-29.png
2022-05-12 19:47 mtaal Triggers an Emergency Pack => No
2022-05-12 20:24 hgbot Note Added: 0137239
2022-05-12 20:36 mtaal Status new => scheduled
2022-05-12 20:36 mtaal Status scheduled => resolved
2022-05-12 20:36 mtaal Resolution open => fixed
2022-05-25 15:13 hgbot Status resolved => closed
2022-05-25 15:13 hgbot Note Added: 0137726
2022-05-25 15:13 hgbot Note Added: 0137727


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker