Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049197
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Restaurantsmajoralways2022-05-03 15:402022-06-07 19:46
Reportertimothee_catteeuwView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049197: JIRA 2934 - Verified return has to call EcranCuissonService.svc/rest/AnnulerCommande when product is linked to pager

DescriptionIn restaurant context sometimes a product can be a pager product. When this kind of product is included in the basket, after paying a WS call to a pager server is done, ex : http://127.0.0.1/EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI [^]

This call inform the cooker working in the kitchen.

But the customer can ask the cashier to cancel his order containing the previous product. In that case it is necessary to call again the pager server, ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^]

Nowadays this call is only implemented when an order is cancel and replace.

The request here is to implement that also when doing a verified return, because this option will be also selected by the cashier in order to return a product and this product can be a pager product.
Steps To ReproduceCase 1 :

Do a ticket including a pager product

Pay it

Check WS calls done from the till, this call is done for the pager product, EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI

go to sales history on WebPos

search for the order you previously done and select the verified return option

select the pager product and valid

click on reimburse button

→ KO, no call is done for the pager product which was returned

It is necessary to call the pager server with the numéro de commande linked to the product (ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^])

As a reminder Numéro de commande =
POS Number + 'D' + Ticket nmuber + 'D' + Product line number in the order

Example = 50069D651D0

Case 2 :

Do a ticket including several pager products

Pay it

Check WS calls done from the till, several calls are done (1 by pager product) EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI

go to sales history on WebPos

search for the order you previously done and select the verified return option

select all the products in the ticket and valid

click on reimburse button

→ KO, no call is done for the pager products which were returned

It is necessary to call the pager server for each product with the linked numéro de commande (ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^])

As a reminder Numéro de commande =
POS Number + 'D' + Ticket nmuber + 'D' + Product line number in the order

Example = 50069D651D0
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137988)
hgbot (developer)
2022-06-02 14:18

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/38 [^]
(0138099)
hgbot (developer)
2022-06-06 22:41

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/992 [^]
(0138131)
hgbot (developer)
2022-06-07 19:32

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/151 [^]
(0138132)
hgbot (developer)
2022-06-07 19:41

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 01eb2012c0f6e3e5151abfa625de95e496662c0f
Author: Martin Taal <martin.taal@openbravo.com>
Date: 07-06-2022 17:41:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/01eb2012c0f6e3e5151abfa625de95e496662c0f [^]

Related to ISSUE-49197: use the correct property names in the menu item and implement clear dcm info in the pickuphandler

---
M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java
M web-jspack/org.openbravo.pos2.restaurant/src/core/pickupPoint/RestaurantPickupHandler.js
---
(0138133)
hgbot (developer)
2022-06-07 19:41

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/151 [^]
(0138134)
hgbot (developer)
2022-06-07 19:45

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 2134acc563a4dfbc84d51bc9e170a07d2963da4f
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 07-06-2022 17:45:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/2134acc563a4dfbc84d51bc9e170a07d2963da4f [^]

Related to BUG-49197: Add lineNo information when adding verified return ticket line.

---
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
---
(0138135)
hgbot (developer)
2022-06-07 19:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/38 [^]
(0138136)
hgbot (developer)
2022-06-07 19:46

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/992 [^]
(0138137)
hgbot (developer)
2022-06-07 19:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: adee2d302ab92df178a36a545ebda7d75fd9a4c2
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 07-06-2022 17:46:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/adee2d302ab92df178a36a545ebda7d75fd9a4c2 [^]

Fixes BUG-49197: JIRA 2934 - Verified return has to call EcranCuissonService.svc/rest/AnnulerCommande when product is linked to pager

---
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/PickupHandler.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/DCMController.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/__test__/PagerDeliveryControlMethod.test.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/registerDeliveryControlMethods.js
---

- Issue History
Date Modified Username Field Change
2022-05-03 15:40 timothee_catteeuw New Issue
2022-05-03 15:40 timothee_catteeuw Assigned To => Retail
2022-05-03 15:40 timothee_catteeuw Triggers an Emergency Pack => No
2022-05-12 23:21 mtaal Assigned To Retail => AtulOpenbravo
2022-05-16 20:04 mtaal Assigned To AtulOpenbravo => mtaal
2022-05-16 20:06 mtaal Assigned To mtaal => AtulOpenbravo
2022-05-25 13:46 AtulOpenbravo Status new => scheduled
2022-06-02 14:18 hgbot Note Added: 0137988
2022-06-06 22:41 hgbot Note Added: 0138099
2022-06-07 19:32 hgbot Note Added: 0138131
2022-06-07 19:41 hgbot Note Added: 0138132
2022-06-07 19:41 hgbot Note Added: 0138133
2022-06-07 19:45 hgbot Note Added: 0138134
2022-06-07 19:45 hgbot Note Added: 0138135
2022-06-07 19:46 hgbot Note Added: 0138136
2022-06-07 19:46 hgbot Resolution open => fixed
2022-06-07 19:46 hgbot Status scheduled => closed
2022-06-07 19:46 hgbot Note Added: 0138137


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker