Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048948
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] French Fiscalmajorhave not tried2022-03-31 15:342023-03-06 18:17
ReportershuehnerView Statuspublic 
Assigned Tofrancisco_ofarril 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0048948: certification.france.dev: Fix HQL queries not using HQL style + not using bind-parameters

DescriptionThis module contains several HQL queries not following the HQL style we have (i.e. avoiding StringBuilder).
Apart several having non-constant parts inside their HQL (i.e. dynamic entity name) which fails automatic checking (maybe rewritable with OBCriteria insead).
Steps To Reproduce-
Proposed SolutionApply HQL Style to all queries
+ Review the ones having dynamic entity names
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0136215)
shuehner (administrator)
2022-03-31 15:35

 Issue is to be fixed mainly in .dev module to improve automated code-checking. If while doing this all issues are formal fixes only push to non-dev repo is not required to be done immediately) => But should be done eventually to keep both in sync.
(0144946)
hgbot (developer)
2022-12-22 19:53

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/30 [^]
(0146937)
hgbot (developer)
2023-02-23 18:09

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: 0aeb99b24969ea268ec86d27211bba07f826223c
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 23-02-2023 17:09:03
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/0aeb99b24969ea268ec86d27211bba07f826223c [^]

Fixes ISSUE-48948: Fix HQL queries not using HQL style + not using bind-parameters

---
M src/org/openbravo/certification/france/aggregation/AggregationDayDao.java
M src/org/openbravo/certification/france/aggregation/AggregationYearDao.java
M src/org/openbravo/certification/france/alert/AlertUtils.java
M src/org/openbravo/certification/france/background/FrenchFiscalSecurityManager.java
M src/org/openbravo/certification/france/ticket/TicketUtils.java
M src/org/openbravo/certification/france/ui/UIIssueHandlerHelper.java
M src/org/openbravo/certification/france/ui/UIUtils.java
M src/org/openbravo/certification/france/ui/UIVerificationBackground.java
M src/org/openbravo/certification/france/utils/TerminalUtils.java
---
(0146938)
hgbot (developer)
2023-02-23 18:09

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/30 [^]
(0146961)
hgbot (developer)
2023-02-24 10:12

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/7 [^]
(0146976)
hgbot (developer)
2023-02-24 12:19

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/7 [^]
(0146979)
hgbot (developer)
2023-02-24 12:19

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: 21eeb16ecdbab75ac5b201f2eb35e104e4297056
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 24-02-2023 11:19:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/21eeb16ecdbab75ac5b201f2eb35e104e4297056 [^]

Fixes ISSUE-51440, Fixes ISSUE-51510, Fixes ISSUE-48948: Obfuscate from dev

---
A web-jspack/org.openbravo.certification.france/src/registerGlobalAction.js
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/sourcedata/AD_MODULE.xml
M web-jspack/org.openbravo.certification.france/src/ob-init.js
M web-jspack/org.openbravo.certification.france/src/registerLoginAction.js
M web-jspack/org.openbravo.certification.france/src/registerRemoteServerListener.js
M web/org.openbravo.certification.france/app/model/business-object/html/Html.js
M web/org.openbravo.certification.france/app/model/business-object/html/HtmlUtils.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/AddObcfrTerminalMonitor.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/CompleteTicketPostHook.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/InitializeHtml.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/PrintTicketPostHook.js
M web/org.openbravo.certification.france/js/terminal/terminalLoadedFromBackendHook.js
M web/org.openbravo.certification.france/js/terminalmonitor/connectedToERPEvent.js
---
(0147203)
hgbot (developer)
2023-03-01 23:31

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/37 [^]
(0147284)
hgbot (developer)
2023-03-06 09:43

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: c3716ba7542dd491c8c2d692c48ef7340940e06c
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 06-03-2023 08:43:37
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/c3716ba7542dd491c8c2d692c48ef7340940e06c [^]

Related to ISSUE-48948: Add setMaxResults(1) when use uniqueResult()

---
M src/org/openbravo/certification/france/aggregation/AggregationYearDao.java
M src/org/openbravo/certification/france/background/FrenchFiscalSecurityManager.java
M src/org/openbravo/certification/france/ui/UIIssueHandlerHelper.java
---
(0147285)
hgbot (developer)
2023-03-06 09:43

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/37 [^]
(0147303)
hgbot (developer)
2023-03-06 15:19

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/8 [^]
(0147305)
hgbot (developer)
2023-03-06 18:17

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: c328ab234558b891a55e8fa812a579c6c169ac14
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 06-03-2023 17:17:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/c328ab234558b891a55e8fa812a579c6c169ac14 [^]

Related to ISSUE-48948: Add setMaxResults(1) when use uniqueResult(). Obfuscate from dev

---
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/sourcedata/AD_MODULE.xml
---
(0147306)
hgbot (developer)
2023-03-06 18:17

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/8 [^]

- Issue History
Date Modified Username Field Change
2022-03-31 15:34 shuehner New Issue
2022-03-31 15:34 shuehner Assigned To => Triage Omni OMS
2022-03-31 15:34 shuehner OBNetwork customer => OBPS
2022-03-31 15:34 shuehner Issue generated from 0048946
2022-03-31 15:34 shuehner Relationship added blocks 0041287
2022-03-31 15:35 shuehner Note Added: 0136215
2022-03-31 15:39 shuehner OBNetwork customer OBPS => No
2022-12-16 15:34 aferraz Assigned To Triage Omni OMS => francisco_ofarril
2022-12-16 17:33 francisco_ofarril Status new => acknowledged
2022-12-22 19:53 hgbot Merge Request Status => open
2022-12-22 19:53 hgbot Note Added: 0144946
2023-01-23 17:15 hgbot Note Added: 0145771
2023-01-30 17:56 aferraz Note Deleted: 0145771
2023-02-23 17:13 hgbot Merge Request Status open => approved
2023-02-23 18:09 hgbot Resolution open => fixed
2023-02-23 18:09 hgbot Status acknowledged => closed
2023-02-23 18:09 hgbot Note Added: 0146937
2023-02-23 18:09 hgbot Note Added: 0146938
2023-02-24 10:12 hgbot Note Added: 0146961
2023-02-24 12:19 hgbot Note Added: 0146976
2023-02-24 12:19 hgbot Note Added: 0146979
2023-03-01 23:31 hgbot Note Added: 0147203
2023-03-06 09:43 hgbot Note Added: 0147284
2023-03-06 09:43 hgbot Note Added: 0147285
2023-03-06 15:19 hgbot Note Added: 0147303
2023-03-06 18:17 hgbot Note Added: 0147305
2023-03-06 18:17 hgbot Note Added: 0147306

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker