Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048415 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | have not tried | 2022-01-18 11:27 | 2022-01-25 07:53 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048415: This module is using bad logging (System.out,System.err println or printStackTrace) | |||||||
| Description | Ongoing work is trying to remove all those examples of bad logging for all modules. With the goal to eventually add a check in CI to avoid introducing new ones. pos2 recently added new bad code in 48171 which needs to be fixed | |||||||
| Steps To Reproduce | https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/src/org/openbravo/pos2/SafeboxCashupHistory.java#L112 [^] | |||||||
| Proposed Solution | Use proper log4j | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0134534) hgbot (developer) 2022-01-24 18:20 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/789 [^] |
|
(0134538) hgbot (developer) 2022-01-25 07:53 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: d9fb95ae615626104d389b8d5ced3722c68f89f4 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 24-01-2022 18:18:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d9fb95ae615626104d389b8d5ced3722c68f89f4 [^] Fixed ISSUE-48415: use correct way of logging errors --- M src/org/openbravo/pos2/SafeboxCashupHistory.java --- |
|
(0134539) hgbot (developer) 2022-01-25 07:53 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/789 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-01-18 11:27 | shuehner | New Issue | |
| 2022-01-18 11:27 | shuehner | Assigned To | => Retail |
| 2022-01-18 11:27 | shuehner | Triggers an Emergency Pack | => No |
| 2022-01-18 11:28 | shuehner | Relationship added | caused by 0048171 |
| 2022-01-18 11:28 | shuehner | Relationship added | blocks 0036162 |
| 2022-01-24 13:30 | gorka_gil | Assigned To | Retail => gorka_gil |
| 2022-01-24 18:20 | hgbot | Note Added: 0134534 | |
| 2022-01-25 07:53 | hgbot | Resolution | open => fixed |
| 2022-01-25 07:53 | hgbot | Status | new => closed |
| 2022-01-25 07:53 | hgbot | Note Added: 0134538 | |
| 2022-01-25 07:53 | hgbot | Note Added: 0134539 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |