Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0004832 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | N/A | 2008-09-05 17:36 | 2009-04-21 11:05 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 7076 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0004832: Remove unused validation-code (js & html) for WAD-generated windows | |||||||
| Description | Some of JS-code used in validation for these windows does nothing: The inrange-check does not to anything The valid-check does not do anything for the TextBox & TextArea widgets. The js-script and the corresponding blocks of the HTML-code should be removed to make the pages more lightweight | |||||||
| Tags | performance2.40scrum, Sprint-1 | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0008898) shuehner (administrator) 2008-09-05 17:39 |
The proposed changes decrease the size of the generated pages by about 9mb in total and the size of i.e. the product window (form-view) by 27kb |
|
(0008900) svnbot (reporter) 2008-09-05 18:31 |
Repository: openbravo Revision: 6928 Author: huehner Date: 2008-09-05 18:31:34 +0200 (Fri, 05 Sep 2008) Fixed 4832 Modify js-validation for WAD-generated windows - remove isInRange validation code from all widgets (was a no-op) - remove isValid validation from Textbox & Textarea widgets (was a no-op) - remove (html,xml,java) support-code for the removed validations --- U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.html U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.java U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.html U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.java U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.html U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.java U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.html U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.java U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.html U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.java U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.html U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.java U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.html U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.java U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.html U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.java U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADString.html U trunk/src-wad/src/org/openbravo/wad/controls/WADString.java U trunk/src-wad/src/org/openbravo/wad/controls/WADString.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html U trunk/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.html U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.java U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.xml U trunk/web/js/default/DateTextBox.js U trunk/web/js/default/TimeTextBox.js U trunk/web/js/default/UrlTextBox.js U trunk/web/js/default/ValidationIntegerBox.js U trunk/web/js/default/ValidationNumberBox.js U trunk/web/js/default/ValidationTextArea.js U trunk/web/js/default/ValidationTextBox.js --- https://dev.openbravo.com/websvn/openbravo/?rev=6928&sc=1 [^] |
|
(0008934) svnbot (reporter) 2008-09-09 12:06 |
Repository: openbravo Revision: 7076 Author: huehner Date: 2008-09-09 12:06:30 +0200 (Tue, 09 Sep 2008) Issue 4832 Removed unused validation code (js & html) --- U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.html U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.java U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.xml U branches/r2.40performance/web/js/default/DateTextBox.js U branches/r2.40performance/web/js/default/TimeTextBox.js U branches/r2.40performance/web/js/default/UrlTextBox.js U branches/r2.40performance/web/js/default/ValidationIntegerBox.js U branches/r2.40performance/web/js/default/ValidationNumberBox.js U branches/r2.40performance/web/js/default/ValidationTextArea.js U branches/r2.40performance/web/js/default/ValidationTextBox.js --- https://dev.openbravo.com/websvn/openbravo/?rev=7076&sc=1 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2008-09-05 17:36 | shuehner | New Issue | |
| 2008-09-05 17:36 | shuehner | Assigned To | => shuehner |
| 2008-09-05 17:36 | shuehner | sf_bug_id | 0 => 2095216 |
| 2008-09-05 17:36 | shuehner | Regression testing | => No |
| 2008-09-05 17:39 | shuehner | Note Added: 0008898 | |
| 2008-09-05 17:39 | shuehner | Status | new => scheduled |
| 2008-09-05 17:39 | shuehner | fix_in_branch | => trunk |
| 2008-09-05 18:00 | shuehner | fix_in_branch | trunk => |
| 2008-09-05 18:00 | shuehner | Description Updated | |
| 2008-09-05 18:31 | svnbot | Checkin | |
| 2008-09-05 18:31 | svnbot | Note Added: 0008900 | |
| 2008-09-05 18:31 | svnbot | Status | scheduled => resolved |
| 2008-09-05 18:31 | svnbot | Resolution | open => fixed |
| 2008-09-05 18:31 | svnbot | svn_revision | => 6928 |
| 2008-09-09 10:51 | shuehner | Tag Attached: performance2.40scrum | |
| 2008-09-09 12:06 | svnbot | Checkin | |
| 2008-09-09 12:06 | svnbot | Note Added: 0008934 | |
| 2008-09-09 12:06 | svnbot | svn_revision | 6928 => 7076 |
| 2008-10-23 07:48 | iperdomo | Tag Attached: sprint1 | |
| 2008-10-24 18:05 | iperdomo | Tag Detached: sprint1 | |
| 2008-10-24 18:05 | iperdomo | Tag Attached: Sprint-1 | |
| 2009-04-21 11:05 | psarobe | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |