Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0048167

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] Core

major

always

2021-11-26 12:20

2022-01-03 18:14

Reporter

javierRodriguez

View Status

public

Assigned To

elara

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0048167: The application does not show a properly message when there is and error during the initialization

Description

If there is an error in any init process, like cashup, the application show a generic message which it does not indicate something useful.

For example, if the application receives an error response from cashup process due to a corrupted cashup, the application shows "The application could not be initialized. The server may not be available and the cache has not enough data. Check your server connection and try again."

Steps To Reproduce

- Include the patch attached
- Try to login

Proposed Solution

This standard message is shown due to the error type is not a initializationError. The error is thrown by posterminal initCashup file with ActionCanceled class and this kind of error is from core2.

check LoginProcess file in core2 module. handleInitializationError function

Tags

No tags attached.

posterminal.diff [^] (812 bytes) 2021-11-26 12:20 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js b/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
index 071c8b52a..0e4713b2a 100644
--- a/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
+++ b/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
@@ -116,7 +116,7 @@
   OB.App.StateAPI.Global.initCashup.addActionPreparation(
     async (state, payload) => {
       const newPayload = { ...payload };
-
+      throw new OB.App.Class.ActionCanceled('custom message from backend');
       if (OB.App.State.Cashup.Utils.isValidTheLocalCashup(state.Cashup)) {
         // init from local
         newPayload.initCashupFrom = 'local';

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0133518) hgbot (developer) 2021-12-07 19:14	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/676 [^]

(0134105) hgbot (developer) 2022-01-03 18:14	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 7b47f3dd6c119b1d6496842e6e0edca590084f17 Author: Eduardo Lara <eduardo.lara@smfconsulting.es> Date: 03-01-2022 18:13:15 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7b47f3dd6c119b1d6496842e6e0edca590084f17 [^] Fixes ISSUE-48167: Show specific error instead of generic one at Initialization Error --- M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js M web-jspack/org.openbravo.core2/src/core/authentication/__test__/LoginProcess.test.js ---

(0134106) hgbot (developer) 2022-01-03 18:14	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/676 [^]

Issue History
Date Modified	Username	Field	Change
2021-11-26 12:20	javierRodriguez	New Issue
2021-11-26 12:20	javierRodriguez	Assigned To	=> Retail
2021-11-26 12:20	javierRodriguez	File Added: posterminal.diff
2021-11-26 12:20	javierRodriguez	Triggers an Emergency Pack	=> No
2021-11-26 12:23	javierRodriguez	Category	POS => Core
2021-11-26 12:23	javierRodriguez	Proposed Solution updated
2021-12-02 18:47	elara	Assigned To	Retail => elara
2021-12-02 19:19	elara	Status	new => acknowledged
2021-12-03 13:22	elara	Status	acknowledged => scheduled
2021-12-06 13:21	elara	Status	scheduled => acknowledged
2021-12-07 15:47	elara	Status	acknowledged => scheduled
2021-12-07 19:14	hgbot	Note Added: 0133518
2022-01-03 18:14	hgbot	Resolution	open => fixed
2022-01-03 18:14	hgbot	Status	scheduled => closed
2022-01-03 18:14	hgbot	Note Added: 0134105
2022-01-03 18:14	hgbot	Note Added: 0134106

Copyright © 2000 - 2009 MantisBT Group