Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048149
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-11-24 07:482021-11-30 08:25
Reporterswathi_kamalView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket33272
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048149: Problem in hook precustomeraddrsave and precustomersave

DescriptionWhen saving new address or new customer in POS, Save button should not be disabled after presavehook hook is cancelled.
If hook OBPOS_PreCustomerAddrSave is cancelled then save button should be enabled again.
Steps To ReproduceIn POS,
1. Provide Cancellation=true for hook precustomeraddrsave in console.
OB.UTIL.HookManager.registerHook('OBPOS_PreCustomerAddrSave', function(args, callbacks) {
args.cancellation = true;
OB.UTIL.showError('test');

OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});
2. Click on customer address and create new address.
3. Provide mandatory details and press save.
4. Save button is disabled. But it should not be disabled.
Proposed SolutionCheck attached patch.
TagsNo tags attached.
Attached Filesdiff file icon Ticket_33272_Problem_in_hooks_patch.diff [^] (1,556 bytes) 2021-11-24 07:48 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0133389)
hgbot (developer)
2021-11-26 13:18

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/639 [^]
(0133406)
hgbot (developer)
2021-11-30 08:25

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/639 [^]
(0133407)
hgbot (developer)
2021-11-30 08:25

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ece532cff411ee410f10f0850b3f27c21fd7f9db
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-11-26T11:38:55+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ece532cff411ee410f10f0850b3f27c21fd7f9db [^]

Fixed ISSUE-48149: Save Button should be enabled when PreSave hook is cancelled
* When saving Customer / CustomerAddress, if PreSave hook is failed, then Save button should be enabled again

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---

- Issue History
Date Modified Username Field Change
2021-11-24 07:48 swathi_kamal New Issue
2021-11-24 07:48 swathi_kamal Assigned To => Retail
2021-11-24 07:48 swathi_kamal File Added: Ticket_33272_Problem_in_hooks_patch.diff
2021-11-24 07:48 swathi_kamal OBNetwork customer => Gold
2021-11-24 07:48 swathi_kamal Support ticket => 33272
2021-11-24 07:48 swathi_kamal Triggers an Emergency Pack => No
2021-11-24 08:21 Practics Issue Monitored: Practics
2021-11-25 16:21 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-11-26 13:18 hgbot Merge Request Status => open
2021-11-26 13:18 hgbot Note Added: 0133389
2021-11-30 08:25 hgbot Merge Request Status open => approved
2021-11-30 08:25 hgbot Resolution open => fixed
2021-11-30 08:25 hgbot Status new => closed
2021-11-30 08:25 hgbot Note Added: 0133406
2021-11-30 08:25 hgbot Fixed in Version => RR22Q1
2021-11-30 08:25 hgbot Note Added: 0133407

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker